New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804258 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression: No Text field is seen to enter Web proxy auto discovery URL in proxy overlay

Project Member Reported by kebalaji@chromium.org, Jan 22 2018

Issue description

Chrome Version:66.0.3327.0/10330.0.0 dev channel Daisy,Kip,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build>> Connect to Network>> Click on Ubertray and on connected network 
(2)In Proxy overlay, change the Proxy connection type to Web proxy auto discovery and observe

Expected: Text field to enter the URL should be seen like in case of Automatic proxy configuration
Actual: No Text field is seen to enter Web proxy auto discovery URL

This is a Non-Regression issue seen from M-62

Note: 1. Issue is also seen in chrome://settings
      2. Issue is not seen in Linux,Windows OS
      3. Issue is also seen on M63 stable, M64 beta and on M65 
 
ActualWebproxy.mp4
10.5 MB View Download

Comment 1 Deleted

Cc: bettes@chromium.org
Labels: -Pri-1 -M-65 M-66 Pri-3
Status: Assigned (was: Started)
Ignore (deleted) comment #1 - This is actually a minor ui issue. The field is not editable. We just don't a greyed out underline when the field is empty. I'm not actually sure what the correct UX for this is.

+bettes@ for UX input: If we have a non editable field with no value set, should we show something, e.g. a greyed out underline for the empty non editiable text field?

Labels: Inhouse-HYD-Reported
Labels: -M-66 M-67
Status: Started (was: Assigned)
I'm going to go ahead and display "None" there instead of not displaying anything for now.

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc07db4d03dd7c212ac5369f078c71079523db8

commit 7fc07db4d03dd7c212ac5369f078c71079523db8
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Mar 07 16:26:14 2018

Network settings: WPAD: Show string when not provided

Bug:  804258 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I865bc4cf3fa00572775227e9b6ce455cfae57c85
Reviewed-on: https://chromium-review.googlesource.com/952464
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541455}
[modify] https://crrev.com/7fc07db4d03dd7c212ac5369f078c71079523db8/chrome/app/settings_strings.grdp
[modify] https://crrev.com/7fc07db4d03dd7c212ac5369f078c71079523db8/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/7fc07db4d03dd7c212ac5369f078c71079523db8/ui/webui/resources/cr_components/chromeos/network/network_proxy.js

Status: Fixed (was: Started)

Sign in to add a comment