New issue
Advanced search Search tips

Issue 804250 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Jan 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

PassKit & Download tests flaky

Project Member Reported by sdefresne@chromium.org, Jan 22 2018 
The following tests have been failing flakily since Friday 2018-01-19 (at least, I was not sheriff before then) on :

LegacyDownloadManagerControllerTest.TestStart
PassKitCoordinatorTest.ValidPassKitObject
PassKitCoordinatorTest.MultiplePassKitObjects

https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone11-device-x64%2F2310%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_unittests__iPhone_7_iOS_11.2.1__on_iOS-11.2.1%2F0%2Fstdout
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49f672129b623aefaf53c839c2b9442e25c8cab8

commit 49f672129b623aefaf53c839c2b9442e25c8cab8
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Mon Jan 22 11:16:18 2018

Mark flaky tests as FLAKY.

Bug:  804250 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifa2ba3fc08170bf600088e60651074372df1288a
Reviewed-on: https://chromium-review.googlesource.com/878220
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530838}
[modify] https://crrev.com/49f672129b623aefaf53c839c2b9442e25c8cab8/ios/chrome/browser/ui/download/legacy_download_manager_controller_unittest.mm
[modify] https://crrev.com/49f672129b623aefaf53c839c2b9442e25c8cab8/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ca2c94dc6e20c08e82843db498227079df96039

commit 6ca2c94dc6e20c08e82843db498227079df96039
Author: Eugene But <eugenebut@google.com>
Date: Wed Jan 24 00:04:57 2018

Fix flaky download and passkit tests.

AppLauncherCoordinatorTest was mocking UIApplication class and broke
the tests. This CL stops UIApplication mocking and enables the following
tests:
 - LegacyDownloadManagerControllerTest.TestStart
 - PassKitCoordinatorTest.ValidPassKitObject
 - PassKitCoordinatorTest.MultiplePassKitObjects

Bug:  804250 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifaabf230e9be18603626d32989f3d1d4607188ca
Reviewed-on: https://chromium-review.googlesource.com/881960
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531393}
[modify] https://crrev.com/6ca2c94dc6e20c08e82843db498227079df96039/ios/chrome/browser/ui/app_launcher/app_launcher_coordinator_unittest.mm
[modify] https://crrev.com/6ca2c94dc6e20c08e82843db498227079df96039/ios/chrome/browser/ui/download/legacy_download_manager_controller_unittest.mm
[modify] https://crrev.com/6ca2c94dc6e20c08e82843db498227079df96039/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm

Comment 3 by eugene...@chromium.org, Jan 24 2018

Components: UI>Browser>Downloads
Status: Fixed (was: Assigned)
►

Sign in to add a comment