Enable hangout_services extension on try bots |
|||||
Issue descriptionThe hangout_services component extension enables certain features of the Google Hangouts site and the Hangouts Meet app. By default, it's only included in Chrome-branded builds. However, it doesn't require any internal code, and can be enabled with the enable_hangout_services_extension GN arg. [1] A recent CL of mine prevented this component extension from loading properly ( issue 802159 ). This broke Hangouts in Canary for ~5 days, causing failures in official continuous builders along with 3 duplicate bugs being filed. I suggest enabling the extension (and browser test) on the try bots, at least for debug builds. That would have prevented my bad CL from landing in the CQ. (In this case, I should have been able to detect the failure locally, and it's my fault for failing to do so. But changes to WebRTC APIs or the extensions system could easily cause breakages that the author would have no reason to suspect.) Is there any reason not to do this? [1] https://cs.chromium.org/chromium/src/chrome/common/features.gni?type=cs&q=enable_hangout_services_extension&sq=package:chromium
,
Jan 23 2018
,
Mar 16 2018
+infra folks, I have a couple proposals for how to set the "enable_hangout_services_extension" GN arg on the trybots. https://cs.chromium.org/chromium/src/chrome/common/features.gni?type=cs&q=enable_hangout_services&sq=package:chromium 1. Set the GN arg to (is_chrome_branded || dcheck_always_on). This enables the extension on all the builders that build this way, which is a lot. But enabling the component extension isn't really related to DCHECKs, so it seems ugly. 2. Add the "enable_hangout_services_extension" arg to specific recipes. I believe this would involve adding a config to recipe_modules/chromium/config.py, and then including this config in the relevant recipes. But most of those configs are about how Chrome is built, not whether certain features are enabled. Is there an alternative I'm missing?
,
Mar 16 2018
If it doesn't require any internal code, why isn't it enabled by default?
,
Mar 16 2018
Context being: I really, really don't like having flags that are on on the bots that devs don't get by default. DCHECK is special because of the dbg/rel split that also covers things.
,
Mar 16 2018
Good question. I don't know the history behind that decision or if it's still valid. The extension is only used on hangouts.google.com, which might be part of the rationale?
,
Mar 20 2018
The rationale is that it's a Google Chrome feature. (Setting status to assigned since it has an owner.)
,
Mar 20 2018
If it doesn't cause any problems, I think we should consider running these tests by default on the try bots. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by grunell@chromium.org
, Jan 22 2018Components: Blink>WebRTC