Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mastiz@google.com ...... too many results, data snipped.... and 40 other(s) in webkit_layout_tests failing on multiple builders Builders failed on: - WebKit Linux Trusty ASAN: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN
Reverting recent patch that introduced the implementation of the feature, https://chromium-review.googlesource.com/872120.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb6090e4fb1211fc252941dec186096e937010fb commit cb6090e4fb1211fc252941dec186096e937010fb Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Jan 22 10:32:50 2018 Revert "DevTools: Initial implementation of Sampling Native Heap Profiler." This reverts commit 958e86caee516974831b1471b1a4cb79248220b3. Reason for revert: tests broken on multiple builders, see linked bug. Original change's description: > DevTools: Initial implementation of Sampling Native Heap Profiler. > > The initial implementation has a single allocator instrumented and hooks onto the > base::allocator shim. > Support for other allocators (Oilpan GC, PartitionAlloc) as well as experimental DevTools UI > will be added in upcoming patches. > > The API to control the profiler is available through DevTools protocol. It introduces > the following methods to the Memory domain: > - startSamplingNativeHeapProfile > - stopSamplingNativeHeapProfile > - getSamplingNativeHeapProfile > > BUG= 803276 > > Change-Id: Id2df663cdaef3ee2a5fc7afbda66c8728921a732 > Reviewed-on: https://chromium-review.googlesource.com/872120 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530753} TBR=primiano@chromium.org,alph@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 803276 Bug: 804241 Change-Id: I99b168a77239013f4c3b61b97d424bcf623edc2e Reviewed-on: https://chromium-review.googlesource.com/878159 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#530830} [modify] https://crrev.com/cb6090e4fb1211fc252941dec186096e937010fb/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/a7a96e217861f61c0aa297a04447be39b43dce24/third_party/WebKit/LayoutTests/inspector-protocol/memory/sampling-native-profile-expected.txt [delete] https://crrev.com/a7a96e217861f61c0aa297a04447be39b43dce24/third_party/WebKit/LayoutTests/inspector-protocol/memory/sampling-native-profile.js [modify] https://crrev.com/cb6090e4fb1211fc252941dec186096e937010fb/third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.cpp [modify] https://crrev.com/cb6090e4fb1211fc252941dec186096e937010fb/third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.h [modify] https://crrev.com/cb6090e4fb1211fc252941dec186096e937010fb/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/cb6090e4fb1211fc252941dec186096e937010fb/third_party/WebKit/Source/core/inspector/browser_protocol.pdl [modify] https://crrev.com/cb6090e4fb1211fc252941dec186096e937010fb/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json [modify] https://crrev.com/cb6090e4fb1211fc252941dec186096e937010fb/third_party/WebKit/Source/platform/BUILD.gn [delete] https://crrev.com/a7a96e217861f61c0aa297a04447be39b43dce24/third_party/WebKit/Source/platform/memory_profiler/DEPS [delete] https://crrev.com/a7a96e217861f61c0aa297a04447be39b43dce24/third_party/WebKit/Source/platform/memory_profiler/OWNERS [delete] https://crrev.com/a7a96e217861f61c0aa297a04447be39b43dce24/third_party/WebKit/Source/platform/memory_profiler/SamplingNativeHeapProfiler.cpp [delete] https://crrev.com/a7a96e217861f61c0aa297a04447be39b43dce24/third_party/WebKit/Source/platform/memory_profiler/SamplingNativeHeapProfiler.h
Builders look green now, reassigning to owner, thanks!
The feature is not supposed to work on ASAN/MSAN bots. Need to add an exclude rule. Were there other bots failing?
Has been fixed already https://chromium-review.googlesource.com/882290
Comment 1 by mastiz@chromium.org
, Jan 22 2018Owner: mastiz@chromium.org
Status: Started (was: Available)