App freezes tapping on ‘Add to Apple Wallet’ from passsource.com |
|||||||
Issue descriptionApp Version: 65.0.3325.0 canary iOS Version: 10.3.3 ONLY Device: iPhone 7 URL : https://passsource.com Steps to reproduce: 1. Launch iOS Chrome 2. Navigate to www.passsource.com 3. Tap on ‘Create’ - to create a pass 4. Select the free template to create a pass (e.x. ‘Boarding Pass’) 5. Create a pass and Tap on ‘Add to Apple Wallet’ Observed results: App freezes and no action is performed tapping on ‘Cancel’ and ‘Add’ buttons Note: Need to force quit the app to go back to previous screen. Expected results: App should not freeze tapping on ‘Add to Apple Wallet’ and user should be able to ‘Add’ passes to wallet or ‘Cancel’ the installation Number of times you were able to reproduce: 3/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: No, Safari: No Bug reproducible on current stable build : M63, No Bug reproducible on the current beta channel build :M64, No Type-bug-regression? Yes Link to Image/Video: https://drive.google.com/open?id=1CtSYDGWhLXAzbSHZprcn581SUYUdlhYg
,
Jan 23 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03edb08fcbef7d40acfb74923308362b3f3f4d0b commit 03edb08fcbef7d40acfb74923308362b3f3f4d0b Author: Eugene But <eugenebut@google.com> Date: Wed Jan 24 16:36:30 2018 Fix PKAddPassesViewController dismissal. It is possible for PassKitCoordinator to be asked for dialog presentation while another dialog is already displayed. In this case coordinator should early return and do not override _viewController. Overriding _viewController will make coordinator loose a reference to currently presented dialog and it will not be possible to dismiss the presented dialog. Bug: 804209 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibb44d0bdb78247d291850354fcb11a309474e6d2 Reviewed-on: https://chromium-review.googlesource.com/881270 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#531555} [modify] https://crrev.com/03edb08fcbef7d40acfb74923308362b3f3f4d0b/ios/chrome/browser/ui/download/pass_kit_coordinator.mm [modify] https://crrev.com/03edb08fcbef7d40acfb74923308362b3f3f4d0b/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm
,
Jan 24 2018
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64c08d980e051c3f4413a067ca399febb8a7f9ff commit 64c08d980e051c3f4413a067ca399febb8a7f9ff Author: Eugene But <eugenebut@google.com> Date: Thu Jan 25 17:10:59 2018 Fix PKAddPassesViewController dismissal. It is possible for PassKitCoordinator to be asked for dialog presentation while another dialog is already displayed. In this case coordinator should early return and do not override _viewController. Overriding _viewController will make coordinator loose a reference to currently presented dialog and it will not be possible to dismiss the presented dialog. TBR=eugenebut@google.com (cherry picked from commit 03edb08fcbef7d40acfb74923308362b3f3f4d0b) Bug: 804209 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibb44d0bdb78247d291850354fcb11a309474e6d2 Reviewed-on: https://chromium-review.googlesource.com/881270 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531555} Reviewed-on: https://chromium-review.googlesource.com/887103 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#92} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/64c08d980e051c3f4413a067ca399febb8a7f9ff/ios/chrome/browser/ui/download/pass_kit_coordinator.mm [modify] https://crrev.com/64c08d980e051c3f4413a067ca399febb8a7f9ff/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm
,
Jan 30 2018
Verified on chrome canary version 66.0.3335.0 on iPhone 7 and iPhone 7 plus with iOS 10.3.3, following the steps mentioned in comment #0. No freezing occurs. Looks good.
,
Jan 31 2018
Verified on chrome beta version 65.0.3325.36 on iPhone 6 plus with iOS 10.3.3, following the steps mentioned in comment #0. No freezing occurs. Looks good.
,
Feb 9 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pkl@chromium.org
, Jan 22 2018Status: Assigned (was: Untriaged)