NetworkServiceInProcessBrowserTest.Basic in content_browsertests failing on multiple builders |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yoichio@google.com NetworkServiceInProcessBrowserTest.Basic in content_browsertests failing on multiple builders Builders failed on: - linux-chromeos-dbg: https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-dbg - Linux Tests (dbg)(1)(32): https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29 - Linux Tests (dbg)(1): https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29 - Mac10.9 Tests (dbg): https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29
,
Jan 22 2018
I will disable this test in dbg. It keeps failing.
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3767c2a1742aec0ef808fc56f826dff652df1b12 commit 3767c2a1742aec0ef808fc56f826dff652df1b12 Author: Qiang Xu <warx@chromium.org> Date: Mon Jan 22 18:09:52 2018 disable NetworkServiceInProcessBrowserTest.Basic on dbg TBR=jam@chromium.org TBR=yoichio@chromium.org Bug: 804204 Change-Id: I472a536059a54ad6b6273aa353d19280a1186c00 Reviewed-on: https://chromium-review.googlesource.com/879102 Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#530912} [modify] https://crrev.com/3767c2a1742aec0ef808fc56f826dff652df1b12/content/browser/network_service_browsertest.cc
,
Jan 22 2018
My fault; should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/879041. Shall I roll back the disable now?
,
Jan 23 2018
,
Jan 23 2018
Still failing on asan_clang_phone. See https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-clang-phone. This should be a debug build, so I think the disable must be failing, and the fix didn't fix this.
,
Jan 23 2018
Perhaps I am misreading those logs, but I can't find that specific failure. base_unittests, content_unittests, and content_browsertests are all failing, but I don't see NetworkServiceInProcessBrowserTest.Basic in the summaries at the bottom of each test suite's results.
,
Jan 23 2018
Apologies, you are right. I must have been looking at an older log.
,
Jan 23 2018
Re #4, you could try reverting the disabling CL, tks
,
Jan 24 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b77daa5ba54fcbcd379e5e556137bbfa6b611508 commit b77daa5ba54fcbcd379e5e556137bbfa6b611508 Author: Qiang(Joe) Xu <warx@chromium.org> Date: Wed Jan 24 17:09:47 2018 Revert "disable NetworkServiceInProcessBrowserTest.Basic on dbg" This reverts commit 3767c2a1742aec0ef808fc56f826dff652df1b12. Reason for revert: the broken CL is reverted Original change's description: > disable NetworkServiceInProcessBrowserTest.Basic on dbg > > TBR=jam@chromium.org > TBR=yoichio@chromium.org > > Bug: 804204 > Change-Id: I472a536059a54ad6b6273aa353d19280a1186c00 > Reviewed-on: https://chromium-review.googlesource.com/879102 > Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> > Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530912} TBR=jam@chromium.org,yoichio@chromium.org,warx@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 804204 Change-Id: I1936d206cc86d3cad2969c529e19a665966d651a Reviewed-on: https://chromium-review.googlesource.com/883564 Reviewed-by: Qiang(Joe) Xu <warx@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#531571} [modify] https://crrev.com/b77daa5ba54fcbcd379e5e556137bbfa6b611508/content/browser/network_service_browsertest.cc
,
Jan 27 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yoichio@chromium.org
, Jan 22 2018Owner: yoichio@chromium.org