desktop-pwas: Fix name for time delta histogram |
||||
Issue descriptionThe correct name should be: Extensions.BookmarkApp.TimeBetweenOpenAppAndLastNavigation But it currently is Extensions.BookmarkApp.OpenAppDeltaSinceLastNavigation[1] [1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/bookmark_app_navigation_throttle.cc?q=bookmark_app_navigation_throttle&sq=package:chromium&dr=C&l=5
,
Jan 23 2018
,
Jan 24 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 24 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next dev release. Thank you.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e1a024ba796a95402214c7eb905bcf7ea70e8dc commit 3e1a024ba796a95402214c7eb905bcf7ea70e8dc Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Wed Jan 24 23:17:22 2018 desktop-pwas: Fix histogram name about time between open app and navigation We were recording the data under the wrong name. This changes the code to record the data under the right name. Bug: 804192 Change-Id: I64023069a6ac5fc6005092f34d82f95c4d7a4399 Reviewed-on: https://chromium-review.googlesource.com/877203 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531180}(cherry picked from commit 1e510cfbf503466aa54943d16b97f84aecf3a828) Reviewed-on: https://chromium-review.googlesource.com/884861 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#76} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/3e1a024ba796a95402214c7eb905bcf7ea70e8dc/chrome/browser/extensions/bookmark_app_navigation_throttle.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jan 23 2018