object-position and perspective-origin should not accept 3 part values like "top right 20%". Same for positions in basic shapes and gradients. For spec links and more detail, see https://github.com/w3c/csswg-drafts/issues/2140
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb5abac2b437721fbac4e09cf5eb10afe8306850 commit fb5abac2b437721fbac4e09cf5eb10afe8306850 Author: Eric Willigers <ericwilligers@chromium.org> Date: Wed Jan 31 00:11:53 2018 CSS: Deprecate support for position values with 3 parts For context see https://github.com/w3c/csswg-drafts/issues/2140 Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/BLsXXiukAgAJ Bug: 804187 Change-Id: I8a430943a5d873a55055654bcef2365d40dd71e3 Reviewed-on: https://chromium-review.googlesource.com/892838 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533102} [add] https://crrev.com/fb5abac2b437721fbac4e09cf5eb10afe8306850/third_party/WebKit/LayoutTests/fast/css/deprecated-three-value-position-expected.txt [add] https://crrev.com/fb5abac2b437721fbac4e09cf5eb10afe8306850/third_party/WebKit/LayoutTests/fast/css/deprecated-three-value-position.html [modify] https://crrev.com/fb5abac2b437721fbac4e09cf5eb10afe8306850/third_party/WebKit/LayoutTests/fast/css/parsing-object-position-expected.txt [modify] https://crrev.com/fb5abac2b437721fbac4e09cf5eb10afe8306850/third_party/WebKit/LayoutTests/fast/css/parsing-object-position.html [modify] https://crrev.com/fb5abac2b437721fbac4e09cf5eb10afe8306850/third_party/WebKit/LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt [modify] https://crrev.com/fb5abac2b437721fbac4e09cf5eb10afe8306850/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp [modify] https://crrev.com/fb5abac2b437721fbac4e09cf5eb10afe8306850/third_party/WebKit/Source/core/frame/Deprecation.cpp
"Expressing a position using 3 parts is deprecated and will be removed in M68." Removal not yet implemented.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/895678e6b233734f4a45a13e9ef9a4049007e514 commit 895678e6b233734f4a45a13e9ef9a4049007e514 Author: Eric Willigers <ericwilligers@chromium.org> Date: Wed Jan 31 12:21:22 2018 CSS: WPT for perspective-origin parsing Test that perspective-origin supports the <position> grammar https://drafts.csswg.org/css-transforms-2/#perspective-origin-property https://drafts.csswg.org/css-values-4/#typedef-position and not the additional forms allowed by the <bg-position> grammar https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position Blink has deprecated <bg-position> support in perspective-origin (and other contexts other than background-position), so the expected failures are while we wait for removal in M68. BUG= 804187 Change-Id: I9e93af5a5af0975fca82aadd4485c601c439969f Reviewed-on: https://chromium-review.googlesource.com/895222 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533258} [add] https://crrev.com/895678e6b233734f4a45a13e9ef9a4049007e514/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-invalid-expected.txt [add] https://crrev.com/895678e6b233734f4a45a13e9ef9a4049007e514/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-invalid.html [add] https://crrev.com/895678e6b233734f4a45a13e9ef9a4049007e514/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-valid.html [modify] https://crrev.com/895678e6b233734f4a45a13e9ef9a4049007e514/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/resources/parsing-testcommon.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e38f6563cacd6cb3e3f0025b17ee0280e9e3088 commit 9e38f6563cacd6cb3e3f0025b17ee0280e9e3088 Author: Eric Willigers <ericwilligers@chromium.org> Date: Thu Feb 01 23:18:18 2018 CSS: WPT for basic-shape <position> parsing Test that basic shapes support the <position> grammar https://drafts.csswg.org/css-shapes/#typedef-basic-shape https://drafts.csswg.org/css-values-4/#typedef-position and not the additional forms allowed by the <bg-position> grammar https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position Blink has deprecated <bg-position> support in basic shapes (and other contexts other than background-position), so the expected failures are while we wait for removal in M68. BUG= 804187 Change-Id: Ifcaa72f42f2b63730ec761bf4fff4d4557f82b75 Reviewed-on: https://chromium-review.googlesource.com/897071 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#533849} [add] https://crrev.com/9e38f6563cacd6cb3e3f0025b17ee0280e9e3088/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/parsing/shape-outside-invalid-position-expected.txt [add] https://crrev.com/9e38f6563cacd6cb3e3f0025b17ee0280e9e3088/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/parsing/shape-outside-invalid-position.html [add] https://crrev.com/9e38f6563cacd6cb3e3f0025b17ee0280e9e3088/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/parsing/shape-outside-valid-position.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/959f90b7745c52fd4b89873660baa10be996659c commit 959f90b7745c52fd4b89873660baa10be996659c Author: Eric Willigers <ericwilligers@chromium.org> Date: Sun Apr 15 10:47:33 2018 CSS: Remove support for position values with 3 parts Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/BLsXXiukAgAJ BUG= 804187 Change-Id: I94e79b2b426250c521d0ebae1492571fde078f31 Reviewed-on: https://chromium-review.googlesource.com/1013459 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#550915} [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/animations/interpolation/object-position-interpolation.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/basic-shape-circle-ellipse-serialization.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/parsing/shape-outside-invalid-position-expected.txt [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/parsing/shape-outside-invalid-position.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/external/wpt/css/css-shapes/shape-outside/values/support/parsing-utils.js [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-invalid-expected.txt [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/parsing/perspective-origin-parsing-invalid.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/stylevalue-normalization/positionvalue-normalization.tentative.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/deprecated-three-value-position-expected.txt [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/deprecated-three-value-position.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/css/object-position-with-fit-none.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/css/object-position.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/css/parsing-object-position-expected.txt [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/css/parsing-object-position.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/css/radial-gradient-calc-percentage-pixels.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-basic-shape-circle.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-basic-shape-ellipse.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-conic-gradient.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-object-position.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-perspective-origin.html [delete] https://crrev.com/ce767403b469e6d5e4a972568891a7f5ff65f873/third_party/WebKit/LayoutTests/fast/css/usecounter-position3value-radial-gradient.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/fast/shapes/parsing/parsing-test-utils.js [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/WebKit/LayoutTests/transforms/perspective-origin-parsing.html [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/blink/public/platform/web_feature.mojom [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.cc [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/blink/renderer/core/css/properties/longhands/object_position_custom.cc [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/blink/renderer/core/css/properties/longhands/perspective_origin_custom.cc [modify] https://crrev.com/959f90b7745c52fd4b89873660baa10be996659c/third_party/blink/renderer/core/frame/deprecation.cc
I think this is all finished up, though I'm not entirely sure.
Comment 1 by ericwilligers@chromium.org
, Jan 23 2018