Issue metadata
Sign in to add a comment
|
DevTools: Can't right-click inspect OOPIF iframe contents
Reported by
rudiedi...@gmail.com,
Jan 20 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 Steps to reproduce the problem: 1. Go to https://rachelandrew.co.uk/archives/2016/01/29/vanishing-boxes-with-display-contents/ 2. Try to inspect the contents of any of the Codepen iframes 3. Devtools opens, and ... What is the expected behavior? Devtools should highlight the inspected node, however deep in iframes that's buried. Like it used to. What went wrong? Devtools highlights the top iframe on the page, and no contents. Inspecting the element again does the same. It never goes into the iframe. Suddenly "Inspect" has become useless. Did this work before? Yes 61 or 62 Chrome version: 63.0.3239.132 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Apparently this is by design!? Or partly? https://twitter.com/ChromeDevTools/status/951560951836303360 Sometimes it does show an iframe's contents directly. I haven't found any logic to it. I know the iframes are stacked below the top page's DOM, and with a lot of work I can scan all iframes to find the right one, but "Inspect" is still useless. Firefox still works perfectly, exactly like Chrome used to. Chrome Canary 66 works perfectly too, now, for this site, but I don't know if that's incidental.
,
Jan 20 2018
Related: issue 755515 , which fixes ONE part of the problem: selection via Ctrl-Shift-C from within devtools, but not inspection via right-clicking the element within an iframe and then choosing "Inspect" from the context menu.
,
Jan 21 2018
I don't think I understand the problem in 755515. It's about extension iframes? You seem to understand this issue, so I won't try to keep up. This issue is not an issue (on all pages tested, although few) in Canary 66, so maybe it is fully fixed in 66..?
,
Jan 22 2018
Tested the issue on reported version 63.0.3239.132 on Windows 10 with steps mentioned below and is not reproducible. Navigated to https://rachelandrew.co.uk/archives/2016/01/29/vanishing-boxes-with-display-contents/ and right clicked on one of element in codepen, selected inspect -- observed highlight of selected code. Attaching screencast for reference. @Reporter: Could you please check the video and let us know if we miss anything. This would help in further triaging of the issue. Thanks!
,
Jan 22 2018
Your Chrome looks very different from mine. I can still reproduce it. Same result every time. With or without inspecting the top page first like you did. Do you see frames below the top page in the Elements tab, or is that different too? I'll find a few more websites with iframes and try there too. Sometimes it does inspect through the iframe.
,
Jan 22 2018
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 22 2018
I don't know if you can see this SWF movie, but it's the best I can do video-wise. And some screenshots to illustrate my amazement: * iframe on top page has no content * iframe's contents are in another section in the Elements tab. Super confusing. * iframe inside that iframe does have contents directly in there, like it used to Wut..? What's going on with Chrome?
,
Jan 22 2018
Another case: https://jsfiddle.net/rudiedirkx/gfcbptvh/ The result pane is an iframe. Inspecting the <canvas> in it highlights the top page's <iframe>, with no content. Another section of the Elements tab contains the iframe contents, but it's never selected through "Inspect". I have to manually find the right "Frame fiddle.jshell.net/" and manually open the elements inside. Possibly interesting: Hovering over the iframe element in the main DOM panel shows the element's size and highlights it. Hovering over the canvas in the iframe does highlight the element, but does not show its size. This is definitely not me. This is definitely Chrome. It used to be perfect.
,
Jan 22 2018
Thanks for the report, can confirm this is still broken on Canary 66.0.3328.0. We're currently working on getting all iframes to be rendered in a single tree in Elements, as it was before. You can follow the status here: https://crbug.com/800613 As comment #2 notes, we still have this issue for right-click inspect.
,
Jan 22 2018
That's so weird, because all my examples do work as expected in Canary 66... My Stable is broken, and Comment 4's isn't. My Canary works, and yours doesn't. Wut?
,
Jan 24 2018
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/902bffab618a622ed802ff3b1cfe5647d2687191 commit 902bffab618a622ed802ff3b1cfe5647d2687191 Author: Dmitry Gozman <dgozman@chromium.org> Date: Sat Jan 27 15:20:46 2018 [DevTools] Make Inspect Element work for OOPIF To support this, we issue inspect element command to the agent beforehand, and dispatch it in the next session which attaches (or the existing one if any). This moves InspectElement from DevToolsSession interface to DevToolsAgent interface, as there might be no session yet. Note this could fail in case of multiple sessions, one of which is DevTools frontend, by choosing the wrong one. This is a rare case though, so we can tolerate that. TBR=alexclarke@chromium.org Bug: 755515 , 804100 Change-Id: I331bfb7f5410868fd47bfe8d558b54b7a30de00c Reviewed-on: https://chromium-review.googlesource.com/881522 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#532220} [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/chrome/browser/devtools/devtools_window.cc [add] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/chrome/test/data/devtools/oopif.html [add] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/chrome/test/data/devtools/oopif_frame.html [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/browser/devtools/devtools_session.h [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/public/browser/devtools_agent_host.h [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/content/shell/browser/shell_devtools_bindings.cc [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/headless/public/util/testing/mock_devtools_agent_host.h [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/third_party/WebKit/Source/devtools/front_end/Tests.js [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js [modify] https://crrev.com/902bffab618a622ed802ff3b1cfe5647d2687191/third_party/WebKit/public/web/devtools_agent.mojom
,
Jan 29 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 Deleted