Issue metadata
Sign in to add a comment
|
"Meet your Google Assistant" window focus issues |
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3322.0 OS: Chrome Device: eve The Assistant opt-in screen steals cursor focus, and can't be closed from the keyboard. This makes accidentally pressing the button (which is right above Backspace) infuriating. 1. Sign in to an account that hasn't set up Google Assistant. 2. Press the Assistant key on the keyboard. The "Meet your Google Assistant" intro window can't be closed with the Esc key or Ctrl+W, Ctrl+Shift+W, Ctrl+Q, etc. You have to tab to the Skip button and press the Enter key. The mouse pointer can't click on anything in the background, but the keyboard continues to work (so you can open a new Chrome window, enter a URL, etc. but can't click anything). Keyboard shortcuts like Ctrl+N or Alt-Tab move keyboard focus back to normal windows, at which point the Assistant window cannot receive keyboard focus without first clicking on the window. This means it's easy to get into a state where the Assistant window can't be closed with the keyboard. Similar dialogs like "Enable your Assistant" and "Get the most out of..." don't have any of these issues.
,
Jan 22 2018
Yeah this is a result of how we implemented this screen in OOBE - we'll be rewriting it soon, so I'll assign to me until the new implementation lands.
,
Jan 22 2018
Issue 804095 has been merged into this issue.
,
Feb 3 2018
The "right above Backspace" in the initial report is a typo, right? The Menu key is located there, but you can close the menu by hitting the key again or hitting Esc, as far as I'm aware. The Assistant key is between Left Ctrl and Left Alt.
,
Feb 3 2018
Not a typo. Maybe my revision has an older keyboard configuration? On my dogfood Pixelbook, the top-right key is the Assistant key. There's no key between Ctrl and Alt. The launcher key is where Caps Lock would be. I don't know what the Menu key even is. The top-right key with the Assistant icon is the only key that launches the Assistant onboarding thing. Pressing it again doesn't close that window; only activating the Skip button in the UI closes the window.
,
Feb 3 2018
Yeah, it moved. Here's the layout that shipped (DVT and later, I think): https://img.purch.com/o/aHR0cHM6Ly93d3cubGFwdG9wbWFnLmNvbS9pbWFnZXMvdXBsb2Fkcy81MjkzL2cvZ29vZ2xlLXBpeGVsYm9vay0wMDJfcHJldmlldy5qcGc= But yeah, I think the issue exists regardless of key location.
,
Feb 3 2018
Hah, the Ctrl+Alt+? overlay shows what I guess is the production keyboard. That overlay doesn't recognize my Assistant key at all. On a production eve, does pressing the Assistant button between the Ctrl and Alt keys close this dialog? This also explains why my notifications button actually reloads the page...
,
Feb 3 2018
Yeah, just verified that the problem you describe still exists on DVT (with the final layout). When you hit the key, you get a few seconds more seconds of typing before the welcome screen appears. I don't think it goes away unless you click "Skip". (As a workaround, you can go through the welcome flow and then turn the the Assistant off via Settings, at which point the key will no longer do anything.)
,
Aug 1
This will be fixed in M70 with croissant, closing this as obsolete. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Jan 22 2018