New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804080 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jan 2018
Cc:
█ aber...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Running js_minify.py leaks .js.map files in /tmp

Project Member Reported by thestig@chromium.org, Jan 20 2018 
What steps will reproduce the problem?
(1) Do an Android build of chrome_public_apk

or

(1) Do an Android build of chrome_public_apk
(2) rm /tmp/*.js.map
(3) touch third_party/closure_compiler/js_minify.py
(4) Do an Android build of chrome_public_apk

What is the expected result?

No extra files in /tmp

What happens instead?

Find a few hundred .js.map files /tmp

Comment 1 by thestig@chromium.org, Jan 23 2018

Owner: dpa...@chromium.org
Status: Started (was: Assigned)
I had a CL to fix this, but it's been superceded by https://chromium-review.googlesource.com/c/chromium/src/+/566023
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5ef96cb52d3c997b6b4c45bb50930042490882d

commit c5ef96cb52d3c997b6b4c45bb50930042490882d
Author: dpapad <dpapad@chromium.org>
Date: Tue Jan 23 00:58:20 2018

Closure compiler: Remove flag that generates sourcemaps.

It seems that the generated source maps are not used by anyone.
Feel free to revert if that's not the case.

Bug:  804080 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I648f706dd7194f208c0beed6bc90766fd1235e9a
Reviewed-on: https://chromium-review.googlesource.com/566023
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531097}
[modify] https://crrev.com/c5ef96cb52d3c997b6b4c45bb50930042490882d/third_party/closure_compiler/closure_args.gni
[modify] https://crrev.com/c5ef96cb52d3c997b6b4c45bb50930042490882d/third_party/closure_compiler/closure_args.gypi
[modify] https://crrev.com/c5ef96cb52d3c997b6b4c45bb50930042490882d/third_party/closure_compiler/compile2.py
[modify] https://crrev.com/c5ef96cb52d3c997b6b4c45bb50930042490882d/third_party/closure_compiler/compiler_test.py

Comment 3 by dpa...@chromium.org, Jan 23 2018 

@thestig: Can you verify if the issue is addressed? (I don't have an android build setup yet, to confirm myself).

Comment 4 by thestig@chromium.org, Jan 23 2018

Status: Fixed (was: Started)
I'm fairly confident if closure compiler is no longer generate source maps, then this is fixed. I'll reopen if that's not the case.
►

Sign in to add a comment