ExistingUserControllerTest browser test crashes test harness when run locally |
|||
Issue descriptionRunning with: browser_tests --gtest_filter=ExistingUser* after a few tests pass, there's a crash and the test harness ignores the test filter (starts running 2k random other tests). Xiyuan, do you know anything about these tests?
,
Jan 22 2018
Interesting. Seems happening only when running test one by one, which probably implies "--single_process" that runs test in test launcher/browser process. We might have some tests cause memory corruption to lead to this.
,
Jan 22 2018
No memory corruption. Yay! Turned out this is because we handle guest login on dev-box by relaunching chrome [1]. There is one test testing guest login and test is re-launched without gtest_filter. [1]: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/chrome_restart_request.cc?rcl=2b2f89789e133c8904e505250e415699def7dea1&l=360-364
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec2c6aebaf6e3a06e4b18b8b310eabd749349977 commit ec2c6aebaf6e3a06e4b18b8b310eabd749349977 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Jan 23 00:19:34 2018 cros: Ignore RestartChrome call for tests Otherwise, test would be re-launched without relevant switches such as gtest_filter etc and things go crazy. Bug: 804064 Change-Id: I26f1081c3438aaab197887a9ce72dc030d9e87d0 Reviewed-on: https://chromium-review.googlesource.com/879175 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531075} [modify] https://crrev.com/ec2c6aebaf6e3a06e4b18b8b310eabd749349977/chrome/browser/chromeos/login/chrome_restart_request.cc
,
Jan 23 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by est...@chromium.org
, Jan 20 2018