New issue
Advanced search Search tips

Issue 804050 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Add ERR_CERTIFICATE_TRANSPARENCY_REQUIRED interstitial to chrome://interstitials

Project Member Reported by est...@chromium.org, Jan 20 2018

Issue description

This will be useful for showing people what will happen when a CT failure causes a certificate error.
 

Comment 2 by est...@chromium.org, Jan 24 2018

Status: Fixed (was: Assigned)

Comment 3 by est...@chromium.org, Jan 24 2018

Labels: Merge-Request-65
Requesting a merge to M65. I've tested and verified it on canary. This is a very small change to a hidden chrome:// page that is not user-facing. We want to have it in M65 for demonstrating to organizations that will be affected by the April Certificate Transparency enforcement date.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Jan 25 2018

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 25 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/022930b128e192a5205885c1bf85227c31588929

commit 022930b128e192a5205885c1bf85227c31588929
Author: Emily Stark <estark@google.com>
Date: Thu Jan 25 22:09:32 2018

Add CT interstitial to chrome://interstitials

Bug:  804050 
Change-Id: I719571d33a3a81114a1c2a78469faa91afd8ac7a
Reviewed-on: https://chromium-review.googlesource.com/877397
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530918}(cherry picked from commit 9f0e6d55f844a16bb5f67d033c6d74e99f54a6a1)
Reviewed-on: https://chromium-review.googlesource.com/887580
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#101}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/022930b128e192a5205885c1bf85227c31588929/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/022930b128e192a5205885c1bf85227c31588929/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
[modify] https://crrev.com/022930b128e192a5205885c1bf85227c31588929/components/security_interstitials/core/browser/resources/list_of_interstitials.html

Sign in to add a comment