Collect metrics for connection migration v2 |
|||
Issue descriptionThere are a few metrics we could collect as connection migration v2 and could be used for performance evaluation as well as investigation purpose. - Failure rate with granular error code when connection migration fails. - Time took to finish a successful probing. - etc.
,
Jan 30 2018
,
Feb 28 2018
,
Feb 28 2018
Reopen this issue as we are analyzing connection migration performance, and need add more histograms to collect metrics.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95f08690524627c3494a7907f11acdf3cf967fc4 commit 95f08690524627c3494a7907f11acdf3cf967fc4 Author: Cherie Shi <zhongyi@chromium.org> Date: Fri Mar 02 20:09:45 2018 Add connection migration to different histograms based on connection migration cause. Bug: 804048 Change-Id: If2a26d95eabba7ff986837b8fa44dea3965dba34 Reviewed-on: https://chromium-review.googlesource.com/941511 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#540599} [modify] https://crrev.com/95f08690524627c3494a7907f11acdf3cf967fc4/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/95f08690524627c3494a7907f11acdf3cf967fc4/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/95f08690524627c3494a7907f11acdf3cf967fc4/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/95f08690524627c3494a7907f11acdf3cf967fc4/tools/metrics/histograms/histograms.xml
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f738657cf5049ba6205b56d9b64b8e34405cd30 commit 7f738657cf5049ba6205b56d9b64b8e34405cd30 Author: Zhongyi Shi <zhongyi@chromium.org> Date: Fri Mar 02 21:53:48 2018 Add two new connection migration status code: - MIGRATION_STATUS_PATH_DEGRADING_NOT_ENABLED - MIGRATION_STATUS_TIMEOUT to help us differentiate the case that connection failed after waiting for new network to connect for 10 seconds. This CL also changes labels associated with QuicConnectionMigrationStatus in histograms to make it more readable. Bug: 804048 Change-Id: Iee870ac45ca0a038f9838a585c120846521375a4 Reviewed-on: https://chromium-review.googlesource.com/942036 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#540644} [modify] https://crrev.com/7f738657cf5049ba6205b56d9b64b8e34405cd30/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/7f738657cf5049ba6205b56d9b64b8e34405cd30/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/7f738657cf5049ba6205b56d9b64b8e34405cd30/tools/metrics/histograms/enums.xml
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/996e31d66f4c87058d8af9a33236b98b9df55b7e commit 996e31d66f4c87058d8af9a33236b98b9df55b7e Author: Zhongyi Shi <zhongyi@chromium.org> Date: Tue May 08 07:06:45 2018 Add a histogram to collect metrics for connection migration. Add a histogram to collect metrics on how often handshake has been confirmed when connection migration is triggered. Bug: 790547 , 804048 Change-Id: I593b80c1557aba30fbea52297497d9f04b51d61e Reviewed-on: https://chromium-review.googlesource.com/1036452 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556712} [modify] https://crrev.com/996e31d66f4c87058d8af9a33236b98b9df55b7e/net/quic/chromium/quic_chromium_client_session.cc [modify] https://crrev.com/996e31d66f4c87058d8af9a33236b98b9df55b7e/net/quic/chromium/quic_chromium_client_session.h [modify] https://crrev.com/996e31d66f4c87058d8af9a33236b98b9df55b7e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/996e31d66f4c87058d8af9a33236b98b9df55b7e/tools/metrics/histograms/histograms.xml
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c66a720d53cf45392d4f0474bf41f514c84988a commit 8c66a720d53cf45392d4f0474bf41f514c84988a Author: Zhongyi Shi <zhongyi@chromium.org> Date: Fri May 25 23:16:13 2018 Fix connection migration cause when alternate network comes up after path is degrading. Fix connection migration cause when alternate network comes up after path is degrading so that data is collected in Net.QuicSession.ConnectionMigration.OnPathDegrading instead of Net.QuicSession.ConnectionMigration.OnNetworkConnected. Bug: 804048 Change-Id: Ic200bb845388ac10d414c3377d1f65d2c4fc8836 Reviewed-on: https://chromium-review.googlesource.com/1068034 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#562053} [modify] https://crrev.com/8c66a720d53cf45392d4f0474bf41f514c84988a/net/quic/chromium/quic_chromium_client_session.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jan 23 2018