New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
Proj-XR

Blocked on:
issue 804042
issue 807340

Blocking:
issue 804039
issue 804045



Sign in to add a comment

Make WebXR equivalents of current WebVR instrumentation test cases

Project Member Reported by bsheedy@chromium.org, Jan 20 2018

Issue description

Once the test framework is capable of running WebXR tests, any existing WebVR tests that have equivalents in WebXR should be copied and made to work with WebXR. There are several WebVR tests that don't make sense for WebXR, but the vast majority do.
 
Blocking: 804045
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf980be6f3fa5437d15bf2631a19e88501f43f2

commit ecf980be6f3fa5437d15bf2631a19e88501f43f2
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jan 23 02:43:54 2018

Make VR test framework compatible with WebXR

Adds several methods to the VR test framework to make it compatible with
WebXR and adds a WebXR boilerplate JavaScript file. Also adds a simple
WebXR transition test as a proof of concept test.

Bug:  804042 ,  804043 
Change-Id: Ibca261109ffa9d8260a1e20807b0aaa3852c7e32
Reviewed-on: https://chromium-review.googlesource.com/879115
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531135}
[modify] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/BUILD.gn
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestFramework.java
[modify] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestFramework.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrTransitionTest.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/XrTestFramework.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
[modify] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrTransitionUtils.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/XrTransitionUtils.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/html/generic_webxr_page.html
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/resources/webxr_e2e.css
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/resources/webxr_e2e.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0152d187c5d19e7196558df947350b40f43c0eb9

commit 0152d187c5d19e7196558df947350b40f43c0eb9
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jan 23 21:50:04 2018

Port WebVrInputTest to WebXR

Ports most of WebVrInputTest to WebXrInputTest. Currently does not port
testControllerClicksRegisteredOnDaydream,
testScreenTapsRegisteredOnCardboard, or testFocusUpdatesSynchronously
since they rely on things in WebVR that don't currently have an
implemented equivalent in WebXR (input and autopresent).

Bug:  804043 
Change-Id: I028de411cd7bf6d9ecc931a276052961d96864d4
Reviewed-on: https://chromium-review.googlesource.com/881834
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531361}
[modify] https://crrev.com/0152d187c5d19e7196558df947350b40f43c0eb9/chrome/android/BUILD.gn
[add] https://crrev.com/0152d187c5d19e7196558df947350b40f43c0eb9/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrInputTest.java
[add] https://crrev.com/0152d187c5d19e7196558df947350b40f43c0eb9/chrome/test/data/vr/e2e_test_files/html/webxr_page_submits_once.html
[add] https://crrev.com/0152d187c5d19e7196558df947350b40f43c0eb9/chrome/test/data/vr/e2e_test_files/html/webxr_test_presentation_locks_focus.html
[add] https://crrev.com/0152d187c5d19e7196558df947350b40f43c0eb9/chrome/test/data/vr/e2e_test_files/html/webxr_test_screen_taps_not_registered.html
[modify] https://crrev.com/0152d187c5d19e7196558df947350b40f43c0eb9/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0e35c828dd5395a3f9b7a28773b6949e7e8de21

commit c0e35c828dd5395a3f9b7a28773b6949e7e8de21
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Jan 29 19:26:49 2018

Port WebVrTransitionTest to WebXR

Ports most of WebVrTransitionTest to have a WebXR equivalent. Does not
port testNfcFiresVrdisplayactivate or testTrustedIntentAllowsAutoPresent
since there is not currently an implemented equivalent of the
functionality they test in WebXR.

Bug:  804043 
Change-Id: I20985416985ca777a541cf42e9a377c2c29a5456
Reviewed-on: https://chromium-review.googlesource.com/885098
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532540}
[modify] https://crrev.com/c0e35c828dd5395a3f9b7a28773b6949e7e8de21/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrTransitionTest.java
[modify] https://crrev.com/c0e35c828dd5395a3f9b7a28773b6949e7e8de21/chrome/test/data/vr/e2e_test_files/html/test_presentation_promise_unresolved_during_don.html
[add] https://crrev.com/c0e35c828dd5395a3f9b7a28773b6949e7e8de21/chrome/test/data/vr/e2e_test_files/html/test_webxr_disabled_without_flag_set.html
[add] https://crrev.com/c0e35c828dd5395a3f9b7a28773b6949e7e8de21/chrome/test/data/vr/e2e_test_files/html/webxr_test_presentation_promise_rejected_if_don_canceled.html
[add] https://crrev.com/c0e35c828dd5395a3f9b7a28773b6949e7e8de21/chrome/test/data/vr/e2e_test_files/html/webxr_test_presentation_promise_unresolved_during_don.html
[add] https://crrev.com/c0e35c828dd5395a3f9b7a28773b6949e7e8de21/chrome/test/data/vr/e2e_test_files/html/webxr_test_window_raf_stops_firing_during_exclusive_session.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/173bbfd75c78636917ac50a86f035df0d7bf6a54

commit 173bbfd75c78636917ac50a86f035df0d7bf6a54
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Feb 02 01:19:18 2018

Deduplicate WebXR tests

Deduplicates most WebVR/WebXR tests into one test implementation that
takes different arguments for WebVR and WebXR.

Bug:  804043 
Change-Id: I1486a4d8e75d91fe98c1298f3b528df4bc01d938
Reviewed-on: https://chromium-review.googlesource.com/896800
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533890}
[modify] https://crrev.com/173bbfd75c78636917ac50a86f035df0d7bf6a54/chrome/android/BUILD.gn
[modify] https://crrev.com/173bbfd75c78636917ac50a86f035df0d7bf6a54/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
[modify] https://crrev.com/173bbfd75c78636917ac50a86f035df0d7bf6a54/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[delete] https://crrev.com/a5252e85ac6d36e0a8fa45193292b53d7058123d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrInputTest.java
[delete] https://crrev.com/a5252e85ac6d36e0a8fa45193292b53d7058123d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrTransitionTest.java
[modify] https://crrev.com/173bbfd75c78636917ac50a86f035df0d7bf6a54/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
[add] https://crrev.com/173bbfd75c78636917ac50a86f035df0d7bf6a54/chrome/test/data/vr/e2e_test_files/html/test_navigation_2d_page2.html
[modify] https://crrev.com/173bbfd75c78636917ac50a86f035df0d7bf6a54/chrome/test/data/vr/e2e_test_files/html/test_presentation_locks_focus.html
[modify] https://crrev.com/173bbfd75c78636917ac50a86f035df0d7bf6a54/chrome/test/data/vr/e2e_test_files/html/test_screen_taps_not_registered.html

Comment 7 by kbr@chromium.org, Feb 3 2018

Cc: geoffl...@chromium.org jmad...@chromium.org
vr_browser_tests' VrBrowserTestStandard.TestPresentationLocksFocus has been failing since https://chromium-review.googlesource.com/896800 landed:

https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28NVIDIA%29/4850

Sorry that the commit queue didn't catch this, because we aren't running tests on Win10 yet there, but I'm reverting the above patch in order to complete the cutover from Win7 to Win10. You'll be able to use the CQ to find and fix this bug afterward.

Comment 8 by kbr@chromium.org, Feb 3 2018

Cc: kbr@chromium.org

Comment 9 by kbr@chromium.org, Feb 3 2018

Blocking: 807340
Blocking this on the final cutover from Win7 to Win10. At that point we can put vr_browser_tests on win_optional_gpu_tests_rel and add that optional tryserver to PRESUBMIT.py in all directories where it would be relevant.

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb57a3a349faa95183039c8d0a6e50e2602c4c37

commit eb57a3a349faa95183039c8d0a6e50e2602c4c37
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Feb 03 03:02:18 2018

Revert "Deduplicate WebXR tests"

This reverts commit 173bbfd75c78636917ac50a86f035df0d7bf6a54.

Reason for revert: one of the new tests is failing on the chromium.gpu.fyi waterfall; see https://bugs.chromium.org/p/chromium/issues/detail?id=804043#c6 .

Original change's description:
> Deduplicate WebXR tests
> 
> Deduplicates most WebVR/WebXR tests into one test implementation that
> takes different arguments for WebVR and WebXR.
> 
> Bug:  804043 
> Change-Id: I1486a4d8e75d91fe98c1298f3b528df4bc01d938
> Reviewed-on: https://chromium-review.googlesource.com/896800
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533890}

TBR=mthiesse@chromium.org,bsheedy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  804043 
Change-Id: I1ec02deb49bcdbb26940f95b80a9df45ba63d585
Reviewed-on: https://chromium-review.googlesource.com/900463
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534248}
[modify] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/android/BUILD.gn
[modify] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
[modify] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[add] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrInputTest.java
[add] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrTransitionTest.java
[modify] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
[delete] https://crrev.com/541ec067d0616e2d1a4745057447219207186275/chrome/test/data/vr/e2e_test_files/html/test_navigation_2d_page2.html
[modify] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/test/data/vr/e2e_test_files/html/test_presentation_locks_focus.html
[modify] https://crrev.com/eb57a3a349faa95183039c8d0a6e50e2602c4c37/chrome/test/data/vr/e2e_test_files/html/test_screen_taps_not_registered.html

Comment 11 by kbr@chromium.org, Feb 8 2018

Blocking: -807340

Comment 12 by kbr@chromium.org, Feb 8 2018

Blockedon: 807340

Comment 13 by kbr@chromium.org, Feb 8 2018

Note: it's now possible to put vr_browser_tests on either win_optional_gpu_tests_rel or win7_chromium_rel_ng, depending on how long it takes to run and how frequently it might get broken. If the tests are reliable and don't take that long, they should just be put on win_chromium_rel_ng per comment on https://chromium-review.googlesource.com/906839 .

Thanks! They currently only take ~25 seconds to run, and while that will go up over time as more tests are added, they should always be pretty fast.

As for stability, I'm not seeing any failures in the last 200 builds other than the time we accidentally broke them, so I think they're stable enough to put on win7_chromium_rel_ng.
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b5c6f26fc4f88e2bc374ffc8c728b607b757455

commit 2b5c6f26fc4f88e2bc374ffc8c728b607b757455
Author: bsheedy <bsheedy@chromium.org>
Date: Sat Feb 10 02:18:52 2018

Revert "Revert "Deduplicate WebXR tests""

This reverts commit eb57a3a349faa95183039c8d0a6e50e2602c4c37.

Reason for revert: "Reland" button isn't working, so revert the revert

Original change's description:
> Revert "Deduplicate WebXR tests"
>
> This reverts commit 173bbfd75c78636917ac50a86f035df0d7bf6a54.
>
> Reason for revert: one of the new tests is failing on the chromium.gpu.fyi waterfall; see https://bugs.chromium.org/p/chromium/issues/detail?id=804043#c6 .
>
> Original change's description:
> > Deduplicate WebXR tests
> >
> > Deduplicates most WebVR/WebXR tests into one test implementation that
> > takes different arguments for WebVR and WebXR.
> >
> > Bug:  804043 
> > Change-Id: I1486a4d8e75d91fe98c1298f3b528df4bc01d938
> > Reviewed-on: https://chromium-review.googlesource.com/896800
> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#533890}
>
> TBR=mthiesse@chromium.org,bsheedy@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug:  804043 
> Change-Id: I1ec02deb49bcdbb26940f95b80a9df45ba63d585
> Reviewed-on: https://chromium-review.googlesource.com/900463
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534248}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  804043 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia0c62c6f826885c56ef6a0425ddd47677e17f8c2
Reviewed-on: https://chromium-review.googlesource.com/906839
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535935}
[modify] https://crrev.com/2b5c6f26fc4f88e2bc374ffc8c728b607b757455/chrome/android/BUILD.gn
[modify] https://crrev.com/2b5c6f26fc4f88e2bc374ffc8c728b607b757455/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
[modify] https://crrev.com/2b5c6f26fc4f88e2bc374ffc8c728b607b757455/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[delete] https://crrev.com/a9b098af6bed01884d88b5863c678b51b3f95f85/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrInputTest.java
[delete] https://crrev.com/a9b098af6bed01884d88b5863c678b51b3f95f85/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrTransitionTest.java
[modify] https://crrev.com/2b5c6f26fc4f88e2bc374ffc8c728b607b757455/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
[modify] https://crrev.com/2b5c6f26fc4f88e2bc374ffc8c728b607b757455/chrome/browser/vr/webvr_input_browser_test.cc
[modify] https://crrev.com/2b5c6f26fc4f88e2bc374ffc8c728b607b757455/chrome/test/data/vr/e2e_test_files/html/test_presentation_locks_focus.html
[modify] https://crrev.com/2b5c6f26fc4f88e2bc374ffc8c728b607b757455/chrome/test/data/vr/e2e_test_files/html/test_screen_taps_not_registered.html

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de284b5f6d3af5a6ec109ecb9d1e98d13587ba0

commit 9de284b5f6d3af5a6ec109ecb9d1e98d13587ba0
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Feb 12 19:19:14 2018

Deduplicate VrShellNavigationTest

Deduplicates VrShellNavigationTest and VrShellNavigationTestWebXr to
have WebVR and WebXR tests share the same implementation, just with
different parameters.

Bug:  804043 
Change-Id: I5cf23289067f2918d6b4be8bb9c2f19e0d29f17a
Reviewed-on: https://chromium-review.googlesource.com/899951
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536154}
[modify] https://crrev.com/9de284b5f6d3af5a6ec109ecb9d1e98d13587ba0/chrome/android/BUILD.gn
[modify] https://crrev.com/9de284b5f6d3af5a6ec109ecb9d1e98d13587ba0/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java
[delete] https://crrev.com/a3533592984bdb788d1335a223b37e125a07c99c/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTestWebXr.java

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 12 2018

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f308efb928ef0911d97e17729ba1dc0047c5e7d5

commit f308efb928ef0911d97e17729ba1dc0047c5e7d5
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Feb 21 01:18:47 2018

Add WebXR non-exclusive session tests

Ports existing WebVR tests that use magic window to WebXR now that
non-exclusive sessions are supported. Also adds two new WebXR-only tests
involving non-exclusive sessions.

Bug:  804043 
Change-Id: I283438d2206e2563636188b5f2a6537d56f2c10e
Reviewed-on: https://chromium-review.googlesource.com/916728
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537975}
[modify] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrDeviceTest.java
[modify] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTabTest.java
[modify] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[add] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/test/data/vr/e2e_test_files/html/test_non_exclusive_stops_during_exclusive.html
[add] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/test/data/vr/e2e_test_files/html/test_webxr_capabilities.html
[add] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/test/data/vr/e2e_test_files/html/test_window_raf_fires_during_non_exclusive_session.html
[add] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/test/data/vr/e2e_test_files/html/webxr_test_pose_data_unfocused_tab.html
[modify] https://crrev.com/f308efb928ef0911d97e17729ba1dc0047c5e7d5/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d654a4f962d2377d01900b8bebe298edfca41390

commit d654a4f962d2377d01900b8bebe298edfca41390
Author: Brian Sheedy <bsheedy@chromium.org>
Date: Wed Feb 21 18:39:23 2018

Revert "Add WebXR non-exclusive session tests"

This reverts commit f308efb928ef0911d97e17729ba1dc0047c5e7d5.

Reason for revert: Broken on main waterfall

Original change's description:
> Add WebXR non-exclusive session tests
> 
> Ports existing WebVR tests that use magic window to WebXR now that
> non-exclusive sessions are supported. Also adds two new WebXR-only tests
> involving non-exclusive sessions.
> 
> Bug:  804043 
> Change-Id: I283438d2206e2563636188b5f2a6537d56f2c10e
> Reviewed-on: https://chromium-review.googlesource.com/916728
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537975}

TBR=mthiesse@chromium.org,bajones@chromium.org,bsheedy@chromium.org

Change-Id: I2ad736d6aa97572b270296e17c3a1b40356227b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  804043 
Reviewed-on: https://chromium-review.googlesource.com/929521
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538157}
[modify] https://crrev.com/d654a4f962d2377d01900b8bebe298edfca41390/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrDeviceTest.java
[modify] https://crrev.com/d654a4f962d2377d01900b8bebe298edfca41390/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTabTest.java
[modify] https://crrev.com/d654a4f962d2377d01900b8bebe298edfca41390/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[delete] https://crrev.com/e38484f0997fe4692b47ffca41af474e6d89ed6a/chrome/test/data/vr/e2e_test_files/html/test_non_exclusive_stops_during_exclusive.html
[delete] https://crrev.com/e38484f0997fe4692b47ffca41af474e6d89ed6a/chrome/test/data/vr/e2e_test_files/html/test_webxr_capabilities.html
[delete] https://crrev.com/e38484f0997fe4692b47ffca41af474e6d89ed6a/chrome/test/data/vr/e2e_test_files/html/test_window_raf_fires_during_non_exclusive_session.html
[delete] https://crrev.com/e38484f0997fe4692b47ffca41af474e6d89ed6a/chrome/test/data/vr/e2e_test_files/html/webxr_test_pose_data_unfocused_tab.html
[modify] https://crrev.com/d654a4f962d2377d01900b8bebe298edfca41390/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js

Labels: -M-66 M-67
Does this need to all land for M66?  Bumping out, but please revert if I'm wrong.
That depends on how much test coverage is required for an origin trial (and if we're still shooting for an M66 WebXR origin trial) - the last bit of this bug is to re-add the magic window tests which were catching a segfault. If we need end-to-end tests for that in order to launch the origin trial, then yes, we need to land these for M66.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e702470c653dd8f01a12ffefce64bcf6fc65b611

commit e702470c653dd8f01a12ffefce64bcf6fc65b611
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Mar 19 22:37:17 2018

Reland "Add WebXR non-exclusive session tests"

This is a reland of f308efb928ef0911d97e17729ba1dc0047c5e7d5.

Original change's description:
> Add WebXR non-exclusive session tests
>
> Ports existing WebVR tests that use magic window to WebXR now that
> non-exclusive sessions are supported. Also adds two new WebXR-only tests
> involving non-exclusive sessions.
>
> Bug:  804043 
> Change-Id: I283438d2206e2563636188b5f2a6537d56f2c10e
> Reviewed-on: https://chromium-review.googlesource.com/916728
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537975}

TBR=mthiesse@chromium.org,bajones@chromium.org

Bug:  804043 
Change-Id: I24dd7e2327f10d11c39d0dee4eb49f2e7bd42e3a
Reviewed-on: https://chromium-review.googlesource.com/929522
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544188}
[modify] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrDeviceTest.java
[modify] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTabTest.java
[modify] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[add] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/test/data/vr/e2e_test_files/html/test_non_exclusive_stops_during_exclusive.html
[add] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/test/data/vr/e2e_test_files/html/test_webxr_capabilities.html
[add] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/test/data/vr/e2e_test_files/html/test_window_raf_fires_during_non_exclusive_session.html
[add] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/test/data/vr/e2e_test_files/html/webxr_test_pose_data_unfocused_tab.html
[modify] https://crrev.com/e702470c653dd8f01a12ffefce64bcf6fc65b611/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcf3b69f518c467b1f692f985cb9c3749d31e592

commit fcf3b69f518c467b1f692f985cb9c3749d31e592
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Mar 20 23:40:32 2018

Port WebVR input tests to WebXR

Ports the two WebVR controller/screen tap input tests to WebXR. Unlike
other WebVR -> WebXR ports, these tests can't use the same test
implementation with different pages since the method of input is
different enough (Gamepad API vs. WebXR-specific) that it doesn't make
much sense to try to re-use the same code.

Bug:  804043 
Change-Id: I9e22632721eda906dffa53c490ac437604269b78
Reviewed-on: https://chromium-review.googlesource.com/969821
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544584}
[modify] https://crrev.com/fcf3b69f518c467b1f692f985cb9c3749d31e592/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
[add] https://crrev.com/fcf3b69f518c467b1f692f985cb9c3749d31e592/chrome/test/data/vr/e2e_test_files/html/test_webxr_input.html

Status: Fixed (was: Assigned)
The only remaining unported instrumentation tests are ones related to autopresent/NFC, which doesn't have an equivalent in the WebXR spec (at least not yet). So, I'd say all the work for this for M67 is done.
Labels: Test-Complete
Project Member

Comment 26 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee

commit d8867a7b3cf832b7f724724b9ab6e8de6d1213ee
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Mar 29 02:57:46 2018

Port WebVR browser tests to WebXR

Ports all of the WebVR browser tests to have an additional WebXR
version, plus adds several WebXR-only tests.

As a result, removes vr_transition_utils and moves the code originally
there into VR/XR test classes so that most WebVR and WebXR tests can
share the same test implementation.

Bug:  804043 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I62c4e1049e6999ff784c9e69ffedff50915e7b8e
Reviewed-on: https://chromium-review.googlesource.com/974137
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546715}
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/test/vr_browser_test.cc
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/test/vr_browser_test.h
[delete] https://crrev.com/fccfac8573b3e64dc91b7404020f7c2f3de7ffec/chrome/browser/vr/test/vr_transition_utils.cc
[delete] https://crrev.com/fccfac8573b3e64dc91b7404020f7c2f3de7ffec/chrome/browser/vr/test/vr_transition_utils.h
[add] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/test/vr_xr_browser_test.cc
[add] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/test/vr_xr_browser_test.h
[add] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/test/xr_browser_test.cc
[add] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/test/xr_browser_test.h
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/webvr_input_browser_test.cc
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/webvr_pixel_browser_test.cc
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/webvr_tab_browser_test.cc
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/browser/vr/webvr_transition_browser_test.cc
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/test/BUILD.gn
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/test/data/vr/e2e_test_files/html/test_webvr_pixels.html
[add] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/test/data/vr/e2e_test_files/html/test_webxr_does_not_return_device.html
[add] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/test/data/vr/e2e_test_files/html/test_webxr_pixels.html
[add] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/test/data/vr/e2e_test_files/html/webxr_test_window_raf_fires_while_presenting.html
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/d8867a7b3cf832b7f724724b9ab6e8de6d1213ee/testing/buildbot/chromium.gpu.json

Components: Internals>XR

Sign in to add a comment