New issue
Advanced search Search tips

Issue 804042 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR

Blocking:
issue 804039
issue 804043



Sign in to add a comment

Make VR instrumentation test framework compatible with WebXR

Project Member Reported by bsheedy@chromium.org, Jan 19 2018

Issue description

Most of the existing VR test framework can be used as-is with WebXR, but some of Java-side methods need to be added and new JavaScript boilerplate code needs to be written in order to make the framework fully compatible with WebXR.
 
Blocking: 804043
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf980be6f3fa5437d15bf2631a19e88501f43f2

commit ecf980be6f3fa5437d15bf2631a19e88501f43f2
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jan 23 02:43:54 2018

Make VR test framework compatible with WebXR

Adds several methods to the VR test framework to make it compatible with
WebXR and adds a WebXR boilerplate JavaScript file. Also adds a simple
WebXR transition test as a proof of concept test.

Bug:  804042 ,  804043 
Change-Id: Ibca261109ffa9d8260a1e20807b0aaa3852c7e32
Reviewed-on: https://chromium-review.googlesource.com/879115
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531135}
[modify] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/BUILD.gn
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestFramework.java
[modify] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrTestFramework.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebXrTransitionTest.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/XrTestFramework.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
[modify] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrTransitionUtils.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/XrTransitionUtils.java
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/html/generic_webxr_page.html
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/resources/webxr_boilerplate.js
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/resources/webxr_e2e.css
[add] https://crrev.com/ecf980be6f3fa5437d15bf2631a19e88501f43f2/chrome/test/data/vr/e2e_test_files/resources/webxr_e2e.js

Comment 3 by sko...@chromium.org, Feb 27 2018

Is this done?
Status: Fixed (was: Assigned)
Yes, although  Issue 804043  isn't since the magic window tests got reverted.
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment