Replace Bind() with newer API calls in PpdProvider and friends. |
||||
Issue descriptionWe have a bunch of lint errors about this. All(?) of these callbacks should be OnceCallbacks, but this will take quite a few fixups to implement. See crbug/714018 for more context
,
Jan 20 2018
No, because I have a change inflight that will wreak havoc with conflicts. But I was planning to knock it out soon; it should be pretty easy. If someone else wants to pick it up, that's fine.
,
Jan 20 2018
luum@ has a change in flight that fixes the PpdProvider unit test. luum@ do you want this?
,
Jan 20 2018
,
Jan 20 2018
Yeah I can take this.
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0517d8199991a949b6e85d8d99eba730a4118106 commit 0517d8199991a949b6e85d8d99eba730a4118106 Author: Luum Habtemariam <luum@chromium.org> Date: Fri Jan 26 17:56:05 2018 Bind API change We've moved from using Bind to BindOnce and BindRepeating. This implements that change in chromeos/printing. BUG= chromium:804035 TEST=passes unit tests Change-Id: Icaf15b00252398c9685a0482e114e7fef7ddea74 Reviewed-on: https://chromium-review.googlesource.com/884825 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#531995} [modify] https://crrev.com/0517d8199991a949b6e85d8d99eba730a4118106/chrome/browser/chromeos/printing/cups_printers_manager_unittest.cc [modify] https://crrev.com/0517d8199991a949b6e85d8d99eba730a4118106/chromeos/printing/ppd_cache.cc [modify] https://crrev.com/0517d8199991a949b6e85d8d99eba730a4118106/chromeos/printing/ppd_cache_unittest.cc [modify] https://crrev.com/0517d8199991a949b6e85d8d99eba730a4118106/chromeos/printing/ppd_provider.cc [modify] https://crrev.com/0517d8199991a949b6e85d8d99eba730a4118106/chromeos/printing/ppd_provider.h [modify] https://crrev.com/0517d8199991a949b6e85d8d99eba730a4118106/chromeos/printing/ppd_provider_unittest.cc
,
Jan 29 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by skau@chromium.org
, Jan 19 2018