New issue
Advanced search Search tips

Issue 804017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CDM API should have size checks on all structs

Project Member Reported by jrumm...@chromium.org, Jan 19 2018

Issue description

The API used to communicate with CDMs (media/cdm/api/content_decryption_module.h) should add compile time size checks to all structs in order to verify that different compilers generate the same size object.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6444def82411338e912ece908b7f01fa9fc44864

commit 6444def82411338e912ece908b7f01fa9fc44864
Author: John Rummell <jrummell@chromium.org>
Date: Wed Jan 31 22:06:04 2018

[media] Initialize structs used in the CDM API

Due to limitations on inline constructors, the constructors have been
removed from all structs used in the CDM API. Update the code to initialize
the struct every time it is created.

BUG= 804017 
TEST=Existing EME browser_tests pass

Change-Id: I64afb7ec445cd9ddff39ad31ef7d703008f716bf
Reviewed-on: https://chromium-review.googlesource.com/894854
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533432}
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/DEPS
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/media/cdm/cdm_adapter.cc
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/media/cdm/cdm_wrapper.h
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/media/cdm/library_cdm/clear_key_cdm/clear_key_cdm.cc
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/media/cdm/library_cdm/clear_key_cdm/ffmpeg_cdm_video_decoder.cc
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/media/cdm/library_cdm/ppapi_cdm_adapter.cc
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/media/cdm/simple_cdm_allocator_unittest.cc
[modify] https://crrev.com/6444def82411338e912ece908b7f01fa9fc44864/media/mojo/services/mojo_cdm_allocator_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment