New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 804014 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cannot print from managed native printer

Project Member Reported by kathrelk...@chromium.org, Jan 19 2018

Issue description

OS: Cyan, 10320.0.0

What steps will reproduce the problem?
(1) Set up a managed account with a native printer: set the Manufacturer, Model, and uri
(2) Attempt to print to the printer

Instead of setting up the printer, see "Error setting up printer" instead.  On a device with 10176.52.0, 64.0.3282.97 the same account works fine.

 
Screenshot 2018-01-19 at 1.30.51 PM.png
96.1 KB View Download

Comment 2 by skau@chromium.org, Jan 19 2018

Owner: luum@chromium.org
Status: Assigned (was: Untriaged)
Cc: jayhlee@chromium.org
Labels: -Type-Bug Type-Bug-Regression
+Jay as fyi
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c228e496dc2d2a1ea9d835c97f22dc570db298f

commit 3c228e496dc2d2a1ea9d835c97f22dc570db298f
Author: Luum Habtemariam <luum@chromium.org>
Date: Mon Jan 22 22:53:18 2018

Metav2 lowercase effective-make-and-model fix

Now correctly sanitizing effective-make-and-models at all ppd_provider
entrypoints.

BUG= chromium:804014 
TEST=checked manually that fixed worked; updated unitests to follow

Change-Id: Ib437dadb3d669f670a0d2142445ac49644c5705d
Reviewed-on: https://chromium-review.googlesource.com/877323
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531037}
[modify] https://crrev.com/3c228e496dc2d2a1ea9d835c97f22dc570db298f/chromeos/printing/ppd_provider.cc

Comment 5 by skau@chromium.org, Jan 24 2018

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by luum@chromium.org, Jan 24 2018

Labels: -Merge-TBD Merge-Request-65
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 25 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e37365d9bd72131abf8089e6434d79383f62bf73

commit e37365d9bd72131abf8089e6434d79383f62bf73
Author: Luum Habtemariam <luum@chromium.org>
Date: Thu Jan 25 22:05:28 2018

Metav2 lowercase effective-make-and-model fix

Now correctly sanitizing effective-make-and-models at all ppd_provider
entrypoints.

BUG= chromium:804014 
TEST=checked manually that fixed worked; updated unitests to follow

Change-Id: Ib437dadb3d669f670a0d2142445ac49644c5705d
Reviewed-on: https://chromium-review.googlesource.com/877323
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531037}(cherry picked from commit 3c228e496dc2d2a1ea9d835c97f22dc570db298f)
Reviewed-on: https://chromium-review.googlesource.com/887169
Cr-Commit-Position: refs/branch-heads/3325@{#100}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/e37365d9bd72131abf8089e6434d79383f62bf73/chromeos/printing/ppd_provider.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f4a22c78494da31933906e31561816a344c6a88

commit 8f4a22c78494da31933906e31561816a344c6a88
Author: Luum Habtemariam <luum@chromium.org>
Date: Sat Apr 14 10:09:41 2018

Metav2 unittests update (case-insensitive)

Updating metav2 unitttests to reflect v2 case insensitive
effective-make-and-model inputs.

BUG= chromium:804014 
TEST=chromeos_unittests all pass

Change-Id: Id5bd86c3ade919588541db757381e41d01149fe9
Reviewed-on: https://chromium-review.googlesource.com/1011239
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550890}
[modify] https://crrev.com/8f4a22c78494da31933906e31561816a344c6a88/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/8f4a22c78494da31933906e31561816a344c6a88/chromeos/printing/ppd_provider_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f4a22c78494da31933906e31561816a344c6a88

commit 8f4a22c78494da31933906e31561816a344c6a88
Author: Luum Habtemariam <luum@chromium.org>
Date: Sat Apr 14 10:09:41 2018

Metav2 unittests update (case-insensitive)

Updating metav2 unitttests to reflect v2 case insensitive
effective-make-and-model inputs.

BUG= chromium:804014 
TEST=chromeos_unittests all pass

Change-Id: Id5bd86c3ade919588541db757381e41d01149fe9
Reviewed-on: https://chromium-review.googlesource.com/1011239
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550890}
[modify] https://crrev.com/8f4a22c78494da31933906e31561816a344c6a88/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/8f4a22c78494da31933906e31561816a344c6a88/chromeos/printing/ppd_provider_unittest.cc

Comment 12 by ndc...@gmail.com, Jan 18 (4 days ago)

What can I do to fix this on my pixelbook?

Sign in to add a comment