New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 804010 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Feb 2018
Cc:
█ trchen@chromium.org
wangxianzhu@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Apply pixel snapping of clips, effects in SPv175 mode

Project Member Reported by chrishtr@chromium.org, Jan 19 2018 
Currently we do not pixel-snap these things in SPv175. We can however do
so by pixel-snapping duringn the pre-paint tree walk, because paint
offsets are known and are equal to the offsets from the composited
layer root (due to the paint offset transform for all such roots).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e267b109b48ad7733582d708c87447bbc807413

commit 4e267b109b48ad7733582d708c87447bbc807413
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Feb 01 23:46:20 2018

[SPv175] Pixel-snap clips in PaintPropertyTreeBuilder.

In SPv175 mode, we know the precise subpixel positions of every object
relative to its composited backing. Therefore we can apply pixel
snapping during pre-paint. This is also necessary because the paint
code can no longer do this pixel-snapping in SPv175 mode, as the
paired display item serialization happens in PaintChunksToCcLayer,
which by design knows nothing about paint offsets or snapping.

To support testing this in SPv1 mode, also add testing of that mode
to PaintPropertyTreeBuilderTest.cpp, and adjust test results accordingly.

Bug:  804010 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9f2dbc13237c9aa6919faa6835f59ec465a06508
Reviewed-on: https://chromium-review.googlesource.com/896602
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533853}
[modify] https://crrev.com/4e267b109b48ad7733582d708c87447bbc807413/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/4e267b109b48ad7733582d708c87447bbc807413/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/4e267b109b48ad7733582d708c87447bbc807413/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
[modify] https://crrev.com/4e267b109b48ad7733582d708c87447bbc807413/third_party/WebKit/Source/platform/testing/PaintTestConfigurations.h

Comment 2 by chrishtr@chromium.org, Feb 2 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment