New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803999 link

Starred by 1 user
Status: Fixed
Owner:
█ jming@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
█ dah...@chromium.org
dtrainor@chromium.org
krav...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[downloads notifications] swiping away a paused notification cancels the download

Project Member Reported by jming@chromium.org, Jan 19 2018 
What steps will reproduce the problem?
(1) Start download.
(2) Pause download.
(3) Swipe download notification away.

What is the expected result?
Unclear.

What happens instead?
- With chrome://flags#enable-downloads-foreground enabled, swiping away cancels the download thus removes the download from downloads home.
- Without the flag enabled, swiping away only removes the notification. The download remains in downloads home and is not canceled.

After chatting with dtrainor@, it might make sense to keep the behavior of being able to swipe to cancel paused downloads (ie. have all of the behavior similar as with the flag enabled). Just wanted to confirm this is ok with dahlke@?

Comment 1 by dah...@chromium.org, Jan 19 2018 

The fact that swiping away the notification killed the download was a huge source of problems/feedback in the early days of our downloads work and was the primary motivator for putting progress in the downloads home (you needed a place to restart the download). I think that behavior is very unexpected from a user standpoint. There is no other app that I know of where removing the notification deletes content. I would strongly prefer that we make sure the download isn't killed when the user removes the notification.

Comment 2 by jming@chromium.org, Jan 20 2018 

Ah okay--will make the change to reflect that.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9893b9ddbb3baf8cd135be6293d857f255676d3d

commit 9893b9ddbb3baf8cd135be6293d857f255676d3d
Author: Joy Ming <jming@chromium.org>
Date: Mon Jan 22 22:46:00 2018

[Downloads notification] Swiping away paused notification doesnt cancel.

Before this change, the behavior between the having the flag
(#enable-downloads-foreground) enabled or not was different. With the
flag enabled, swiping away a paused download notification cancels it and
without the flag enabled, swiping away did not cancel. This change makes
the behavior consistent in that swiping away a paused download does not
cancel the download, rather, allows the user to go through downloads
home to cancel it themselves.

Bug:  803999 
Change-Id: I1bd413575629885f7caeda11c0a5eff59f6c7375
Reviewed-on: https://chromium-review.googlesource.com/877187
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531025}
[modify] https://crrev.com/9893b9ddbb3baf8cd135be6293d857f255676d3d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java

Comment 4 by jming@chromium.org, Jan 22 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment