New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803995 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

TabsTest#testHideKeyboard failing on Android bots

Project Member Reported by pkotw...@chromium.org, Jan 19 2018

Issue description

Sample build failure: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/11599

Detected failure in org.chromium.chrome.browser.TabsTest#testHideKeyboard. raw output:
I  434.270s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: numtests=1
I  434.270s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: stream=
I  434.270s run_tests_on_device(0af6646d)    org.chromium.chrome.browser.TabsTest:
I  434.270s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
I  434.270s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: test=testHideKeyboard
I  434.270s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.TabsTest
I  434.270s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: current=1
I  434.270s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS_CODE: 1
I  434.271s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: test=testHideKeyboard
I  434.271s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.test.ChromeActivityTestRule$ChromeUncaughtExceptionHandler
I  434.271s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS: stack=java.lang.RuntimeException: Error occurred waiting for callable
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.base.ThreadUtils.runOnUiThreadBlockingNoException(ThreadUtils.java:98)
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.content.browser.input.ThreadedInputConnectionProxyView.onCreateInputConnection(ThreadedInputConnectionProxyView.java:93)
I  434.271s run_tests_on_device(0af6646d)    	at android.view.inputmethod.InputMethodManager.startInputInner(InputMethodManager.java:1181)
I  434.271s run_tests_on_device(0af6646d)    	at android.view.inputmethod.InputMethodManager$2.run(InputMethodManager.java:1169)
I  434.271s run_tests_on_device(0af6646d)    	at android.os.Handler.handleCallback(Handler.java:739)
I  434.271s run_tests_on_device(0af6646d)    	at android.os.Handler.dispatchMessage(Handler.java:95)
I  434.271s run_tests_on_device(0af6646d)    	at android.os.Looper.loop(Looper.java:135)
I  434.271s run_tests_on_device(0af6646d)    	at android.os.HandlerThread.run(HandlerThread.java:61)
I  434.271s run_tests_on_device(0af6646d)    Caused by: java.util.concurrent.ExecutionException: java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Map org.chromium.content.browser.webcontents.WebContentsImpl.getUserDataMap()' on a null object reference
I  434.271s run_tests_on_device(0af6646d)    	at java.util.concurrent.FutureTask.report(FutureTask.java:93)
I  434.271s run_tests_on_device(0af6646d)    	at java.util.concurrent.FutureTask.get(FutureTask.java:163)
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.base.ThreadUtils.runOnUiThreadBlocking(ThreadUtils.java:114)
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.base.ThreadUtils.runOnUiThreadBlockingNoException(ThreadUtils.java:96)
I  434.271s run_tests_on_device(0af6646d)    	... 7 more
I  434.271s run_tests_on_device(0af6646d)    Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Map org.chromium.content.browser.webcontents.WebContentsImpl.getUserDataMap()' on a null object reference
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.content.browser.webcontents.WebContentsUserData.fromWebContents(WebContentsUserData.java:71)
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.content.browser.input.ImeAdapterImpl.fromWebContents(ImeAdapterImpl.java:194)
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.content_public.browser.ImeAdapter$$CC.fromWebContents$$STATIC$$(Unknown Source)
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.content.browser.ContentView.onCreateInputConnection(ContentView.java:134)
I  434.271s run_tests_on_device(0af6646d)    	at org.chromium.content.browser.input.ThreadedInputConnectionProxyView$1.call(ThreadedInputConnectionProxyView.java:96)
I  434.272s run_tests_on_device(0af6646d)    	at org.chromium.content.browser.input.ThreadedInputConnectionProxyView$1.call(ThreadedInputConnectionProxyView.java:93)
I  434.272s run_tests_on_device(0af6646d)    	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
I  434.272s run_tests_on_device(0af6646d)    	at android.os.Handler.handleCallback(Handler.java:739)
I  434.272s run_tests_on_device(0af6646d)    	at android.os.Handler.dispatchMessage(Handler.java:95)
I  434.272s run_tests_on_device(0af6646d)    	at android.os.Looper.loop(Looper.java:135)
I  434.272s run_tests_on_device(0af6646d)    	at android.app.ActivityThread.main(ActivityThread.java:5254)
I  434.272s run_tests_on_device(0af6646d)    	at java.lang.reflect.Method.invoke(Native Method)
I  434.272s run_tests_on_device(0af6646d)    	at java.lang.reflect.Method.invoke(Method.java:372)
I  434.272s run_tests_on_device(0af6646d)    	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
I  434.272s run_tests_on_device(0af6646d)    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
I  434.272s run_tests_on_device(0af6646d)    
I  434.272s run_tests_on_device(0af6646d)    INSTRUMENTATION_STATUS_CODE: -1
I  434.272s run_tests_on_device(0af6646d)    INSTRUMENTATION_RESULT: shortMsg=java.lang.NullPointerException
I  434.272s run_tests_on_device(0af6646d)    INSTRUMENTATION_RESULT: longMsg=java.lang.NullPointerException: Attempt to invoke virtual method 'java.util.Map org.chromium.content.browser.webcontents.WebContentsImpl.getUserDataMap()' on a null object reference
I  434.272s run_tests_on_device(0af6646d)    INSTRUMENTATION_CODE: 0

 
Owner: jinsuk...@chromium.org
Status: Assigned (was: Untriaged)
I bisected the failure manually. The test starting failing as a result of https://chromium-review.googlesource.com/867177 landing.

Assigning bug to CL author
Components: -Infra>Sheriffing Tests>Fails
Labels: -Pri-3 sheriff-android Pri-1
Cc: pkotw...@chromium.org
Status: Started (was: Assigned)
Issue 804069 has been merged into this issue.
Project Member

Comment 6 by ClusterFuzz, Jan 22 2018

Labels: M-65 ReleaseBlock-Beta ClusterFuzz-Top-Crash
Testcase 6157330545901568 is a top crash on ClusterFuzz for android platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Can we revert https://chromium-review.googlesource.com/867177 until this is fixed? Note, when testing, it looks as if this passes consistently on phones, but fails on consistently on tablets. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=org.chromium.chrome.browser.TabsTest%23testHideKeyboard&testType=chrome_public_test_apk
Misread the dashboard. This test is only run on tablets, and hence is failing everywhere it runs.
Issue 804240 has been merged into this issue.
Labels: -ReleaseBlock-Beta ReleaseBlock-Dev
Please revert soon.  This is blocking our dev push.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/630072d1912ceb39915e4f526333f752b63d5d5f

commit 630072d1912ceb39915e4f526333f752b63d5d5f
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Jan 22 22:50:29 2018

Fix a crash bug for View#onCreateInputConnection on tab close

One of the consequence of https://crrev.com/c/867177 is that
you can't get ImeAdapter any longer with WebContents from CVC
once |CVC.destroy()| is called. #onCreateInputConnection can
occur afterwards, which needs to be treated as handled with
the default action returning null.

This helps the failing test pass again. The test is for tablet only,
therefore evaded the trybot step.

Bug:  803995 
Change-Id: Ia4de2199737aba7ec49d820fc5237a20f96690e7
Reviewed-on: https://chromium-review.googlesource.com/878079
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531033}
[modify] https://crrev.com/630072d1912ceb39915e4f526333f752b63d5d5f/content/public/android/java/src/org/chromium/content/browser/ContentView.java

Labels: Merge-Request-65
Project Member

Comment 13 by ClusterFuzz, Jan 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6157330545901568 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: cma...@chromium.org
+cmasso for M65 merge review.

Comment 15 by cmasso@google.com, Jan 23 2018

Labels: -Merge-Request-65 Merge-Approved-65
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 23 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/554663e81668bc181d13a2fe2d1153e178eaa195

commit 554663e81668bc181d13a2fe2d1153e178eaa195
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Jan 23 23:05:29 2018

Fix a crash bug for View#onCreateInputConnection on tab close

One of the consequence of https://crrev.com/c/867177 is that
you can't get ImeAdapter any longer with WebContents from CVC
once |CVC.destroy()| is called. #onCreateInputConnection can
occur afterwards, which needs to be treated as handled with
the default action returning null.

This helps the failing test pass again. The test is for tablet only,
therefore evaded the trybot step.

Bug:  803995 
Change-Id: Ia4de2199737aba7ec49d820fc5237a20f96690e7
Reviewed-on: https://chromium-review.googlesource.com/878079
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531033}(cherry picked from commit 630072d1912ceb39915e4f526333f752b63d5d5f)
Reviewed-on: https://chromium-review.googlesource.com/879661
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#46}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/554663e81668bc181d13a2fe2d1153e178eaa195/content/public/android/java/src/org/chromium/content/browser/ContentView.java

Sign in to add a comment