New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803974 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Extend chrome.enterprise.deviceAttributes API

Project Member Reported by pmarko@chromium.org, Jan 19 2018

Issue description

Extend the chrome.enterprise.deviceAttributes API to provide
- Serial Number
and
- administrator-annotated Asset ID 
to policy force-installed extensions on affiliated user sessions.

Proposal doc: https://docs.google.com/document/d/1NDt1enxSbKrbwo-BH4qgCbg2M5EWB6igkpe1le0Egk0/edit
 

Comment 1 by pmarko@chromium.org, Jan 19 2018

Labels: -Type-Bug Type-Feature
Cc: krishna...@chromium.org

Comment 3 by pkakasi@google.com, Feb 2 2018

hi,
any chance we could also include 'location' and 'notes' fields as attributes that can be retrieved by this API the same way?
thanks for consideration.

Comment 4 by dskaram@google.com, Feb 2 2018

I don't believe these are attributes that are available to the client.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cad963db22ef1771afde7f88fa4536f11bb0e677

commit cad963db22ef1771afde7f88fa4536f11bb0e677
Author: Pavol Marko <pmarko@chromium.org>
Date: Thu Feb 15 11:02:49 2018

Extend the enterprise.deviceAttributes API

Extend the enterprise.deviceAttributes API to provide the device
serial number, the administrator-annotated Asset ID and the
administrator-set annotated location.
The new functions are only available to force-installed extensions
running in an affiliated user profile.

API proposal:
https://docs.google.com/a/chromium.org/document/d/1NDt1enxSbKrbwo-BH4qgCbg2M5EWB6igkpe1le0Egk0

Bug:  803974 
Test: browser_tests --gtest_filter=*EnterpriseDeviceAttributes*

Change-Id: I48b3e070a953efe01491e8b9de2700758e158d26
Reviewed-on: https://chromium-review.googlesource.com/876365
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536985}
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_api.cc
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_api.h
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/browser/extensions/extension_apitest.cc
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/browser/extensions/extension_apitest.h
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/common/extensions/api/enterprise_device_attributes.idl
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/test/data/extensions/api_test/enterprise_device_attributes.crx
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/chrome/test/data/extensions/api_test/enterprise_device_attributes/basic.js
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/cad963db22ef1771afde7f88fa4536f11bb0e677/tools/metrics/histograms/enums.xml

Comment 7 by pmarko@chromium.org, Feb 19 2018

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified fixed


Sign in to add a comment