No BT keyboard focus highlight on 'Clear Storage' button in Site settings
Reported by
mcda...@amazon.com,
Jan 19 2018
|
||||
Issue descriptionSteps to reproduce the problem: 1. Attach a bluetooth keyboard 2. Open Chromium 3. Open Settings -> Site Settings -> Storage 4. Move keyboard focus to the 'Clear site storage' button What is the expected behavior? The button changes color to indicate that it has focus. What went wrong? Nothing visible happens to the button. It looks like the bluetooth keyboard focus disappeared. (The button itself does still have focus and is clickable with the 'enter' key) Did this work before? No Chrome version: 65.0.3324.0 Channel: n/a OS Version: 6.0.1 Flash Version: Shockwave Flash 28.0 r0 I have a small patch to fix this issue which I will post shortly (The attached images are WITH fix).
,
Jan 19 2018
This looks great to me! Thanks for authoring a patch. +hannahs@ to verify this looks good from a UX perspective.
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69537bac2ee5615cfe22f4c0a5f5d3e8756f00e2 commit 69537bac2ee5615cfe22f4c0a5f5d3e8756f00e2 Author: David McAllister <mcdavid@amazon.com> Date: Fri Jan 19 22:58:37 2018 Android: Fix focus highlight on Clear Storage button in Site settings The 'Clear Site Storage' button within the site settings menu in preferences is currently solid gray regardless of whether or not it has focus. This patch fixes it to respond when it receives BT keyboard focus. Bug: 803960 Change-Id: Ief3f2ad856fd2cea7e99609a8286a6c0307ee9e5 Reviewed-on: https://chromium-review.googlesource.com/876959 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#530646} [add] https://crrev.com/69537bac2ee5615cfe22f4c0a5f5d3e8756f00e2/chrome/android/java/res/color/flush_footer_button_color.xml [modify] https://crrev.com/69537bac2ee5615cfe22f4c0a5f5d3e8756f00e2/chrome/android/java/res/drawable/flush_footer_button.xml
,
Feb 13 2018
hannahs@, please review the screenshot in the original bug report to confirm the UX looks good.
,
Feb 23 2018
lgtm!
,
Feb 23 2018
Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by mcda...@amazon.com
, Jan 19 2018