Suppress individual host command debug print |
||
Issue descriptionHost command handler prints every single host command except when commands are repeated back-to-back. We should allow each board decide which commands can be ignored. We'll increment a global counter to let developers know there were commands processed but not reported to the console.
,
Jan 29 2018
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/cd5173dfe0e80ad2ca622e64aeb9d14b82ef494f commit cd5173dfe0e80ad2ca622e64aeb9d14b82ef494f Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Sat Feb 03 10:38:07 2018 Fizz: Suppress EC_CMD_PD_GET_LOG_ENTR debug log Host command handler prints every single host command except when commands are repeated back-to-back. Some commands do not provide useful info when studying feedback reports or what is worse they may hide critical info by flooding the EC log. BUG= chromium:803955 BRANCH=none TEST=Observe 'HC 0x115' is not printed. Change-Id: I4901b27bbfedd54dc0d364b16c49d4ed0dea0fc4 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/896694 Reviewed-by: Vincent Palatin <vpalatin@chromium.org> [modify] https://crrev.com/cd5173dfe0e80ad2ca622e64aeb9d14b82ef494f/board/fizz/board.c
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0 commit 971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Sat Feb 17 05:41:41 2018 host_command: Count suppressed host commands individually BUG= chromium:803955 BRANCH=none TEST=Verify counters are printed every hour and before sysjump as follows: [12.540051 HC Suppressed: 0x97=25 0x98=0 0x115=0] Change-Id: I1c1aecf316d233f967f1d2f6ee6c9c16cc59bece Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/912150 [modify] https://crrev.com/971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0/board/fizz/board.h [modify] https://crrev.com/971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0/board/fizz/board.c [modify] https://crrev.com/971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0/include/host_command.h [modify] https://crrev.com/971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0/common/host_command.c [modify] https://crrev.com/971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0/include/config.h |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 23 2018