New issue
Advanced search Search tips

Issue 803943 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 831975
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"external/wpt/html/syntax/parsing/html5lib_tests16.html?run_type=uri" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 19 2018

Issue description

"external/wpt/html/syntax/parsing/html5lib_tests16.html?run_type=uri" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTgsSBUZsYWtlIkNleHRlcm5hbC93cHQvaHRtbC9zeW50YXgvcGFyc2luZy9odG1sNWxpYl90ZXN0czE2Lmh0bWw_cnVuX3R5cGU9dXJpDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: dom-dev@chromium.org
Owner: robertma@chromium.org
robertma@, can you triage this?
Cc: robertma@chromium.org
Labels: -Pri-1 Pri-3
Owner: ----
The test was imported a while ago, but was only recently enabled after I fixed a bug in the runner. Looks like the test is slow (and is already marked so in the markup). Even with the long timeout, it still times out on Windows.

Sent https://crrev.com/c/876922 to add a flaky timeout expectation, which should solve the immediate issue. Downgrade to P3 as most untriaged layout tests.

I'm not familiar with the subject being tested, so hand it back to dom-dev@ to see if there's something interesting they'd like to fix.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5052da93139fb4025d8425c38f88c15f65a29e08

commit 5052da93139fb4025d8425c38f88c15f65a29e08
Author: Robert Ma <robertma@chromium.org>
Date: Sat Jan 20 00:46:03 2018

Mark html5lib_tests16.html?run_type=uri as flaky timeout

This test was recently enabled and seems to be timing out on Windows
sometimes. The test already has long timeout (<meta timeout long>), so
the last resort is to mark it as flaky timeout.

TBR=nednguyen@google.com

Bug:  803943 
Change-Id: I0d3c3e3111d5144dfac62040fee2f4e7df06c769
Reviewed-on: https://chromium-review.googlesource.com/876922
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530697}
[modify] https://crrev.com/5052da93139fb4025d8425c38f88c15f65a29e08/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by tkent@chromium.org, Jan 21 2018

Cc: -dom-dev@chromium.org
Components: Blink>HTML>Parser
Status: Available (was: Untriaged)
Labels: -Sheriff-Chromium
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Jan 25 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "external/wpt/html/syntax/parsing/html5lib_tests16.html?run_type=uri". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTgsSBUZsYWtlIkNleHRlcm5hbC93cHQvaHRtbC9zeW50YXgvcGFyc2luZy9odG1sNWxpYl90ZXN0czE2Lmh0bWw_cnVuX3R5cGU9dXJpDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
The test timed out on Mac and Linux. The log is just 

===
02:58:59.476 1240 [3732/6406] external/wpt/html/syntax/parsing/html5lib_tests16.html?run_type=uri failed unexpectedly (test timed out)
===

Disabling the test on these platforms.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bd4a83ca5a16b2e4661c57312c22ab9c0d264e8

commit 9bd4a83ca5a16b2e4661c57312c22ab9c0d264e8
Author: vitaliii <vitaliii@chromium.org>
Date: Tue Jan 30 15:56:04 2018

Expect e/w/h/s/parsing/html5lib_tests16.html?run_type=uri to timeout.

Expect
external/wpt/html/syntax/parsing/html5lib_tests16.html?run_type=uri to
flakily timeout on Mac and Linux (in addition to Win).

TBR=nednguyen@chromium.org,robertma@chromium.org

Bug:  803943 
Change-Id: I20e5af250cccf8efec2673ee390a2eae892d4aea
Reviewed-on: https://chromium-review.googlesource.com/893399
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532890}
[modify] https://crrev.com/9bd4a83ca5a16b2e4661c57312c22ab9c0d264e8/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Owner: tkent@chromium.org
Status: Assigned (was: Available)
Please redirect. Thank you!

Comment 12 by tkent@chromium.org, Jan 30 2018

Owner: ----
Status: Available (was: Assigned)
Looks like the test is just slow.

Comment 13 by tkent@chromium.org, Apr 13 2018

Mergedinto: 831975
Status: Duplicate (was: Available)
Project Member

Comment 14 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/732cc14175c56476b0b172f6d398518fee7912a0

commit 732cc14175c56476b0b172f6d398518fee7912a0
Author: Robert Ma <robertma@chromium.org>
Date: Fri May 04 15:26:17 2018

Remove some timeout expectations after a bug fix

These tests already declare to be slow (long timeout), but due to a bug
we previously didn't parse the manifest correctly so we missed them.
https://crrev.com/c/1043160 fixed the issue so we can now remove these
expectations.

TBR=tkent

Bug:  803943 , 818324, 803558,  831975 
Change-Id: I8f978d025e026b77dd6f42ade6de8e283886c024
Reviewed-on: https://chromium-review.googlesource.com/1044293
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556062}
[modify] https://crrev.com/732cc14175c56476b0b172f6d398518fee7912a0/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment