Issue 803935 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	tdres...@chromium.org
Closed:	Feb 2018
Cc:	█ ellenpli@chromium.org █ cma...@chromium.org █ vinamrata@chromium.org
Components:	Speed>Metrics
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac
Pri:	2
Type:	Bug
merge-merged-3325

Blocking:
issue 831925

Report First Input Delay

Project Member Reported by tdres...@chromium.org, Jan 19 2018

Issue description

Measure the queueing time of the first event hitting the main thread per page load.

Comment 1 by tdres...@chromium.org, Jan 31 2018

Summary: Report First Input Delay (was: Report First Event Queueing Time)

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f

commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f
Author: Tim Dresser <tdresser@chromium.org>
Date: Fri Feb 02 20:31:11 2018

Report First Input Delay via UMA.

Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay

Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap

Bug:  803935 
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I7fb9ba157d85dd097080db3f64db617aea17f090
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/827b0b6c5a688b37e330a18a1da1229b16752e18

commit 827b0b6c5a688b37e330a18a1da1229b16752e18
Author: Tim Dresser <tdresser@chromium.org>
Date: Fri Feb 02 22:43:21 2018

First Input Delay: include swipes, add UKM.

Previously we excluded swiping input. We now include swipes (map panning,
carousel rotation), but still exclude scroll.

Also records a UKM.

Bug:  803935 
Change-Id: I8f9d5a77ad61221eb9b614e8d4e11e2b757af9e2
Reviewed-on: https://chromium-review.googlesource.com/894826
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534178}
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/827b0b6c5a688b37e330a18a1da1229b16752e18/tools/metrics/ukm/ukm.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe64540e01311889d266c94de15b594e3e0f21cc

commit fe64540e01311889d266c94de15b594e3e0f21cc
Author: Tim Dresser <tdresser@chromium.org>
Date: Tue Feb 13 15:20:21 2018

Report First Input Delay across OOPIFs, report First Input Timestamp.

Previously we only reported for documents in the same process.

Adds InteractiveTiming.FirstInputTimestamp UKM,
PageLoad.InteractiveTiming.FirstInputTimestamp UMA.

Bug:  803935 ,  808089 
Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
Reviewed-on: https://chromium-review.googlesource.com/901802
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536358}
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/fe64540e01311889d266c94de15b594e3e0f21cc/tools/metrics/ukm/ukm.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f

commit 2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f
Author: Timothy Dresser <tdresser@chromium.org>
Date: Tue Feb 13 15:33:48 2018

Revert "Report First Input Delay across OOPIFs, report First Input Timestamp."

This reverts commit fe64540e01311889d266c94de15b594e3e0f21cc.

Reason for revert: Accidentally skipped CQ.

Original change's description:
> Report First Input Delay across OOPIFs, report First Input Timestamp.
> 
> Previously we only reported for documents in the same process.
> 
> Adds InteractiveTiming.FirstInputTimestamp UKM,
> PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
> 
> Bug:  803935 ,  808089 
> Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
> Reviewed-on: https://chromium-review.googlesource.com/901802
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536358}

TBR=isherman@chromium.org,tdresser@chromium.org,tsepez@chromium.org,dtapuska@chromium.org,bmcquade@chromium.org,dproy@chromium.org

Change-Id: I8cd3b5abf8972447092027cf46815d4b1e41fd02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  803935 ,  808089 
Reviewed-on: https://chromium-review.googlesource.com/916064
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536360}
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/2a49ec7eae6dc68d0b95e9ea3416c4a77ae33a8f/tools/metrics/ukm/ukm.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a10963705bce537dbe00ebdd6f07bde46dda8e3c

commit a10963705bce537dbe00ebdd6f07bde46dda8e3c
Author: Tim Dresser <tdresser@chromium.org>
Date: Wed Feb 14 14:35:14 2018

Reland "Report First Input Delay across OOPIFs, report First Input Timestamp."

This is a reland of fe64540e01311889d266c94de15b594e3e0f21cc.

Original change's description:
> Report First Input Delay across OOPIFs, report First Input Timestamp.
>
> Previously we only reported for documents in the same process.
>
> Adds InteractiveTiming.FirstInputTimestamp UKM,
> PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
>
> Bug:  803935 ,  808089 
> Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
> Reviewed-on: https://chromium-review.googlesource.com/901802
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536358}

Accidentally skipped CQ. Then reverted.

TBRing original reviews:

TBR=bmcquade@chromium.org, dtapuska@chromium.org, isherman@chromium.org, tsepez@chromium.org

Bug:  803935 ,  808089 
Change-Id: Ia4e47ea1fd4bc557a193b84e199dd9f3ddf1e6cb
Reviewed-on: https://chromium-review.googlesource.com/916007
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536712}
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/a10963705bce537dbe00ebdd6f07bde46dda8e3c/tools/metrics/ukm/ukm.xml

Comment 7 by tdres...@chromium.org, Feb 14 2018

Cc: vinamrata@chromium.org ellenpli@chromium.org
Labels: Merge-Request-65

Requesting a merge to M65.

This is a fairly large change, but it's metrics specific.
Getting data for this metric soon is important for our overall strategy around page load metrics, including developer messaging.

Comment 8 by gov...@chromium.org, Feb 14 2018

Cc: cma...@chromium.org

We're very close to M65 stable promotion and this a fairly large change.  +cmasso@ (Chrome Mobile TPM, what do you think about this merge? PTAL comment #7 for more details.

Comment 9 by cmasso@google.com, Feb 14 2018

Can this cl affect Chrome in any possible way?

Comment 10 by tdres...@chromium.org, Feb 14 2018

There are no user exposed changes - this is a metrics only change.

Comment 11 by gov...@chromium.org, Feb 14 2018

Labels: -Merge-Request-65 Merge-Approved-65

Approving merge to M65 branch 3325 based on comment #10 and per internal mail thread "First Input Delay Merge" after discussing with cmasso@. Please merge ASAP.

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 15 2018

Labels: -merge-approved-65 merge-merged-3325

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c280601a34fcc3f85372393fe2027b95e054345

commit 9c280601a34fcc3f85372393fe2027b95e054345
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 20:10:00 2018

Report First Input Delay via UMA.

Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay

Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap

Bug:  803935 
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
(cherry picked from commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f)

TBR=dcheng@chromium.org, isherman@chromium.org, kouhei@chromium.org, bmcquade@chromium.org

Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/922684
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#477}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c280601a34fcc3f85372393fe2027b95e054345

commit 9c280601a34fcc3f85372393fe2027b95e054345
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 20:10:00 2018

Report First Input Delay via UMA.

Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay

Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap

Bug:  803935 
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
(cherry picked from commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f)

TBR=dcheng@chromium.org, isherman@chromium.org, kouhei@chromium.org, bmcquade@chromium.org

Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/922684
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#477}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/tools/metrics/histograms/histograms.xml

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c280601a34fcc3f85372393fe2027b95e054345

commit 9c280601a34fcc3f85372393fe2027b95e054345
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 20:10:00 2018

Report First Input Delay via UMA.

Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay

Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap

Bug:  803935 
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
(cherry picked from commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f)

TBR=dcheng@chromium.org, isherman@chromium.org, kouhei@chromium.org, bmcquade@chromium.org

Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/922684
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#477}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/tools/metrics/histograms/histograms.xml

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c280601a34fcc3f85372393fe2027b95e054345

commit 9c280601a34fcc3f85372393fe2027b95e054345
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 20:10:00 2018

Report First Input Delay via UMA.

Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay

Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap

Bug:  803935 
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
(cherry picked from commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f)

TBR=dcheng@chromium.org, isherman@chromium.org, kouhei@chromium.org, bmcquade@chromium.org

Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/922684
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#477}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/tools/metrics/histograms/histograms.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c280601a34fcc3f85372393fe2027b95e054345

commit 9c280601a34fcc3f85372393fe2027b95e054345
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 20:10:00 2018

Report First Input Delay via UMA.

Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay

Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap

Bug:  803935 
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
(cherry picked from commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f)

TBR=dcheng@chromium.org, isherman@chromium.org, kouhei@chromium.org, bmcquade@chromium.org

Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/922684
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#477}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/tools/metrics/histograms/histograms.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c280601a34fcc3f85372393fe2027b95e054345

commit 9c280601a34fcc3f85372393fe2027b95e054345
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 20:10:00 2018

Report First Input Delay via UMA.

Reports the First Input Delay.
PageLoad.InteractiveTiming.FirstInputDelay

Observes:
- MouseDown
- KeyDown, RawKeyDown
- PointerDown (when followed by PointerUp)
- Cancelable TouchStart
- GestureTap

Bug:  803935 
Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime
Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/876728
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534136}
(cherry picked from commit bc5e6d23bc413f387f9c00c9f3dfd449f2051b2f)

TBR=dcheng@chromium.org, isherman@chromium.org, kouhei@chromium.org, bmcquade@chromium.org

Change-Id: I41fddedfe2b0618be0d29d74601df68b04a36210
Reviewed-on: https://chromium-review.googlesource.com/922684
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#477}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/9c280601a34fcc3f85372393fe2027b95e054345/tools/metrics/histograms/histograms.xml

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc9e798d2cbacb94866ec97b10170acc3e474c36

commit bc9e798d2cbacb94866ec97b10170acc3e474c36
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 21:09:02 2018

First Input Delay: include swipes, add UKM.

Previously we excluded swiping input. We now include swipes (map panning,
carousel rotation), but still exclude scroll.

Also records a UKM.

Bug:  803935 
Change-Id: I8f9d5a77ad61221eb9b614e8d4e11e2b757af9e2
Reviewed-on: https://chromium-review.googlesource.com/894826
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534178}
(cherry picked from commit 827b0b6c5a688b37e330a18a1da1229b16752e18)

TBR=dtapuska@chromium.org, bmcquade@chromium.org

Change-Id: I8f9d5a77ad61221eb9b614e8d4e11e2b757af9e2
Reviewed-on: https://chromium-review.googlesource.com/922790
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#478}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/bc9e798d2cbacb94866ec97b10170acc3e474c36/tools/metrics/ukm/ukm.xml

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fb61362b60d8c89aedf247484de1adb8e3a09b4

commit 8fb61362b60d8c89aedf247484de1adb8e3a09b4
Author: Tim Dresser <tdresser@chromium.org>
Date: Thu Feb 15 21:55:13 2018

Report First Input Delay across OOPIFs, report First Input Timestamp.

This is a cherry-pick of a reland.

This is a reland of fe64540e01311889d266c94de15b594e3e0f21cc.

Original change's description:
> Report First Input Delay across OOPIFs, report First Input Timestamp.
>
> Previously we only reported for documents in the same process.
>
> Adds InteractiveTiming.FirstInputTimestamp UKM,
> PageLoad.InteractiveTiming.FirstInputTimestamp UMA.
>
> Bug:  803935 ,  808089 
> Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32
> Reviewed-on: https://chromium-review.googlesource.com/901802
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536358}

Accidentally skipped CQ. Then reverted.

TBRing original reviews:

TBR=bmcquade@chromium.org, dtapuska@chromium.org, isherman@chromium.org, tsepez@chromium.org

(cherry picked from commit a10963705bce537dbe00ebdd6f07bde46dda8e3c)

Bug:  803935 ,  808089 
Change-Id: Ia4e47ea1fd4bc557a193b84e199dd9f3ddf1e6cb
Reviewed-on: https://chromium-review.googlesource.com/916007
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#536712}
Reviewed-on: https://chromium-review.googlesource.com/922905
Cr-Commit-Position: refs/branch-heads/3325@{#481}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/exported/WebPerformance.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/loader/InteractiveDetector.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/loader/InteractiveDetectorTest.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/page/PageWidgetDelegate.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/8fb61362b60d8c89aedf247484de1adb8e3a09b4/tools/metrics/ukm/ukm.xml

Comment 20 by tdres...@chromium.org, Feb 15 2018

Status: Fixed (was: Started)

Merged.

Comment 21 by kbr@chromium.org, Apr 12 2018

Blocking: 831925

►

Issue 803935 link

Issue metadata

Report First Input Delay

Issue description

Comment 1 by tdres...@chromium.org, Jan 31 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Feb 2 2018

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Feb 2 2018

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Feb 13 2018

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Feb 13 2018

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Feb 14 2018

Comment 6 Deleted

Comment 7 by tdres...@chromium.org, Feb 14 2018

Comment 7 Deleted

Comment 8 by gov...@chromium.org, Feb 14 2018

Comment 8 Deleted

Comment 9 by cmasso@google.com, Feb 14 2018

Comment 9 Deleted

Comment 10 by tdres...@chromium.org, Feb 14 2018

Comment 10 Deleted

Comment 11 by gov...@chromium.org, Feb 14 2018

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Feb 15 2018

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Feb 15 2018

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Feb 15 2018

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Feb 15 2018

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Feb 15 2018

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Feb 15 2018

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Feb 15 2018

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Feb 15 2018

Comment 19 Deleted

Comment 20 by tdres...@chromium.org, Feb 15 2018

Comment 20 Deleted

Comment 21 by kbr@chromium.org, Apr 12 2018

Comment 21 Deleted

Sign in to add a comment