New issue
Advanced search Search tips

Issue 803933 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Chrome log spam about org.freedesktop.ModemManager1.Modem.Messaging.List D-Bus errors

Project Member Reported by sky@chromium.org, Jan 19 2018

Issue description

Device imaged from R65-10309.0.0.

The following is continuously written to my log:

[7129:7129:0119/112652.065751:ERROR:object_proxy.cc(626)] Failed to call method: org.freedesktop.ModemManager1.Modem.Messaging.List: object_path= /org/freedesktop/ModemManager1/Modem/71: org.freedesktop.ModemManager1.Error.Core.WrongState: Cannot list SMS messages: device not yet enabled


 

Comment 1 by sky@chromium.org, Jan 19 2018

Cc: derat@chromium.org
I have no idea what area to assign this too. Maybe Dan can suggest something?

Also note, this is a Pixel device.

Comment 2 by derat@chromium.org, Jan 19 2018

Cc: hidehiko@chromium.org hashimoto@chromium.org steve...@chromium.org
Owner: benchan@chromium.org
Status: Assigned (was: Untriaged)
Summary: Chrome log spam about org.freedesktop.ModemManager1.Modem.Messaging.List D-Bus errors (was: object_proxy spams log with)

Comment 3 by sky@chromium.org, Jan 19 2018

Thanks for finding an owner Dan.
Which device are you using?
Is your device equipped with a SIM card slot, and a SIM card which can receive SMS messages?

Comment 5 by derat@chromium.org, Feb 5 2018

Per #1, it's a Pixel. I'd guess it's one of the ones with built-in LTE...
It seems NetworkSmsHandler is doing something wrong, but I guess not many people in UI team are testing the code on a device which comes with builtin LTE.
I guess Steven has some insight about NetworkSmsHandler, also maybe I can reproduce this if I happen to find a device with LTE in our team's cabinet.
Status: Started (was: Assigned)
Here's the issue:

NetworkSmsHandler monitors the Devices property of shill.Manager interface, and upon each update of the property, it iterates through all cellular devices from the device list and creates a new NetworkSmsDeviceHandler for each cellular device. The construction of a ModemManager1NetworkSmsDeviceHandler object will trigger a call to the org.freedesktop.ModemManager1.Modem.Messaging.List method.  That's not good as NetworkSmsHandler should avoid creating a ModemManager1NetworkSmsDeviceHandler for the same SMS D-Bus object exposed by ModemManager.
a minor correction to #7:    "... same SMS D-Bus object ..." should be "... same Modem D-Bus object ..."
When the code was written we did not anticipate more than one Cellular
device. We should fix that incorrect assumption.
Re #9: I think the issue is reproducible with one cellular device as well. The Devices property of the shill.Manager interface can be updated every time a (unrelated) device is added or removed (e.g. unplug and replug an Ethernet adapter) from the device list. The current code would create a new NetworkSmsDeviceHandler for each cellular device encountered during the update, even through the same object may have been created previously. Another issue is that the list of NetworkSmsDeviceHandler never removes old objects.
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
Components: OS>Systems>Mobile

Sign in to add a comment