"org.chromium.android_webview.test.AndroidScrollIntegrationTest#testScrollOffsetAfterCapturePicture" is flaky |
||||||
Issue description"org.chromium.android_webview.test.AndroidScrollIntegrationTest#testScrollOffsetAfterCapturePicture" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybQsSBUZsYWtlImJvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQW5kcm9pZFNjcm9sbEludGVncmF0aW9uVGVzdCN0ZXN0U2Nyb2xsT2Zmc2V0QWZ0ZXJDYXB0dXJlUGljdHVyZQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jan 20 2018
Detected 3 new flakes for test/step "org.chromium.android_webview.test.AndroidScrollIntegrationTest#testScrollOffsetAfterCapturePicture". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybQsSBUZsYWtlImJvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQW5kcm9pZFNjcm9sbEludGVncmF0aW9uVGVzdCN0ZXN0U2Nyb2xsT2Zmc2V0QWZ0ZXJDYXB0dXJlUGljdHVyZQw. This message was posted automatically by the chromium-try-flakes app.
,
Jan 22 2018
,
Jan 22 2018
Detected 4 new flakes for test/step "org.chromium.android_webview.test.AndroidScrollIntegrationTest#testScrollOffsetAfterCapturePicture". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybQsSBUZsYWtlImJvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuQW5kcm9pZFNjcm9sbEludGVncmF0aW9uVGVzdCN0ZXN0U2Nyb2xsT2Zmc2V0QWZ0ZXJDYXB0dXJlUGljdHVyZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jan 22 2018
Ping Yoland, please disable this test if there is no easy fix
,
Jan 22 2018
,
Jan 22 2018
Issue 804369 has been merged into this issue.
,
Jan 22 2018
this "assign to person who last touched this" is going to end up blaming yoland incorrectly a lot of the time for java tests, since he refactored all the tests from junit 3 to 4. not sure how the original CL that broke this passed cq either, kind of surprised this only made test super flaky, instead of just flat out failing all the time.. fix should be this: https://chromium-review.googlesource.com/c/chromium/src/+/879113 thanks to bokan who pointed it out on the code review
,
Jan 22 2018
oops, s/bokan/dtapuska/
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c978cdbb4be8f060130f9a6292dbc8c43206783 commit 0c978cdbb4be8f060130f9a6292dbc8c43206783 Author: Bo Liu <boliu@chromium.org> Date: Mon Jan 22 20:59:09 2018 aw: Fix AutoReset usage This fixes the flaky test (how is it not failing all the time!?) Bug: 803931 Change-Id: Ie4d681be7bfe502a3872828946fd8d16ad6b83b6 TBR: jaebaek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/879113 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#530988} [modify] https://crrev.com/0c978cdbb4be8f060130f9a6292dbc8c43206783/android_webview/browser/browser_view_renderer.cc
,
Jan 22 2018
,
Jan 23 2018
Ah sorry .. :( boliu@, thank you for fixing it! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nedngu...@google.com
, Jan 19 2018Status: Assigned (was: Untriaged)