Issue metadata
Sign in to add a comment
|
[Cronet] Cronet.h ios framework header is causing 'incomplete umbrella header' warning / error. |
||||||||||||||||||||||
Issue descriptionCronet framework on iOS has recently added headers for native API, but those are not referenced in Cronet.h umbrella header. This breaks some client builds if they have -Wincomplete-umbrella enabled and treat warnings as errors. See b/72222455 for more details.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7028a93968131c52e4e4a5cfe90ce3ba2dc59011 commit 7028a93968131c52e4e4a5cfe90ce3ba2dc59011 Author: Misha Efimov <mef@chromium.org> Date: Mon Jan 29 22:34:19 2018 [Cronet] Include native headers into Cronet framework umbrella header. Bug: 803922 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7b3320bea9e37afbab78e0f0d686f0a873b0f5c9 Reviewed-on: https://chromium-review.googlesource.com/876447 Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#532633} [modify] https://crrev.com/7028a93968131c52e4e4a5cfe90ce3ba2dc59011/components/cronet/ios/Cronet.h [modify] https://crrev.com/7028a93968131c52e4e4a5cfe90ce3ba2dc59011/components/cronet/native/BUILD.gn
,
Feb 12 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mef@chromium.org
, Jan 19 2018