New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803911 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 816684
Owner: ----
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Proj-Servicification

Blocked on:
issue 816684



Sign in to add a comment

Fix PageLoadMetricsBrowserTest.* with --enable-features=NetworkService

Project Member Reported by cco3@chromium.org, Jan 19 2018

Issue description

Currently, the following tests fail with --enable-features=NetworkService: 

- PageLoadMetricsBrowserTest.ChromeErrorPage
- PageLoadMetricsBrowserTest.LoadingMetrics
- PageLoadMetricsBrowserTest.LoadingMetricsFailed
- PageLoadMetricsBrowserTest.PayloadSize
- PageLoadMetricsBrowserTest.PayloadSizeChildFrame

Some of these may be represent independent issues.
 

Comment 1 by cco3@chromium.org, Jan 19 2018

Status: Started (was: Untriaged)

Comment 2 by cco3@chromium.org, Jan 19 2018

Description: Show this description

Comment 3 by cco3@chromium.org, Jan 19 2018

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/343a9fc7226cd9efd1a0968d9283729462d4a2c9

commit 343a9fc7226cd9efd1a0968d9283729462d4a2c9
Author: Conley Owens <cco3@chromium.org>
Date: Sat Jan 20 01:24:50 2018

Fail request by shutdown in PageLoadMetrics test

This change fails the request made in
`PageLoadMetricsBrowserTest.ChromeErrorPage` by shutting down the test
server.  This is simpler than setting up the failure callback, and it
works with --enable-features=NetworkService

BUG= 803911 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idf6224d3832e5ad1dd758b1967946b527951fc8f
Reviewed-on: https://chromium-review.googlesource.com/876647
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530715}
[modify] https://crrev.com/343a9fc7226cd9efd1a0968d9283729462d4a2c9/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/343a9fc7226cd9efd1a0968d9283729462d4a2c9/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 5 by dxie@chromium.org, May 17 2018

Labels: -Pri-2 Proj-Servicification-Canary OS-All Pri-1
Owner: jcivelli@chromium.org
Status: Assigned (was: Started)

Comment 6 by dxie@chromium.org, May 18 2018

Labels: -OS-All OS-Windows OS-Linux OS-Mac OS-Chrome OS-Android
Blockedon: 816684
Status: Started (was: Assigned)

Comment 8 by dxie@google.com, Jun 29 2018

Status: Available (was: Started)

Comment 9 by dxie@google.com, Jun 29 2018

Owner: ----
Mergedinto: 816684
Status: Duplicate (was: Available)

Sign in to add a comment