New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803874 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 804811
Owner: ----
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

cc_perftests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 19 2018

Issue description

C  611.856s Main  [  PASSED  ] 56 tests.
C  611.856s Main  [  FAILED  ] 5 tests, listed below:
C  611.856s Main  [  FAILED  ] RasterBufferProviderCommonPerfTest.BuildTileTaskGraph (CRASHED)
C  611.856s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/0 (UNKNOWN)
C  611.857s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/1 (UNKNOWN)
C  611.857s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/2 (UNKNOWN)
C  611.857s Main  [  FAILED  ] RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/3 (UNKNOWN)

I'm going to kick off a bisect to see if we can figure out what change caused these to start failing
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 19 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14ca89b8840000
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d88ff313cff497b7769ecd1a4c8e5e263ed3fd90

commit d88ff313cff497b7769ecd1a4c8e5e263ed3fd90
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Sat Jan 20 02:15:21 2018

Disabling failing cc_perftests

Disabling the following tests until a revert can be made to fix them:
RasterBufferProviderCommonPerfTest.BuildTileTaskGraph
RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/0
RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/1
RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/2
RasterBufferProviderPerfTests/RasterBufferProviderPerfTest.ScheduleAlternateTasks/3

Bug:  803874 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id660d765cf3f69f511cb91c291c273e4a4d3787e
Reviewed-on: https://chromium-review.googlesource.com/876506
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530733}
[modify] https://crrev.com/d88ff313cff497b7769ecd1a4c8e5e263ed3fd90/cc/raster/raster_buffer_provider_perftest.cc

Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 20 2018

Cc: huayinz@chromium.org twelling...@chromium.org mpear...@chromium.org ccameron@chromium.org
Owner: ccameron@chromium.org
Status: Assigned (was: Available)
๐Ÿ“ Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14ca89b8840000

[Downloads] Animate checkmark on OfflineGroupHeaderView
By huayinz@chromium.org ยท Thu Jan 18 20:04:36 2018
chromium @ 863a492713b741ae185dbf14bea36cc270cd4b04

Add histograms for total number of quads
By ccameron@chromium.org ยท Thu Jan 18 22:37:04 2018
chromium @ df9acf92e059174204619b3a9828ec3317ef2d15

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: ----
Status: Available (was: Assigned)
I suspect this is a misattribution. I also don't understand the pinpoint here:

This:
  https://pinpoint-dot-chromeperf.appspot.com/job/14ca89b8840000
doesn't seem to bisect to my change -- it just finds that my change was the one where the build was no longer broken. Am I reading that right?

And what exactly is the failure? Is it a crash -- do we have a stack?

I  567.452s run_tests_on_device(0a38ca3e)  ../../base/test/test_suite.cc:73: Failure
I  567.452s run_tests_on_device(0a38ca3e)  Value of: TestSuite::IsMarkedMaybe(test_info)
I  567.452s run_tests_on_device(0a38ca3e)    Actual: true
I  567.452s run_tests_on_device(0a38ca3e)  Expected: false
I  567.452s run_tests_on_device(0a38ca3e)  Probably the OS #ifdefs don't include all of the necessary platforms.
I  567.452s run_tests_on_device(0a38ca3e)  Please ensure that no tests have the MAYBE_ prefix after the code is preprocessed.

Comment 6 by danakj@chromium.org, Jan 23 2018

Mergedinto: 804811
Status: Duplicate (was: Available)

Sign in to add a comment