New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803867 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

[SPv175] Performance

Project Member Reported by wangxianzhu@chromium.org, Jan 19 2018

Issue description

The first performance result:
https://console.developers.google.com/m/cloudstorage/b/chromium-telemetry/o/html-results/results-2018-01-17_13-45-14#r=TOT&s=%25%ce%94avg

PrePaint: -7.6%
PaintTree: +10.9%

and individual tests have very different progression and regression results in both PrePaint and PaintTree.

Objective: no performance regressions in blink_perf.paint, rasterize_and_record_micro, etc.
 
First raster_and_record_micro_ct result:
https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180119164747/html/index.html

Fieldname	Total	Total with Patch	Percentage Change	Percentage Difference
record_time (ms)	964.125	1194.296	23.874%	21.328%
record_time_partial_invalidation_ms (ms)	844.429	1025.539	21.448%	19.370%
record_time_subsequence_caching_disabled (ms)	4377.054	5236.195	19.628%	17.874%
rasterize_time (ms)	38800.797	44622.719	15.005%	13.958%
record_time_painting_disabled (ms)	7361.178	8437.856	14.626%	13.630%
record_time_caching_disabled (ms)	21539.245	22768.032	5.705%	5.547%
viewport_picture_size (B)	1315134176	1363290976	3.662%	3.596%
record_time_construction_disabled (ms)	5520.815	5708.179	3.394%	3.337%
pixels_rasterized	15762321408	15782277120	0.127%	0.127%
pixels_recorded	55980770230	56009577915	0.051%	0.051%
pixels_rasterized_non_solid	13032996864	13038985216	0.046%	0.046%

Regressions of record times are expected because we move raster invalidation from PrePaint to Paint, but we should lower the regression as much as possible.

viewport_picture_size regression is not expected. This is perhaps due to  bug 795017  (empty or no-op save/(transform|clip|effect)/restore pairs).
The first result seems to contain much noise. I didn't reproduce the big regression of color-changes locally. More try runs of the benchmark showed better results:

https://pinpoint-dot-chromeperf.appspot.com/results2/12cfbdb4840000
paintTree: +0.8%
prePaint: -29%

https://pinpoint-dot-chromeperf.appspot.com/results2/14a4521c840000
paintTree: +1.1%
prePaint: -29%

These results look quite good.

Will try to interpret the ct results.
Blockedon: 809154
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e6afca6430cd3aa67504b4453ec10e15e37dd9

commit b0e6afca6430cd3aa67504b4453ec10e15e37dd9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 15 20:02:13 2018

[SPv175] Simplify non-composited fixed invalidation on scroll

Previously we called CompositedLayerRasterInvalidator::
GenerateForPropertyChanged() for each GraphicsLayer that didn't
need repaint. This caused performance issues during
1) document lifecycle update when nothing changed
2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl
which are supposed to be super fast.

Instead of calling the function for each GraphicsLayer, now call
SetNeedsRepaint for non-composited fixed-position layers on viewport
scroll to ensure performance for the critical case.

This CL will improve SPv175 record_time (fully cached situation)
by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html).

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901
Reviewed-on: https://chromium-review.googlesource.com/920658
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537104}
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.h

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e6afca6430cd3aa67504b4453ec10e15e37dd9

commit b0e6afca6430cd3aa67504b4453ec10e15e37dd9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 15 20:02:13 2018

[SPv175] Simplify non-composited fixed invalidation on scroll

Previously we called CompositedLayerRasterInvalidator::
GenerateForPropertyChanged() for each GraphicsLayer that didn't
need repaint. This caused performance issues during
1) document lifecycle update when nothing changed
2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl
which are supposed to be super fast.

Instead of calling the function for each GraphicsLayer, now call
SetNeedsRepaint for non-composited fixed-position layers on viewport
scroll to ensure performance for the critical case.

This CL will improve SPv175 record_time (fully cached situation)
by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html).

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901
Reviewed-on: https://chromium-review.googlesource.com/920658
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537104}
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.h

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e6afca6430cd3aa67504b4453ec10e15e37dd9

commit b0e6afca6430cd3aa67504b4453ec10e15e37dd9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 15 20:02:13 2018

[SPv175] Simplify non-composited fixed invalidation on scroll

Previously we called CompositedLayerRasterInvalidator::
GenerateForPropertyChanged() for each GraphicsLayer that didn't
need repaint. This caused performance issues during
1) document lifecycle update when nothing changed
2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl
which are supposed to be super fast.

Instead of calling the function for each GraphicsLayer, now call
SetNeedsRepaint for non-composited fixed-position layers on viewport
scroll to ensure performance for the critical case.

This CL will improve SPv175 record_time (fully cached situation)
by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html).

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901
Reviewed-on: https://chromium-review.googlesource.com/920658
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537104}
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.h

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e6afca6430cd3aa67504b4453ec10e15e37dd9

commit b0e6afca6430cd3aa67504b4453ec10e15e37dd9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 15 20:02:13 2018

[SPv175] Simplify non-composited fixed invalidation on scroll

Previously we called CompositedLayerRasterInvalidator::
GenerateForPropertyChanged() for each GraphicsLayer that didn't
need repaint. This caused performance issues during
1) document lifecycle update when nothing changed
2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl
which are supposed to be super fast.

Instead of calling the function for each GraphicsLayer, now call
SetNeedsRepaint for non-composited fixed-position layers on viewport
scroll to ensure performance for the critical case.

This CL will improve SPv175 record_time (fully cached situation)
by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html).

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901
Reviewed-on: https://chromium-review.googlesource.com/920658
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537104}
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.h

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e6afca6430cd3aa67504b4453ec10e15e37dd9

commit b0e6afca6430cd3aa67504b4453ec10e15e37dd9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 15 20:02:13 2018

[SPv175] Simplify non-composited fixed invalidation on scroll

Previously we called CompositedLayerRasterInvalidator::
GenerateForPropertyChanged() for each GraphicsLayer that didn't
need repaint. This caused performance issues during
1) document lifecycle update when nothing changed
2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl
which are supposed to be super fast.

Instead of calling the function for each GraphicsLayer, now call
SetNeedsRepaint for non-composited fixed-position layers on viewport
scroll to ensure performance for the critical case.

This CL will improve SPv175 record_time (fully cached situation)
by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html).

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901
Reviewed-on: https://chromium-review.googlesource.com/920658
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537104}
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.h

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e6afca6430cd3aa67504b4453ec10e15e37dd9

commit b0e6afca6430cd3aa67504b4453ec10e15e37dd9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Feb 15 20:02:13 2018

[SPv175] Simplify non-composited fixed invalidation on scroll

Previously we called CompositedLayerRasterInvalidator::
GenerateForPropertyChanged() for each GraphicsLayer that didn't
need repaint. This caused performance issues during
1) document lifecycle update when nothing changed
2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl
which are supposed to be super fast.

Instead of calling the function for each GraphicsLayer, now call
SetNeedsRepaint for non-composited fixed-position layers on viewport
scroll to ensure performance for the critical case.

This CL will improve SPv175 record_time (fully cached situation)
by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html).

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901
Reviewed-on: https://chromium-review.googlesource.com/920658
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537104}
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/b0e6afca6430cd3aa67504b4453ec10e15e37dd9/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.h

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/297ee9e2ac0fea6624373b0a17b7b78a4b08c033

commit 297ee9e2ac0fea6624373b0a17b7b78a4b08c033
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Feb 16 20:24:12 2018

[SPv175] Clear paint property tree node change flags after painting

The change flags are for the current painting only. Clear them to avoid
unnecessary raster invalidation for paint property change in later
paintings.

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2aebbd1e6342931d34bd2566983c9c22bdeabfc0
Reviewed-on: https://chromium-review.googlesource.com/920581
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537402}
[modify] https://crrev.com/297ee9e2ac0fea6624373b0a17b7b78a4b08c033/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/297ee9e2ac0fea6624373b0a17b7b78a4b08c033/third_party/WebKit/Source/platform/graphics/GraphicsLayer.h
[modify] https://crrev.com/297ee9e2ac0fea6624373b0a17b7b78a4b08c033/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
[modify] https://crrev.com/297ee9e2ac0fea6624373b0a17b7b78a4b08c033/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/297ee9e2ac0fea6624373b0a17b7b78a4b08c033/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/297ee9e2ac0fea6624373b0a17b7b78a4b08c033/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.h
[modify] https://crrev.com/297ee9e2ac0fea6624373b0a17b7b78a4b08c033/third_party/WebKit/Source/platform/testing/FakeGraphicsLayerClient.h

Blockedon: 814239
Blockedon: 814003
Blockedon: 813976
Blockedon: 814042
Blockedon: 814938
Blockedon: 814470
Blockedon: 814711
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb04a49ec7bbc55d95642552c0307350c243f086

commit cb04a49ec7bbc55d95642552c0307350c243f086
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Mar 01 21:29:48 2018

[SPv175] REF::DisableRasterInvalidtion and REF::DisablePaintChunksToCcLayer

They are for performance analysis mainly on cluster telemetry.

Bug:  803867 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic401dafb489641e4a8755e7c1d056687e5f68d3b
Reviewed-on: https://chromium-review.googlesource.com/943926
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540291}
[modify] https://crrev.com/cb04a49ec7bbc55d95642552c0307350c243f086/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/cb04a49ec7bbc55d95642552c0307350c243f086/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/cb04a49ec7bbc55d95642552c0307350c243f086/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/cb04a49ec7bbc55d95642552c0307350c243f086/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Labels: -M-66 M-67
Ran the #c18 CL on ct: go/spv175perf (sheet 3).

Average time:
- Raster invalidation: about 30ms
- PaintChunksToCcLayer: about 90ms

(For comparison:
 AppendToWebDisplayItemList: about 70ms)

So the regression is mainly from PaintChunksToCcLayer which should be our top priority.

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed7798ce5ebee0c38af052d358fc350f473c9f98

commit ed7798ce5ebee0c38af052d358fc350f473c9f98
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat Mar 03 01:25:09 2018

[SPv175] Tweak rasterize_and_record_benchmark metrics

Now we always report the following metrics:

- paint_op_memory_usage: Total memory used by cc::DisplayItemList

- painter_memory_usage: Total memory used by blink::PaintController.

- paint_op_count: total op count of cc::DisplayItemList. This is useful
  to evaluate efficency of PaintChunksToCcLayer.

Removed total_size_of_pictures_in_piles which didn't look useful.
(paint_op_memory_usage + painter_memory_usage) seems the better metric
for total memory usage.

R=vmpstr@chromium.org
TBR=# passive changes and cleanups under tools/perf/measurements

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I64a0fce5ef83d3d9812f0c9446989ffa1b700968
Reviewed-on: https://chromium-review.googlesource.com/944421
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540706}
[modify] https://crrev.com/ed7798ce5ebee0c38af052d358fc350f473c9f98/cc/benchmarks/rasterize_and_record_benchmark.cc
[modify] https://crrev.com/ed7798ce5ebee0c38af052d358fc350f473c9f98/cc/benchmarks/rasterize_and_record_benchmark.h
[modify] https://crrev.com/ed7798ce5ebee0c38af052d358fc350f473c9f98/cc/benchmarks/rasterize_and_record_benchmark_impl.cc
[modify] https://crrev.com/ed7798ce5ebee0c38af052d358fc350f473c9f98/cc/benchmarks/rasterize_and_record_benchmark_impl.h
[modify] https://crrev.com/ed7798ce5ebee0c38af052d358fc350f473c9f98/tools/perf/measurements/rasterize_and_record_micro.py
[modify] https://crrev.com/ed7798ce5ebee0c38af052d358fc350f473c9f98/tools/perf/measurements/rasterize_and_record_micro_unittest.py

Project Member

Comment 21 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce8d72d66f3dfce63347f20b1fae45c91c65a4c

commit 1ce8d72d66f3dfce63347f20b1fae45c91c65a4c
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Mar 06 17:34:10 2018

[SPv175+] Improve performance of LowestCommonAncestor for frequent cases

In PaintChunksToCcLayer we often stay at the same state, or enter or
exit just one level of state. Previously LowestCommonAncestor() always
traversed up to the root for the two parameters.

Now inline the fast path for frequent cases. For the slow path, also
avoid traversal up to the root if one node is an ancestor of the
other.

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I42a71d85ca9ec3c8dba2165aec280e3706c8d79c
Reviewed-on: https://chromium-review.googlesource.com/950138
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541135}
[modify] https://crrev.com/1ce8d72d66f3dfce63347f20b1fae45c91c65a4c/third_party/WebKit/Source/platform/graphics/paint/PaintPropertyNode.cpp
[modify] https://crrev.com/1ce8d72d66f3dfce63347f20b1fae45c91c65a4c/third_party/WebKit/Source/platform/graphics/paint/PaintPropertyNode.h

Project Member

Comment 22 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8899bf9487ca72eef322999322180ef1c1c5b0a5

commit 8899bf9487ca72eef322999322180ef1c1c5b0a5
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Mar 06 20:55:51 2018

[SPv175] Inline FloatRect::EnclosingIntRect()

The function took 15% of total PaintChunksToCcLayer::ConvertInto()
time. There were two function calls: FloatRect::EnclosingIntRect()
which in turn called IntRect::IntRect(const FloatRect&).

Cluster-telemetry showed about 1~2.5% improvement of record times
(https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180306062045/html/index.html).

Bug:  803867 
Change-Id: If69f2c4c207ccc1025035f018c63e14c3b078462
Reviewed-on: https://chromium-review.googlesource.com/950104
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541187}
[modify] https://crrev.com/8899bf9487ca72eef322999322180ef1c1c5b0a5/third_party/WebKit/Source/platform/geometry/FloatRect.cpp
[modify] https://crrev.com/8899bf9487ca72eef322999322180ef1c1c5b0a5/third_party/WebKit/Source/platform/geometry/FloatRect.h

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb5d0d6bdb6e29327bce812d1dcd61782001f539

commit bb5d0d6bdb6e29327bce812d1dcd61782001f539
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Mar 06 22:10:34 2018

[PE] Small optimizations for cc::DisplayItemList

- Guard DCHECK-only code with DCHECK_IS_ON() to reduce several
  instructions in official build.

- Inline GrowCurrentBeginItemVisualRect().

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I259049465bf0505a4098feac29d73405c922861d
Reviewed-on: https://chromium-review.googlesource.com/951897
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541214}
[modify] https://crrev.com/bb5d0d6bdb6e29327bce812d1dcd61782001f539/cc/paint/display_item_list.cc
[modify] https://crrev.com/bb5d0d6bdb6e29327bce812d1dcd61782001f539/cc/paint/display_item_list.h

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cfcee9e2d5e91361d001eae57e430348a33d2a0

commit 3cfcee9e2d5e91361d001eae57e430348a33d2a0
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Mar 06 22:53:56 2018

[SPv175] DisplayItem::VisualRect() as FloatRect instead of LayoutRect

This reduces number of conversions from LayoutRect to FloatRect during
raster invalidation and PaintChunksToCcLayer.

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibc8e0cd0d79fdf08aad2a4711cc53d2fcb22f3ca
Reviewed-on: https://chromium-review.googlesource.com/949964
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541225}
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-late-marker-creation-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-repaint-rect-on-path-with-stroke-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-update-container-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-update-polygon-changes-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-update-polygon-removal-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-update-style-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-update-transform-addition-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/js-update-transform-changes-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/marker-child-changes-css-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/marker-child-changes-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/marker-strokeWidth-changes-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/marker-viewBox-changes-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/paintorder-filtered-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/path-pathlength-change-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/repaint-paintorder-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/repaint-stroke-width-changes-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/stroke-opacity-update-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/use-setAttribute-crash-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/svg/window-expected.txt
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ScrollHitTestDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/ScrollHitTestDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.cpp
[modify] https://crrev.com/3cfcee9e2d5e91361d001eae57e430348a33d2a0/third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf67c50bb2161e6453e253264335d2380d64028f

commit cf67c50bb2161e6453e253264335d2380d64028f
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Mar 09 23:12:59 2018

[SPv175+] Improve visual rect mapping performance

Add ChunkToLayerMapper to reduce repeated costs when mapping many rects
from the same chunk state to the same layer state. It also tries to
reuse computed transforms and clips across chunk states to the same
layer state.

Performance:
- cluster telemetry: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180308192816/html/index.html
 3.5% improvement of record_time
- pinpoint: https://pinpoint-dot-chromeperf.appspot.com/results2/17a3d0fc440000?r=chromium%4054ab408&s=%25%CE%94avg&g=name&c=0
 6% improvement of record_time

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8c20ff7525894767e601270e2cdd291828941f05
Reviewed-on: https://chromium-review.googlesource.com/952291
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542274}
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/ChunkToLayerMapper.cpp
[add] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/ChunkToLayerMapper.h
[add] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/ChunkToLayerMapperTest.cpp
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.h
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidatorTest.cpp
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.h
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp
[modify] https://crrev.com/cf67c50bb2161e6453e253264335d2380d64028f/third_party/WebKit/Source/platform/testing/FakeDisplayItemClient.h

Project Member

Comment 26 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc6abaaa3e12bc70cc3d7becc042d442eee2034

commit 6bc6abaaa3e12bc70cc3d7becc042d442eee2034
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Mar 14 21:26:25 2018

[PE] Add a fast path in GeometryMapper::LocalToAncestorClipRectInternal()

For
  descendant->Parent() == ancestor_clip &&
  descendant->LocalTransformSpace() == ancestor_transform
we can return the clip rect of |descendant| directly to avoid the more
complex logic.

This also reduces the number of entries in the clip cache, which can
speed-up cache lookup.

Premilinary stats show that the fast path is used for about half of all
calls to the function.

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8c390e17cbc7c5e225716e6e90ac8be4dfa615d8
Reviewed-on: https://chromium-review.googlesource.com/963012
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543201}
[modify] https://crrev.com/6bc6abaaa3e12bc70cc3d7becc042d442eee2034/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
[modify] https://crrev.com/6bc6abaaa3e12bc70cc3d7becc042d442eee2034/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp

Blockedon: 813949
Blockedon: 814926
Blockedon: 814932
Blockedon: 819187
Blockedon: 814941
Blockedon: -814941
Blockedon: 822812
Blockedon: 822809
Blockedon: 822865
Blockedon: 822861
Blockedon: 822985
Blockedon: 822866
Blockedon: 814245
Blockedon: 823452
Blockedon: 823464
Blockedon: 823450
Project Member

Comment 43 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e8c6eb13e6eb297747b9e394854408b3f29195

commit b7e8c6eb13e6eb297747b9e394854408b3f29195
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Mar 20 22:21:51 2018

[SPv175] Output bounds for SaveLayerOp

This is mainly for performance. Without bounds, skia may execute some
code to find a finite bounds, and the bounds may be too big for the
SaveLayerOp which may lead other cost.

Cluster telemetry showed that this CL can improve raster_time by 8%.
https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180318183406/html/index.html

Pin-point showed 20% improvement for raster_time in
rasterize_and_record_micro.top_25.
https://pinpoint-dot-chromeperf.appspot.com/results2/14f80e29440000

Another purpose is for some skia bug causing crbug.com/816854. In the
bug, a small chunk with opacity without bounds in SaveLayerOp may
cause ghost rasterization far from the target area.

Bug:  803867 ,816854
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ife282e44b09fb2978e850e4c8cd6ca4e0150c857
Reviewed-on: https://chromium-review.googlesource.com/966699
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544561}
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/cc/paint/display_item_list.h
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/css3/blending/effect-background-blend-mode-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/css3/blending/effect-background-blend-mode-stacking-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/css3/blending/effect-background-blend-mode-tiled-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/css3/blending/mix-blend-mode-isolated-group-1-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/css3/filters/nested-filter-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/fast/backgrounds/svg-as-mask-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-bounce-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transformed-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transformed2-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/reflection-in-composited-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/fast/borders/inline-mask-overlay-image-outset-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/fast/css/transformed-mask-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/reflection/reflection-with-rotation-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/svg/as-background-image/svg-as-background-6-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/virtual/exotic-color-space/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/complex-text-opacity-expected.png
[add] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[add] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac-mac10.12/svg/as-background-image/svg-as-background-6-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-transformed-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-transformed2-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/reflection-in-composited-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/fast/css/transformed-mask-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/reflection/reflection-with-rotation-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/svg/as-background-image/svg-as-background-6-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transformed-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transformed2-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/reflection-in-composited-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/fast/borders/inline-mask-overlay-image-outset-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/fast/css/transformed-mask-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/fast/reflections/opacity-reflection-transform-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/images/color-profile-filter-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/reflection/reflection-with-rotation-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/svg/as-background-image/svg-as-background-6-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-filter-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/virtual/exotic-color-space/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-filter-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/LayoutTests/svg/custom/group-opacity-expected.png
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/b7e8c6eb13e6eb297747b9e394854408b3f29195/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayerTest.cpp

Comment 44 by pdr@chromium.org, Mar 21 2018

Blockedon: 823958
Blockedon: 823462
Cc: pdr@chromium.org
Note that we also have some progressions, see https://bugs.chromium.org/p/chromium/issues/list?can=1&q=label%3ASPv175-Progression&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids. The bugs were reported against the "Revert enable SlimmingPaintV175 by default" CL for "regressions".
Blockedon: 824415
Blockedon: 825257
Blockedon: 825648
Blockedon: 825650
Blockedon: 825811
Project Member

Comment 52 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73

commit 02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Apr 06 03:17:22 2018

[PE] cc::DisplayItemList::TotalOpCount()

I found the reason that SPv175 has 10% less paint_op_count but about
1% more paint_op_memory_usage: we didn't count ops in sub-records.

Add cc::DisplayItemList::TotalOpCount() to count all ops.

Bug:  803867 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0526ace84cc16775d5691e87b502544e64f5932e
Reviewed-on: https://chromium-review.googlesource.com/996316
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548653}
[modify] https://crrev.com/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73/cc/benchmarks/rasterize_and_record_benchmark.cc
[modify] https://crrev.com/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73/cc/layers/recording_source.cc
[modify] https://crrev.com/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73/cc/paint/display_item_list.h
[modify] https://crrev.com/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/02333c5b9fd9dfb0ba6e4ca62692ecaa40372c73/cc/paint/paint_op_buffer_unittest.cc

Project Member

Comment 53 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f10044d9de4a5be671ab9919e193fbaf1890812c

commit f10044d9de4a5be671ab9919e193fbaf1890812c
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Apr 06 16:32:28 2018

[SPv175+] Reuse transform state between chunks with the same property tree state

This saves a pair of RestoreOp and SaveOp between chunks with the same
property tree state.

https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180405050948/html/index.html
showed that this CL can reduce paint_op_count by 3%.

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I979b946e3642773152e19b8648a6e9c3e7268257
Reviewed-on: https://chromium-review.googlesource.com/997175
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548802}
[modify] https://crrev.com/f10044d9de4a5be671ab9919e193fbaf1890812c/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
[modify] https://crrev.com/f10044d9de4a5be671ab9919e193fbaf1890812c/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayerTest.cpp

Blockedon: -823450
Blockedon: 829978
Blockedon: 830123
Project Member

Comment 57 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11b7265cbef484a5184a09fb90dfaf4bbf82f96c

commit 11b7265cbef484a5184a09fb90dfaf4bbf82f96c
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Apr 10 05:51:43 2018

[SPv175+] Reuse transform state across clip/effect states if possible

For:
<div style="transform: translateX(10px)">
  <div>A</div>
  <div style="overflow: hidden">B</div>
  <div>C</div>
</div>
previously we emitted the following paint operations:
  Save
    Transform
    Draw A
  Restore
  Save
    Transform
    ClipRect
    Draw B
  Restore
  Save
    Transform
    Draw C
  Restore

With this CL, we emit the following paint operations:
  Save
    Transform
    Draw A
    Save
      ClipRect
      Draw B
    Restore
    Draw C
  Restore
by reusing transform state across clip state which has the same
transform.

CT result: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180406052047/html/index.html
This CL reduces paint_op_count by 2.6%.

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id0d41b98ffd35440f4a608856650f7109362d425
Reviewed-on: https://chromium-review.googlesource.com/999095
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549429}
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/as-background-image/svg-as-background-5-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-transform-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac-mac10.12/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/as-background-image/svg-as-background-5-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-transform-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/use-detach-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/as-background-image/svg-as-background-5-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-container-in-target-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-modify-target-container-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-containing-use-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-g-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-on-use-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win/svg/custom/use-transform-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/win7/svg/as-background-image/svg-as-background-5-expected.png
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc
[modify] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer_test.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62abeca8161aedf25ee126d4bc63bd3cbeac4085

commit 62abeca8161aedf25ee126d4bc63bd3cbeac4085
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Apr 10 05:51:48 2018

[SPv175+] Don't create OverflowClip if contents don't overflow

This optimize especially for the following simple case:
<div style="overflow: hidden">
  ABC
</div>
which seems quite common in real web pages.

This CL saves OverflowClip node and Save/ClipRect/Restore operations
when the contents don't overflow.

Performance results:
CT: (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180409001618/html/index.html)
 record_time: -2.7%
 paint_op_count: -2%
 painter_memory_usage: -0.7%

rasterize_and_record_micro.top_25 (https://pinpoint-dot-chromeperf.appspot.com/job/113ce7b4c40000):
 record_time: -4.5%
 paint_op_count: -2.4%
 painter_memory_usage: -1.8%

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia12e0182cb2b712013dca3e2cb9805d2d65cd7df
Reviewed-on: https://chromium-review.googlesource.com/1001752
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549430}
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/clip-with-layout-delta-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/resize-with-border-clipped-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/subtree-root-clip-2-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/subtree-root-clip-3-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/subtree-root-clip-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/overflow-delete-line-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/repaint-resized-overflow-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/layoutstate-invalid-invalidation-inline-relative-positioned-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/paint/invalidation/clip/resize-with-border-clipped-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/paint/invalidation/clip/subtree-root-clip-2-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/paint/invalidation/clip/subtree-root-clip-3-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/paint/invalidation/clip/subtree-root-clip-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/linux/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/overflow/overflow-delete-line-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/overflow/repaint-resized-overflow-expected.txt
[add] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/week/week-appearance-basic-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/week/week-appearance-pseudo-elements-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/background/change-text-content-and-background-color-expected.txt
[delete] https://crrev.com/11b7265cbef484a5184a09fb90dfaf4bbf82f96c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/forms/select-option-background-color-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/multi-layout-one-frame-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/bugs/bug46368-1-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/bugs/bug46368-2-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.10/tables/mozilla/dom/tableDom-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/invalidation/background/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/forms/text/text-appearance-basic-expected.png
[copy] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.12/paint/invalidation/position/inline-relative-positioned-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac-mac10.12/paint/invalidation/position/layoutstate-invalid-invalidation-inline-relative-positioned-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/fast/box-sizing/percentage-height-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/fast/forms/search/search-appearance-basic-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/text-appearance-basic-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/fast/forms/week/week-appearance-basic-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/fast/forms/week/week-appearance-pseudo-elements-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/background/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/clip/clip-with-layout-delta-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/forms/select-option-background-color-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/multi-layout-one-frame-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/overflow/repaint-resized-overflow-expected.txt
[rename] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/position/inline-relative-positioned-expected.txt
[copy] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/position/layoutstate-invalid-invalidation-inline-relative-positioned-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/background/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/clip/clip-with-layout-delta-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/forms/select-option-background-color-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/multi-layout-one-frame-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/overflow/repaint-resized-overflow-expected.txt
[rename] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/position/layoutstate-invalid-invalidation-inline-relative-positioned-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/blink/renderer/core/paint/paint_property_tree_update_tests.cc
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/blink/renderer/core/paint/test_data/fixed-position.html
[modify] https://crrev.com/62abeca8161aedf25ee126d4bc63bd3cbeac4085/third_party/blink/renderer/core/paint/test_data/position-and-scroll.html

Blockedon: 828415

Comment 60 by kbr@chromium.org, Apr 12 2018

Blockedon: 832274
Blockedon: -832274
Blockedon: 833083
Blockedon: 833305
Blockedon: 833338
Blockedon: 826230
Blockedon: 834296
Blockedon: -826230
Blockedon: -834296
Blockedon: -833338
Blocking: -771643
Labels: -Pri-1 -M-67 M-68 Pri-2
Moving this to M-68 (meaning that we won't merge performance fixes to M-67) because the remaining regressions are all about only one test case in a test suite. Other tests in the test suite either don't have regressions or have progressions. 
Project Member

Comment 71 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69

commit 976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Apr 27 03:05:06 2018

[SPv175+] Don't create a new chunk with different id and the same properties.

We use ScopedPaintChunkProperties anywhere when there might be a
property change, but don't expect new chunks if the properties are
the same as the current. Previously we created new chunks if the
id changes which added many chunks with the same properties which
unnecessarily increased the load of CompositedLayerRasterInvalidator
and PaintChunksToCcLayer.

https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180425154628/html/index.html
shows great results:
- painter_memory_usage: -16.5%
- record_time_subsequence_caching_disabled: -4%
- record_time: -1.2%

Drawbacks: It combines some previously separated paint
chunks together, so full chunk invalidations are now issued on
the combined chunk, and the bounds may cover more area than
the previously separated chunks. Another drawback is about
appeared or disappeared chunks that now may also occur on bigger
chunks. Consider the big benefits, it's a good trace-off for the
drawbacks (shown in about 10 layout tests).

Bug:  803867 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iba541b24bb4ad92c112acf980d96a6ef4d186880
Reviewed-on: https://chromium-review.googlesource.com/1027209
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554281}
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/box/hover-pseudo-borders-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/bugzilla-6388-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/bugzilla-6473-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/clip-with-layout-delta-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/outline-clip-change-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/clip/resize-with-border-clipped-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/crbug-371640-2-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/crbug-371640-4-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/crbug-371640-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/filters/filter-invalidation-positioned-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/float-new-in-block-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/inline-block-resize-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/make-children-non-inline-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/multicol/multicol-with-abspos-in-relpos-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/border-radius-with-outline-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/focus-continuations-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/focus-enable-continuations-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/focus-ring-on-child-move-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/inline-focus-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-add-repaint-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-change-invalidation-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-change-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-change-vertical-rl-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-child-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-continuations-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-inset-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-repaint-glitch-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/outline/outline-shrinking-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/content-into-overflow-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/overflow-into-content-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/paint-caret-in-div-with-negative-indent-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/absolute-position-change-containing-block-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/block-layout-inline-children-float-positioned-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/static-to-positioned-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/text-in-relative-positioned-inline-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/reflection/reflection-invalidation-positioned-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/remove-block-after-layout-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll/outline-change-scrollable-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll/scroll-in-clipped-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/selection/selection-partial-invalidation-between-blocks-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/svg/transform-focus-ring-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/cached-change-cell-sl-border-color-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/caret-contenteditable-content-after-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/composited-table-background-initial-empty-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/composited-table-row-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/input-overflow-in-table-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/row-change-background-rowspan-cell-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/change-transform-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/transform-repaint-descendants-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/transform-replaced-shadows-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-no-layout-change2-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/box/hover-pseudo-borders-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/canvas-resize-no-full-invalidation-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/clip/resize-with-border-clipped-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/compositing/compositing-reason-removed-expected.txt
[rename] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/compositing/resize-squashing-layer-that-needs-full-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-not-repaint-composited-descendants-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/compositing/squash-partial-repaint-inside-squashed-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/filters/filter-invalidation-after-display-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/filters/filter-invalidation-positioned-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/float-new-in-block-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/inline-block-resize-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/invalidate-descendants-when-receiving-paint-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/invalidate-invisible-element-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/mix-blend-mode-separate-stacking-context-expected.txt
[rename] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/outline/border-radius-with-outline-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/outline/outline-add-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/outline/outline-change-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/outline/outline-change-vertical-rl-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/outline/outline-child-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/overflow/content-into-overflow-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/overflow/fixed-position-transparency-with-overflow-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/overflow/overflow-into-content-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/paint-caret-in-div-with-negative-indent-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/position/absolute-position-change-containing-block-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/position/fixed-to-relative-position-with-absolute-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/position/layout-state-only-positioned-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/reflection/reflection-invalidation-after-display-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/reflection/reflection-invalidation-positioned-child-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/outline-change-scrollable-expected.txt
[rename] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/repaint-composited-child-in-scrolled-container-expected.png
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/repaint-composited-child-in-scrolled-container-expected.txt
[rename] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/scroll-fixed-layer-with-transformed-parent-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/scroll-in-clipped-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/scroll-in-fixed-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/scroll-in-transformed-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/scroll/scroll-with-transformed-parent-layer-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/table/fixed-table-overflow-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/table/input-overflow-in-table-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/table/row-change-background-rowspan-cell-expected.txt
[rename] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/table/scroll-inside-table-cell-expected.png
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/table/scroll-inside-table-cell-expected.txt
[rename] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/table/scroll-relative-table-inside-table-cell-expected.png
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/table/scroll-relative-table-inside-table-cell-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/transform/change-transform-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/paint/invalidation/transform/transform-replaced-shadows-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/bugzilla-6473-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/clip/outline-clip-change-expected.txt
[delete] https://crrev.com/80b167121105133b388f7d5086522468e23afb16/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll-expected.txt
[copy] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/css-grid-layout/grid-item-z-index-change-repaint-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidation-after-opacity-change-subtree-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/make-children-non-inline-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/outline/focus-continuations-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/outline/focus-enable-continuations-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/outline/inline-focus-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/outline/outline-continuations-expected.txt
[add] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/overflow/opacity-change-on-overflow-float-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/position/block-layout-inline-children-float-positioned-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/remove-block-after-layout-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/invalidate-after-composited-scroll-of-window-expected.txt
[modify] https://crrev.com/976fc1e074a07d78fc4ccb3ab2a9fbd20fd9ce69/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev
Blockedon: 838448
Status: Fixed (was: Assigned)
Project Member

Comment 74 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b6c976a6fd40cd61e6c949deba8f2b1eb4c907

commit 59b6c976a6fd40cd61e6c949deba8f2b1eb4c907
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon Jun 11 23:19:34 2018

Revert "[SPv175] REF::DisableRasterInvalidtion and REF::DisablePaintChunksToCcLayer"

This reverts commit cb04a49ec7bbc55d95642552c0307350c243f086.

Reason for revert: No longer needed.

Original change's description:
> [SPv175] REF::DisableRasterInvalidtion and REF::DisablePaintChunksToCcLayer
> 
> They are for performance analysis mainly on cluster telemetry.
> 
> Bug:  803867 
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Ic401dafb489641e4a8755e7c1d056687e5f68d3b
> Reviewed-on: https://chromium-review.googlesource.com/943926
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540291}

TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  803867 
Change-Id: I7dde1b54b0b3162ca706b60b820f6538d9601385
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1094563
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566194}
[modify] https://crrev.com/59b6c976a6fd40cd61e6c949deba8f2b1eb4c907/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.cc
[modify] https://crrev.com/59b6c976a6fd40cd61e6c949deba8f2b1eb4c907/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc
[modify] https://crrev.com/59b6c976a6fd40cd61e6c949deba8f2b1eb4c907/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
[modify] https://crrev.com/59b6c976a6fd40cd61e6c949deba8f2b1eb4c907/third_party/blink/renderer/platform/runtime_enabled_features.json5

Sign in to add a comment