Issue metadata
Sign in to add a comment
|
"Page Unresponsive" dialog shows code inside of "Exit Page" button
Reported by
kdzwinel@gmail.com,
Jan 19 2018
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.0 Safari/537.36
Steps to reproduce the problem:
1. Open page that becomes unresponsive
2. Look at the "Page Unresponsive" dialog
What is the expected behavior?
What went wrong?
Code is shown ("=1 {Exit Page}") inside of "Exit Page" button.
Did this work before? N/A
Chrome version: 65.0.3325.0 Channel: canary
OS Version: OS X 10.13.2
Flash Version:
,
Jan 22 2018
Able to reproduce this issue on reported version 65.0.3325.0 using Mac 10.13.1 with steps given in comment#1 and comment#2. NOTE: Issue is not seen in Linux and Windows Good Build: 65.0.3322.0 Bad Build: 65.0.3323.0 You are probably looking for a change made after 529548 (known good), but no later than 529549 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/0c4f37ac0d5713ca046b7eedc99c68592137078f..b542a405daf4fcee68a1799ff0dc99b056f3f645 Reviewed-on: https://chromium-review.googlesource.com/854689 Suspecting same from changelog. @bsep: Please confirm the issue and help in re-assigning if it is not related to your change. Thanks!
,
Jan 22 2018
NOTE: Issue is also seen in latest canary 66.0.3327.0 on Mac 10.13.1
,
Jan 22 2018
It is caused by my change... but in the Mac version the string is used in HungRendererDialog.xib. I have no idea how to give a plural string to an xib. Help, Mac folks?
,
Jan 22 2018
I think you can just change the killButton_ title in this method: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/hung_renderer_controller.mm?type=cs&sq=package:chromium&l=128
,
Jan 23 2018
Okay, I'll take a shot at it then.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9826a0e88f1d8f423515d5a10e05683d662e9236 commit 9826a0e88f1d8f423515d5a10e05683d662e9236 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jan 24 19:36:49 2018 Fix ICU code showing up on Cocoa hung renderer dialog's "exit" button. Bug: 803855 Change-Id: Ibecaea32f973f907583ab8f01db4ae14a6f08cc6 Reviewed-on: https://chromium-review.googlesource.com/882126 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#531644} [modify] https://crrev.com/9826a0e88f1d8f423515d5a10e05683d662e9236/chrome/app/nibs/HungRendererDialog.xib [modify] https://crrev.com/9826a0e88f1d8f423515d5a10e05683d662e9236/chrome/browser/ui/cocoa/hung_renderer_controller.mm
,
Jan 24 2018
,
Jan 24 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 24 2018
,
Jan 25 2018
Verified the fix on Mac 10.13.1 using Chrome version #66.0.3331.0 as per the comment #0. Attaching screen shot for reference. Observed that "Page Unresponsive" dialog is proper with out any text/button overlap. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef73152974407b1e7ee63149285c926fed1f1e30 commit ef73152974407b1e7ee63149285c926fed1f1e30 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jan 26 00:56:57 2018 Fix ICU code showing up on Cocoa hung renderer dialog's "exit" button. TBR=bsep@chromium.org (cherry picked from commit 9826a0e88f1d8f423515d5a10e05683d662e9236) Bug: 803855 Change-Id: Ibecaea32f973f907583ab8f01db4ae14a6f08cc6 Reviewed-on: https://chromium-review.googlesource.com/882126 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531644} Reviewed-on: https://chromium-review.googlesource.com/887649 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#104} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/ef73152974407b1e7ee63149285c926fed1f1e30/chrome/app/nibs/HungRendererDialog.xib [modify] https://crrev.com/ef73152974407b1e7ee63149285c926fed1f1e30/chrome/browser/ui/cocoa/hung_renderer_controller.mm
,
Jan 30 2018
Verified the fix on Mac 10.13.1 using Chrome version #65.0.3325.31 as per the comment #0. Attaching screen shot for reference. Observed that "Page Unresponsive" dialog is proper with out any text/button overlap. Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsesek@chromium.org
, Jan 19 2018Labels: -Type-Bug -Pri-2 M-65 ReleaseBlock-Beta Needs-Bisect Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)