MinGW Build failure with BASE_WIN_GET_CALLER in base/win/scoped_handle.h
Reported by
t...@ritter.vg,
Jan 19 2018
|
||
Issue description> // TODO(rvargas): remove this with the rest of the verifier. > #if defined(COMPILER_MSVC) > #include <intrin.h> > #define BASE_WIN_GET_CALLER _ReturnAddress() > #elif defined(COMPILER_GCC) > #define BASE_WIN_GET_CALLER __builtin_extract_return_addr(\\ > __builtin_return_address(0)) > #endif > 0:01.74 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/scoped_handle.h:21:59: error: stray ‘\’ in program > 0:01.74 #define BASE_WIN_GET_CALLER __builtin_extract_return_addr(\\
,
Jan 22 2018
,
Jan 24 2018
FYI: I was wrong about this patch, and I ended up updating it https://bugzilla.mozilla.org/show_bug.cgi?id=1432790 At this point I believe I've finished the set of patches needed for make the sandbox compile on MinGW; should I just submit one patch for all of them? They are (most of) the bugs in this list: https://bugzilla.mozilla.org/buglist.cgi?bug_id=1431797%2C1431801%2C1431825%2C1432790%2C1432313%2C1431809%2C1432295%2C1431803%2C1432239%2C1432319%2C1431807%2C1432505%2C1432381%2C1431621&list_id=13981861 |
||
►
Sign in to add a comment |
||
Comment 1 by t...@ritter.vg
, Jan 19 2018