New issue
Advanced search Search tips

Issue 803845 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

MinGW Build failure with BASE_WIN_GET_CALLER in base/win/scoped_handle.h

Reported by t...@ritter.vg, Jan 19 2018

Issue description

> // TODO(rvargas): remove this with the rest of the verifier.
> #if defined(COMPILER_MSVC)
> #include <intrin.h>
> #define BASE_WIN_GET_CALLER _ReturnAddress()
> #elif defined(COMPILER_GCC)
> #define BASE_WIN_GET_CALLER __builtin_extract_return_addr(\\
>     __builtin_return_address(0))
> #endif



> 0:01.74 /home/tom/Documents/moz/mingw-work/sandbox/security/sandbox/chromium/base/win/scoped_handle.h:21:59: error: stray ‘\’ in program
> 0:01.74  #define BASE_WIN_GET_CALLER __builtin_extract_return_addr(\\
 

Comment 1 by t...@ritter.vg, Jan 19 2018

Hey all,  this is the first of what I expect to be many upstream requests for MinGW compilation support in sandbox code. We have a meta-bug with a bunch of old patches here: https://bugzilla.mozilla.org/show_bug.cgi?id=1230910 

I am breaking those out into individual bugs like this one; this issue is https://bugzilla.mozilla.org/show_bug.cgi?id=1431621

I'd like to refine my chromium source contribution workflow to make these easy on all of us =) I have not run any tests (well, aside from compiling it in Firefox over here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69bfee9aea3c5b2a4d7f1ad6f6d7c8baf73d6833 ) - I think I can ask for try job access to do this? IF that's okay, please let me know what set of try jobs I should run for compilation fixes (I know you don't have a MinGW target; but obviously I don't want to regress the supported builds.)

I used git cl and it gave me the following: https://chromium-review.googlesource.com/#/c/chromium/src/+/875913

I didn't flag anyone specific for review, although there's a few options.  I see that robliao has an auto-cc on my review request so hopefully he'll find this. I can't seem to cc anyone or edit the Component of the issue either (it should be Internals>PlatformIntegration)
Components: Internals>Sandbox

Comment 3 by t...@ritter.vg, Jan 24 2018

FYI: I was wrong about this patch, and I ended up updating it https://bugzilla.mozilla.org/show_bug.cgi?id=1432790

At this point I believe I've finished the set of patches needed for make the sandbox compile on MinGW; should I just submit one patch for all of them? They are (most of) the bugs in this list: https://bugzilla.mozilla.org/buglist.cgi?bug_id=1431797%2C1431801%2C1431825%2C1432790%2C1432313%2C1431809%2C1432295%2C1431803%2C1432239%2C1432319%2C1431807%2C1432505%2C1432381%2C1431621&list_id=13981861

Sign in to add a comment