New issue
Advanced search Search tips

Issue 803815 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blue bullet dots appear misaligned in pop-ups blocker bubble.

Reported by rp...@etouch.net, Jan 19 2018

Issue description

Version: 65.0.3325.0 (Official Build) Revisionbc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.3)

What steps will reproduce the problem?
1. Launch chrome,navigate to https://www.naukri.com/
2. Now click on pop-ups blocker icon in omnibox and observe blue bullet dots on it
 
Actual: Blue bullet dots appear misaligned in pop-ups blocker bubble
Expected: Blue bullet dots should be aligned properly pop-ups blocker bubble

This is regression issue, broken in ‘M 65’ and below is the bisect info :
Good build: 65.0.3286.0  (Revision: 521957).
Bad build: 65.0.3287.0 (Revision: 522296).

You are probably looking for a change made after 522118 (known good), but no later than 522119 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/3425c94e632ca511ad9dcf7c1c4e3b49fcfcf0dc..12d3545cdca172bf6e8f1fb7e831a2d12c916f26

Suspect : https://chromium.googlesource.com/chromium/src/+/12d3545cdca172bf6e8f1fb7e831a2d12c916f26

From the CL above, assigning the issue to the concern owner 

@ellyjones- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

 
Actual_screenshot.png
487 KB View Download
Expected_screenshot.png
495 KB View Download
Labels: RegressedIn-65 Target-65 FoundIn-65
Cc: ellyjo...@chromium.org
Owner: bsep@chromium.org
I don't *think* this is caused by my CL but I'm not positive.

Over to bsep@ for Harmony bug triage since this is not Mac- or MacViews-specific.

Comment 3 by bsep@chromium.org, Jan 19 2018

Cc: bsep@chromium.org
Owner: kylixrd@chromium.org
Allen has been working on that dialog.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36467e7b5b0396c40d11c3abb201471ff93ff757

commit 36467e7b5b0396c40d11c3abb201471ff93ff757
Author: Allen Bauer <kylixrd@chromium.org>
Date: Mon Jan 29 14:37:54 2018

Make sure the labels in the popup list are left aligned.

Bug:  803815 
Change-Id: I32dbf0ed1736339f3420d113a1a5a6440c7b8542
Reviewed-on: https://chromium-review.googlesource.com/887243
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532420}
[modify] https://crrev.com/36467e7b5b0396c40d11c3abb201471ff93ff757/chrome/browser/ui/views/content_setting_bubble_contents.cc

Status: Fixed (was: Assigned)

Comment 6 by rp...@etouch.net, Jan 31 2018

Labels: TE-Verified-M66 TE-Verified-66.0.3335.0
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.12.6,10.13.1,10.13.3) OS with latest canary chrome version : 66.0.3335.0 and the issue is fixed.Kindly refer the attached screen cast for reference.
Actual_video.mov
1.5 MB View Download
Labels: ET-MUM-Reported

Sign in to add a comment