New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803809 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Integer-overflow in AllPassFilter

Project Member Reported by ClusterFuzz, Jan 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5166150609797120

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  AllPassFilter
  SplitFilter
  WebRtcVad_CalculateFeatures
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=529631:529648

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5166150609797120

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Cc: brajkumar@chromium.org aleloi@chromium.org
Components: Blink>WebRTC
Labels: -Type-Bug M-65 Test-Predator-Wrong CF-NeedsTriage Type-Bug-Regression
Unable to find actual suspect through code search and also from the provided CL, hence marking it as untriaged.

Note: Observing some recent changes for the below file 'vad_filterbank.c', so cc'ing to @aleloi for more updates on this issue.

https://webrtc.googlesource.com/src.git/+/b9f536167c951558cce8ab18a5012e0822d18855

Thanks!

Comment 2 by guidou@chromium.org, Jan 22 2018

Components: -Blink>WebRTC Blink>WebRTC>Audio

Comment 3 by aleloi@chromium.org, Jan 22 2018

Labels: -Pri-2 Pri-3
P3, because the original authors thought of that and deemed overflows unlikely for real audio (comment https://webrtc.googlesource.com/src/+/5c24c67fd2632cfdcd73562aa0831c44ee535427/common_audio/vad/vad_filterbank.c#85). I'll take a look when I have time.

Owner: aleloi@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by ClusterFuzz, Feb 21 2018

ClusterFuzz has detected this issue as fixed in range 537973:537987.

Detailed report: https://clusterfuzz.com/testcase?key=5166150609797120

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  AllPassFilter
  SplitFilter
  WebRtcVad_CalculateFeatures
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=529631:529648
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=537973:537987

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5166150609797120

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Feb 21 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5166150609797120 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment