EnableCommonNameFallbackForLocalAnchors not sunset in M66 |
|||||||||
Issue descriptionTests just failed as EnableCommonNameFallbackForLocalAnchors is marked as supported in Chrome 58-65 but trunk is 66 now and the policy is still there. We need to decide before 66 goes stable whether to yank this policy or give people more time. ================================= Original description: Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mastiz@google.com PolicyPrefsTest.PolicyToPrefsMapping in browser_tests failing on chromium.memory/Linux ASan Tests (sandboxed) Builders failed on: - Linux ASan Tests (sandboxed): https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29
,
Jan 19 2018
This seems to be caused by trunk VERSION update to 66 in 60268be712805e40c119728900499689c69936a4. I assume policy_test_cases.json needs to be updated.
,
Jan 19 2018
This enterprise policy was originally specified as supported in the version range [58..65], https://cs.chromium.org/chromium/src/components/policy/resources/policy_templates.json?l=5268&rcl=6f393137d791f73e241085afd0696562c44ab3c5 I wonder if this was intentional or not.
,
Jan 19 2018
Quoted from the CL that introduced this policy, by rsleevi@chromium.org: "Drew: As discussed over e-mail, this introduces the enterprise policy with a 1 year sunset and explicit versions set." (https://codereview.chromium.org/2719273002/#ps200001) Since I'm not comfortable disabling the test now, I'll extend the version range and reassign.
,
Jan 19 2018
,
Jan 19 2018
,
Jan 19 2018
Patch is waiting for review, https://chromium-review.googlesource.com/c/chromium/src/+/874475
,
Jan 19 2018
Issue 803790 has been merged into this issue.
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b579c591249bd706e6e07ff78327806bacd0368 commit 7b579c591249bd706e6e07ff78327806bacd0368 Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Jan 19 10:41:46 2018 Extend version range for policy EnableCommonNameFallbackForLocalAnchors This is a temporary solution to make tests pass. Owners should follow up with deciding whether the policy should be dropped altogether. Bug: 803791 Change-Id: Ice8769724344eb33cc7e960a555953868f398b79 Reviewed-on: https://chromium-review.googlesource.com/874475 Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#530478} [modify] https://crrev.com/7b579c591249bd706e6e07ff78327806bacd0368/components/policy/resources/policy_templates.json
,
Jan 19 2018
,
Jan 19 2018
Issue 803756 has been merged into this issue.
,
Jan 19 2018
Oh, I thought sunsetting it in policy file as we did was sufficient. This should be removed.
,
Jan 22 2018
Sergey, can you remove the code that handles this policy so the test will pass, and change policy_templates.json back to have it end in M65? PM has agreed that we have enough times to do proactive comms to admins before M65 launches.
,
Jan 22 2018
I meant "before M66 launches" because the policy will end in M65 (will be supported in M65) but not in 66. Sorry for the confusion.
,
Jan 22 2018
I almost have a CL ready to upload that rips it all out :)
,
Jan 22 2018
OK, please don't remove the policy entry from policy_templates.json tho. We don't remove items from there. But it's OK to mark it as deprecated: True.
,
Jan 22 2018
I have the CL already sent you for the review: https://crrev.com/c/878501
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20de64418bef4b211a01f7d1b00855489d78552e commit 20de64418bef4b211a01f7d1b00855489d78552e Author: Sergey Poromov <poromov@chromium.org> Date: Mon Jan 22 15:41:53 2018 Deprecate and remove EnableCommonNameFallbackForLocalAnchors policy. The policy was introduced in M58 and was set to be sunset in a year, from M66. See https://crbug.com/308330 for more information. BUG= 803791 TEST=Run trybots. Change-Id: Ief8b79d4a55a2c4b1d9d4712fbf40e96d35421fa Reviewed-on: https://chromium-review.googlesource.com/878501 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#530871} [modify] https://crrev.com/20de64418bef4b211a01f7d1b00855489d78552e/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/20de64418bef4b211a01f7d1b00855489d78552e/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/20de64418bef4b211a01f7d1b00855489d78552e/chrome/test/data/policy/policy_test_cases.json [modify] https://crrev.com/20de64418bef4b211a01f7d1b00855489d78552e/components/policy/resources/policy_templates.json
,
Jan 22 2018
,
Jan 22 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mastiz@chromium.org
, Jan 19 2018Status: Started (was: Available)