New issue
Advanced search Search tips

Issue 803788 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security


Participants' hotlists:
Hotlist-OffHeapWasm


Sign in to add a comment

DCHECK failure in wasm::WasmCode::kLazyStub == code->kind() in module-compiler.cc

Project Member Reported by ClusterFuzz, Jan 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6221609999532032

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  wasm::WasmCode::kLazyStub == code->kind() in module-compiler.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=49947:49948

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6221609999532032

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 19 2018

Labels: Test-Predator-Auto-Owner
Owner: mtrofin@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/f2e19a63873a700e6c0a1bca35e8301bd50db4e1 ([wasm] Add --wasm-jit-to-native under --future).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 19 2018

Labels: Pri-1
Owner: mstarzinger@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Labels: -Pri-1 Pri-2
Only reproduces with --wasm-lazy-compilation, which is not on by default, hence lowering priority.
Labels: M-65 Security_Impact-None
Setting to Security_Impact-none since this is not on by default. If there's a set of users who typically set this flag, we should probably change it back to Impact-head.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f30a86c8d355c70f1fe0a098ad0592b188dc5acf

commit f30a86c8d355c70f1fe0a098ad0592b188dc5acf
Author: Michael Starzinger <mstarzinger@chromium.org>
Date: Mon Jan 22 13:11:11 2018

[wasm] Fix lazy compilation with native-heap code.

This fixes a corner-case with lazy compilation in WebAssembly where
native-heap code did not expect to see WASM-to-JS wrappers in tables.

R=clemensh@chromium.org
TEST=mjsunit/regress/wasm/regress-803788
BUG= chromium:803788 

Change-Id: Ie44b5c9efe2b171e1915295bb95d6cb61dfab3dc
Reviewed-on: https://chromium-review.googlesource.com/878262
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50755}
[modify] https://crrev.com/f30a86c8d355c70f1fe0a098ad0592b188dc5acf/src/wasm/module-compiler.cc
[add] https://crrev.com/f30a86c8d355c70f1fe0a098ad0592b188dc5acf/test/mjsunit/regress/wasm/regress-803788.js

Status: Fixed (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Jan 23 2018

ClusterFuzz has detected this issue as fixed in range 50754:50755.

Detailed report: https://clusterfuzz.com/testcase?key=6221609999532032

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  wasm::WasmCode::kLazyStub == code->kind() in module-compiler.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=49947:49948
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=50754:50755

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6221609999532032

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jan 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6221609999532032 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Apr 30 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment