New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 803783 link

Starred by 4 users
Status: Started
Owner:
hidehiko@chromium.org
Cc:
shik@chromium.org
jcliang@chromium.org
keiichiw@chromium.org
vapier@chromium.org
█ oka@chromium.org
chromeos-camera-eng@google.com
nedngu...@google.com
henryhsu@chromium.org
tian.shu...@intel.com
bhthompson@google.com
hidehiko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Move platform/arc-camera to platform2/camera

Project Member Reported by hidehiko@chromium.org, Jan 19 2018 
We prefer platform2/ to platform/ by default.
Now we're moving ARC related code to platform2/arc, so it's nice to move arc-camera code, too, to platform2/ along with the direction to take its advantage.

Note that, nowadays, arc-camera handles not only ARC camera but also Chrome native camera stuffs, too. Thus, rather than platform2/arc/camera, platform2/camera may be more suitable.

Comment 1 by dtapu...@chromium.org, Mar 5 2018

Components: OS>Systems

Comment 2 by hidehiko@chromium.org, Oct 3

Cc: vapier@chromium.org keiichiw@chromium.org
Ricky, Henry, I'm thinking about to work on this, because this may help my libchrome related work.

When do you think is a good timing?
Do you have projects/tasks with very strict schedule?

Comment 3 by jcliang@chromium.org, Oct 3

Cc: chromeos-camera-eng@google.com
platform/arc-camera is always active and we're already looking at product schedules next year. What would be the benefit of moving platform/arc-camera to platform2/camera? I'd like to understand what we gain then we can plan accordingly.

Note that I've already switched all of the Google authored projects under platform/arc-camera to use the same gyp build system as platform2, and I plan to switch the vendor projects to gyp as well this quarter. For example: https://chromium-review.googlesource.com/c/chromiumos/platform/arc-camera/+/1257483

Comment 4 by hidehiko@chromium.org, Oct 3

Cc: oka@chromium.org
It makes it easier to make simple changes across projects (in platform2/).
E.g., I'm updating libchrome, and some patches (mostly machanical ones, like renaming along with the update) can be applied easier across platform2/ projects atomically.

Also, you can take an advantage that is applied to platform2/. E.g., gyp is being deprecated and replaced by gn in platform2/ led by oka@.

Note that, the migration work can be quickly done, just like a one-day ish effort.
I may need to ask you the code review, and to recreate some in-flight CLs during the migration if there are. WDYT?

Comment 5 by jcliang@chromium.org, Oct 3 

We'll also need to let all our partners know the new repo location, and help them with the transition. I expect the traffic on the arc-camera repo to be relatively low after mid or late Oct. Can we do the migration in Nov.?

Comment 6 by hidehiko@chromium.org, Oct 3

Owner: hidehiko@chromium.org
Status: Assigned (was: Untriaged)
SGTM. Let's make this happen on Nov.
Assigned to myself.

Comment 7 by hidehiko@chromium.org, Nov 28

Labels: M-73
Hi, jcliang@, M73 looks like a good target milestone for this kind of clean up.
Do you have any preference of the date? If there's no special reasons, I'm thinking to make this happen on second or third week of Dec. WDYT?

Comment 8 by jcliang@chromium.org, Nov 29 

Right now is actually a good time to do the migration. We expect more traffic by end of Dec. Do you think we can do the migration in the first two weeks of Dec.?

Comment 9 by hidehiko@chromium.org, Dec 3 

Re #8: Thanks! I'll be almost OOO in this week, so let's make the change in the next week, quickly.

Comment 10 by hidehiko@chromium.org, Dec 12

Status: Started (was: Assigned)
Here is the repository for review. jcliang@, vapier@, PTAL.

https://chromium.googlesource.com/chromiumos/platform2/+/sandbox/hidehiko/merge/arc-camera
crrev.com/c/1373669 is the ebuild file update along with the migration. PTAL, too.

Comment 11 by jcliang@google.com, Dec 13 

Thanks for the CLs! The branch and the CL in c#10 lgtm. I'm okay with committing the change after validating the CLs with tryjobs.

Comment 12 by hidehiko@chromium.org, Dec 13 

thanks! Let's push platform2/ code now, then run tryjob.

Comment 13 by hidehiko@chromium.org, Dec 13 

Hmm, rebased, but it seems like I don't have permission to push the change.
vapier@, could you give me it?

Comment 14 by vapier@chromium.org, Dec 18 

the history atm rewrites everything into arc-camera/ and then does a final rename from arc-camera/ to camera/.  it'd be better if the history just used camera/ from the start ... this makes reviewing things a lot better in git log/blame/etc... as you don't have to deal with the two paths.

you'll want to post internal & external manifest CLs to drop arc-camera from the checkout.

we don't give out git push access in general because we don't want people accidentally pushing to branches they didn't mean to.  i'm not saying you'd get it wrong, but it's less effort to have one of the few people with direct git push access do the merge as it is to have one of the few people with Gerrit admin access update ACLs twice (once to add & once to remove).

the general process looks like:
- (re)review the history in the sandbox ref
- review the ebuild CLs
- if it looks OK, move on to the next steps ...
- inform sheriffs (go/crosoncall) of pending update
- push the sandbox ref to the master branch by hand (no force!)
- watch the tree to see if builds start failing (incremental builders will probably start failing fastest)
- if tree doesn't break (i don't think it will in this case because of the rename from arc-camera to camera), then run the ebuild CLs through the CQ like normal
- if tree does break, review the ebuild CLs risk and try chumping them to see if it'll resolve breakage
- iterate until breakage is resolved

personally i strongly prefer to not revert the merge because of the significant noise attached to doing so ... it will make the history very messy to deal with (just ask shill users), as well as bloat it.  if we can "quickly" resolve it via ebuild updates, that'd be preferred.  "it's just canary" right ? :)

Comment 15 by hidehiko@chromium.org, Dec 19 

> the history atm rewrites everything into arc-camera/ and then does a final rename from arc-camera/ to camera/.  it'd be better if the history just used camera/ from the start ... this makes reviewing things a lot better in git log/blame/etc... as you don't have to deal with the two paths.

I'm hesitate to do that, since it changes the history actually rather than merging the history from other git repo into platform2,
but I don't have strong opinion.
Rather, I'd just defer the decision to jcliang@, since it's managed by his team.
WDYT, jcliang@?

> you'll want to post internal & external manifest CLs to drop arc-camera from the checkout.

yes, I know. I will make it after everything settled down.

> we don't give out git push access in general because we don't want people accidentally pushing to branches they didn't mean to.  i'm not saying you'd get it wrong, but it's less effort to have one of the few people with direct git push access do the merge as it is to have one of the few people with Gerrit admin access update ACLs twice (once to add & once to remove).

What I actually need is to move this (or more in future) forward quickly.
If someone could help me _quickly_, that'd work for me, too. How can I know the list of people whom I can ask help?
Here, _quickly_ is very important. Because, while the transition, it is necessary to block others to land CLs to the repository.
Or, some changes landed during the migration would be dropped accidentally.
We should minimize the pain for the people who're working on this. Any, APAC, EMEA timezone friendly admins?

> the general process looks like: ...

Actually, (with minor diff) this is what I'm trying to do, while it was held on at:
- push the sandbox ref to the master branch by hand (no force!)
since I don't have permission to do that. IIUC, there is no special permission for sheriffs, neither...?

> - inform sheriffs (go/crosoncall) of pending update

I was thinking to do this after the push, but indeed it's better to do that as heads up. Thank you for pointing this out.

Comment 16 by nedngu...@google.com, Dec 19

Cc: nedngu...@google.com

Comment 17 by nedngu...@google.com, Dec 19

Components: Infra>Client>ChromeOS>Build

Comment 18 by vapier@chromium.org, Dec 19 

> I'm hesitate to do that, since it changes the history actually rather than merging the history from other git repo into platform2,

how is it changing the history ?  i'm not asking you to rewrite files here.  you're already changing the history with `git mv * arc-camera/`.  i'm saying to do `git mv * camera/` instead.

> since I don't have permission to do that. IIUC, there is no special permission for sheriffs, neither...?

correct, we don't give out direct push access to pretty much anyone by design.  we've had builds break more than once precisely because someone had direct git push access and accidentally pushed something they didn't mean to (like rewriting branches).

Comment 19 by hidehiko@chromium.org, Jan 8 

Re #18: per offline chat with jcliang@, we decided to move forward with directly importing into platform2/camera.

Comment 20 by vapier@chromium.org, Jan 8 

the updated import looks reasonable (commit a1a84d79048e2a4c06f1a48a1ce83a70230544f9).  more changes will be needed in camera/ to clean some stuff up (gyp errors and such), but i don't think they're blockers and can be done after the import.
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/67b4db085a4624e5f4dea2c06f0cd1765581b71f

commit 67b4db085a4624e5f4dea2c06f0cd1765581b71f
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Jan 10 03:52:10 2019

Update ebuild files for platform/arc-camera -> platform2/camera migration.

BUG=chromium:803783
TEST=Built locally.
CQ-DEPEND=CL:1373669

Change-Id: I790f3821f331f5dced6302e64a08124cb094abc0
Reviewed-on: https://chromium-review.googlesource.com/1401888
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/67b4db085a4624e5f4dea2c06f0cd1765581b71f/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/67b4db085a4624e5f4dea2c06f0cd1765581b71f/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild
Project Member

Comment 22 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/de31ebeb5809881aaf342115628e77520793fff5

commit de31ebeb5809881aaf342115628e77520793fff5
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Thu Jan 10 03:52:09 2019

camera: Migrate platform/arc-camera into platform2/camera.

BUG=chromium:803783
TEST=Built locally.
CQ-DEPEND=CL:1401888

Change-Id: I91b5c3eef0960bb27118ceeade11137dbf8fbe5a
Reviewed-on: https://chromium-review.googlesource.com/1373669
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/eclass/cros-camera.eclass
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/de31ebeb5809881aaf342115628e77520793fff5/chromeos-base/cros-camera/cros-camera-9999.ebuild

Comment 23 by shik@google.com, Jan 10

Cc: shik@chromium.org
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4f60316c28a4c9070d43f4dd2c092525fc530de9

commit 4f60316c28a4c9070d43f4dd2c092525fc530de9
Author: Nicolas Boichat <drinkcat@chromium.org>
Date: Thu Jan 10 08:59:28 2019

Revert "camera: Migrate platform/arc-camera into platform2/camera."

This reverts commit de31ebeb5809881aaf342115628e77520793fff5.

Reason for revert: Breaks ToT

Original change's description:
> camera: Migrate platform/arc-camera into platform2/camera.
> 
> BUG=chromium:803783
> TEST=Built locally.
> CQ-DEPEND=CL:1401888
> 
> Change-Id: I91b5c3eef0960bb27118ceeade11137dbf8fbe5a
> Reviewed-on: https://chromium-review.googlesource.com/1373669
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

BUG=chromium:803783
BUG= chromium:920521 

Change-Id: I9db666cb1a276dd41d2466d5499d4bf990295b70
Reviewed-on: https://chromium-review.googlesource.com/c/1404781
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/eclass/cros-camera.eclass
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/4f60316c28a4c9070d43f4dd2c092525fc530de9/chromeos-base/cros-camera/cros-camera-9999.ebuild
Project Member

Comment 25 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9b5b52cbc622a593c0b58c9e963d8feaee0f6274

commit 9b5b52cbc622a593c0b58c9e963d8feaee0f6274
Author: Nicolas Boichat <drinkcat@chromium.org>
Date: Thu Jan 10 08:59:35 2019

Revert "Update ebuild files for platform/arc-camera -> platform2/camera migration."

This reverts commit 67b4db085a4624e5f4dea2c06f0cd1765581b71f.

Reason for revert: Breaks ToT  crbug.com/920521 

Original change's description:
> Update ebuild files for platform/arc-camera -> platform2/camera migration.
> 
> BUG=chromium:803783
> TEST=Built locally.
> CQ-DEPEND=CL:1373669
> 
> Change-Id: I790f3821f331f5dced6302e64a08124cb094abc0
> Reviewed-on: https://chromium-review.googlesource.com/1401888
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>

BUG=chromium:803783
BUG= chromium:920521 

Change-Id: If3b18ea57b8b91376c75f525dcd0b7e875d17cf8
Reviewed-on: https://chromium-review.googlesource.com/c/1404876
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/9b5b52cbc622a593c0b58c9e963d8feaee0f6274/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/9b5b52cbc622a593c0b58c9e963d8feaee0f6274/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild

Comment 26 by drinkcat@chromium.org, Jan 10 

CL were reverted.

This caused multiple failures _after_ the CLs were merged.

hidehiko made an attempt here:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1404457
https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1404874

But more things were still broken.

We should figure out a way to fully test this again before we try relanding.

I'd recommend running tryjobs for at least kevin, poppy, scarlet, paladin _and_ release before retrying, but this may not even be enough...

I prepared relands here for experiments:
https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1404877
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1404782

tryjobs:
cros tryjob -g 1404877 -g 1404782 poppy-release-tryjob poppy-paladin-tryjob kevin-release-tryjob kevin-paladin-tryjob scarlet-paladin-tryjob scarlet-release-tryjob
Tryjob submitted!
To view your tryjobs, visit:
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730115965045104
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730114276846432
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730113389909520
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730112542841008
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730110499300400
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730109754273904

cros tryjob -g 1404877 -g 1404782 -g 1404457 -g 1404874 poppy-release-tryjob poppy-paladin-tryjob kevin-release-tryjob kevin-paladin-tryjob scarlet-paladin-tryjob scarlet-release-tryjob
Tryjob submitted!
To view your tryjobs, visit:
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730021002015520
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730020006036704
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730018814820032
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730017946187984
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730017157317552
  https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8924730015753784624

Let's see if any of these fail...

Comment 27 by jcliang@chromium.org, Jan 10 

After we moved the repo, partner reported that they encountered error when uploading CLs:

fatal: remote error: No Contributor Agreement on file for user <username>

I suppose this means partners who need to submit code to platform2 needs to sign a contributor license agreement:

https://chromium.googlesource.com/chromiumos/docs/+/master/contributing.md#Sign-a-Contributor-License-Agreement

Do we have a best practice to manage corporate CLA for a specific group of partners (for example, Intel camera team)? Or should I ask a partner who needs to upload CL to sign individual CLA?

Comment 28 by bhthompson@google.com, Jan 11 

Intel should already be cleared for CLA uploads through a corporate CLA, what email address was used to try to upload?

Any *@intel.com should be able to upload.

Comment 29 by jcliang@chromium.org, Jan 14

Cc: bhthompson@google.com

Comment 30 by jcliang@chromium.org, Jan 14

Cc: tian.shu...@intel.com
Bernie - Tian Shu (cc'd) said he was upload with his intel.com account when he encountered the error. Is there any additional step we or Intel need to do to whitelist certain people on the CLA?

Comment 31 by bhthompson@google.com, Jan 14 

I am surprised, but it does appear an @intel.com regex is not on https://cs.chromium.org/chromium/src/AUTHORS yet 

AFAIK Intel is already under the CLA, and should be eligible for being added to the file, we just need a CL up there to do so, then Gerrit should let the CL land.
Project Member

Comment 33 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d870b3e25a9ae800f8cb0a90bd172416f65ad01e

commit d870b3e25a9ae800f8cb0a90bd172416f65ad01e
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:43 2019

Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration."

This reverts commit 9b5b52cbc622a593c0b58c9e963d8feaee0f6274 with the fix.

The fix is additional CROS_WORKON_SUBTREE entry (camera/include).
The directory contains shared header files, which are accessed during
the build.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1404786

Change-Id: I6d0e3b953ff497649b102477527b1fad4751cff4
Reviewed-on: https://chromium-review.googlesource.com/1404882
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d870b3e25a9ae800f8cb0a90bd172416f65ad01e/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/d870b3e25a9ae800f8cb0a90bd172416f65ad01e/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild
Project Member

Comment 34 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/731531ca1e122e4849b47f540489b02915cad735

commit 731531ca1e122e4849b47f540489b02915cad735
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:43 2019

Reland "camera: Migrate platform/arc-camera into platform2/camera."

This reverts commit 4f60316c28a4c9070d43f4dd2c092525fc530de9 with the fix.

The fix is to add CROS_WORKON_SUBTREE entry (camera/include) to
arc-camera-service. The directory contains shared header files,
which are accessed during the build.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1404457, CL:1404882

Change-Id: Ic0203920336a52a4fd122779e010de8e8576471c
Reviewed-on: https://chromium-review.googlesource.com/1404786
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/eclass/cros-camera.eclass
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/731531ca1e122e4849b47f540489b02915cad735/chromeos-base/cros-camera/cros-camera-9999.ebuild
Project Member

Comment 35 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/612ae3f53c7c4a36fe983869dd050bbddb2ff7cb

commit 612ae3f53c7c4a36fe983869dd050bbddb2ff7cb
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Jan 15 10:54:44 2019

camera: Fix src_root_path.

The repository is migrated into platform2/camera,
but the path was kept old.

BUG= chromium:920521 , chromium:803783
TEST=Ran try.
CQ-DEPEND=CL:1404786

Change-Id: Id26b1b71e844af22864783ab02222f033d7ca76f
Reviewed-on: https://chromium-review.googlesource.com/1404457
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/612ae3f53c7c4a36fe983869dd050bbddb2ff7cb/camera/build/cros-camera-common.gypi
Project Member

Comment 36 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9fe2dec9926e921379764a798a1884e509df67c3

commit 9fe2dec9926e921379764a798a1884e509df67c3
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Jan 15 23:36:45 2019

Revert "camera: Fix src_root_path."

This reverts commit 612ae3f53c7c4a36fe983869dd050bbddb2ff7cb.

Reason for revert: non-deterministic builds

Original change's description:
> camera: Fix src_root_path.
> 
> The repository is migrated into platform2/camera,
> but the path was kept old.
> 
> BUG= chromium:920521 , chromium:803783
> TEST=Ran try.
> CQ-DEPEND=CL:1404786
> 
> Change-Id: Id26b1b71e844af22864783ab02222f033d7ca76f
> Reviewed-on: https://chromium-review.googlesource.com/1404457
> Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Bug:  chromium:920521 , chromium:803783
Change-Id: I70f9f52b59cae184e770c43cc46bd3c012cea336
Reviewed-on: https://chromium-review.googlesource.com/c/1413495
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/9fe2dec9926e921379764a798a1884e509df67c3/camera/build/cros-camera-common.gypi
Project Member

Comment 37 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/fafb6a126a8b33364ab4731c9a901f172736cb22

commit fafb6a126a8b33364ab4731c9a901f172736cb22
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Jan 15 23:36:57 2019

Revert "Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration.""

This reverts commit d870b3e25a9ae800f8cb0a90bd172416f65ad01e.

Reason for revert: non-deterministic builds

Original change's description:
> Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration."
> 
> This reverts commit 9b5b52cbc622a593c0b58c9e963d8feaee0f6274 with the fix.
> 
> The fix is additional CROS_WORKON_SUBTREE entry (camera/include).
> The directory contains shared header files, which are accessed during
> the build.
> 
> BUG=chromium:803783,  chromium:920521 
> TEST=Ran try.
> CQ-DEPEND=CL:1404786
> 
> Change-Id: I6d0e3b953ff497649b102477527b1fad4751cff4
> Reviewed-on: https://chromium-review.googlesource.com/1404882
> Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Bug: chromium:803783,  chromium:920521 
Change-Id: I4db2a749491dfa14c7a6ba97613ef91352792744
Reviewed-on: https://chromium-review.googlesource.com/c/1413170
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/fafb6a126a8b33364ab4731c9a901f172736cb22/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/fafb6a126a8b33364ab4731c9a901f172736cb22/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild
Project Member

Comment 38 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/eeff9de71875d9f1b0d5b570e9298080b2bf6a70

commit eeff9de71875d9f1b0d5b570e9298080b2bf6a70
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Tue Jan 15 23:37:05 2019

Revert "Reland "camera: Migrate platform/arc-camera into platform2/camera.""

This reverts commit 731531ca1e122e4849b47f540489b02915cad735.

Reason for revert: non-deterministic build breakage

Original change's description:
> Reland "camera: Migrate platform/arc-camera into platform2/camera."
> 
> This reverts commit 4f60316c28a4c9070d43f4dd2c092525fc530de9 with the fix.
> 
> The fix is to add CROS_WORKON_SUBTREE entry (camera/include) to
> arc-camera-service. The directory contains shared header files,
> which are accessed during the build.
> 
> BUG=chromium:803783,  chromium:920521 
> TEST=Ran try.
> CQ-DEPEND=CL:1404457, CL:1404882
> 
> Change-Id: Ic0203920336a52a4fd122779e010de8e8576471c
> Reviewed-on: https://chromium-review.googlesource.com/1404786
> Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
> Tested-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Ricky Liang <jcliang@chromium.org>

Bug: chromium:803783,  chromium:920521 
Change-Id: Ic87a46a41004c7fb2b917e91f8031666c8df40bd
Reviewed-on: https://chromium-review.googlesource.com/c/1413610
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/eclass/cros-camera.eclass
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/eeff9de71875d9f1b0d5b570e9298080b2bf6a70/chromeos-base/cros-camera/cros-camera-9999.ebuild
Project Member

Comment 39 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a64fa38b288db2ab1a77ed8d114280991f9ed25c

commit a64fa38b288db2ab1a77ed8d114280991f9ed25c
Author: Ricky Liang <jcliang@chromium.org>
Date: Wed Jan 16 03:14:16 2019

Add Intel Corportaion in AUTHORS

TBR=dpranke@chromium.org
BUG=803783

Change-Id: I6301137d9f51c6a1835564b62493ba0708c0f138
Reviewed-on: https://chromium-review.googlesource.com/c/1411354
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623076}
[modify] https://crrev.com/a64fa38b288db2ab1a77ed8d114280991f9ed25c/AUTHORS

Comment 40 by liang.l....@intel.com, Jan 16 

yl@icg-hal:~/google/nocturne-build/nocturne-20190116/src/platform2/camera> git push cros HEAD:refs/for/master
fatal: remote error: No Contributor Agreement on file for user Liang L Yang <liang.l.yang@intel.com> (id=1178099)

I still meet push error.
Project Member

Comment 41 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0

commit 509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Jan 19 08:13:34 2019

Reland "Update ebuild files for platform/arc-camera -> platform2/camera migration."

This reverts commit fafb6a126a8b33364ab4731c9a901f172736cb22.

This is simple relanding of the reverted CL due to the tree breakage.
The actual fix for the problem is in CL:1414255.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1414255, CL:1414511

Change-Id: Ic0d907b8f4bea347afa787e12f006c78a3b053ba
Reviewed-on: https://chromium-review.googlesource.com/1414530
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0/chipset-kbl/media-libs/cros-camera-hal-intel-ipu3/cros-camera-hal-intel-ipu3-9999.ebuild
[modify] https://crrev.com/509d0f5f24f61a34ffc5e7e3a9fe8ad5724d7cd0/chipset-rk3399/media-libs/cros-camera-hal-rockchip-isp1/cros-camera-hal-rockchip-isp1-9999.ebuild
Project Member

Comment 42 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/785cc4821df48b41be707da86bb820d2dcb77305

commit 785cc4821df48b41be707da86bb820d2dcb77305
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Jan 19 08:13:34 2019

camera: Reland "camera: Migrate platform/arc-camera into platform2/camera."

This reverts commit eeff9de71875d9f1b0d5b570e9298080b2bf6a70.

This is simple relanding of the reverted CL due to the tree breakage.
The actual fix for the problem is in CL:1414255.

BUG=chromium:803783,  chromium:920521 
TEST=Ran try.
CQ-DEPEND=CL:1414530, CL:1414255

Change-Id: Ieb0a42c7c4024fa2961ec325c6c7b6657de14a6e
Reviewed-on: https://chromium-review.googlesource.com/1414511
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_v4l2_device/cros-camera-libcamera_v4l2_device-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-hal-usb/cros-camera-hal-usb-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libjea_test/cros-camera-libjea_test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-android-headers/cros-camera-android-headers-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcbm/cros-camera-libcbm-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcab-test/cros-camera-libcab-test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_jpeg/cros-camera-libcamera_jpeg-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcab/cros-camera-libcab-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_client/cros-camera-libcamera_client-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/chromeos-base/cros-camera-tool/cros-camera-tool-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_metadata/cros-camera-libcamera_metadata-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libjda/cros-camera-libjda-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/arc-camera-profile/arc-camera-profile-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_exif/cros-camera-libcamera_exif-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_ipc/cros-camera-libcamera_ipc-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_timezone/cros-camera-libcamera_timezone-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/eclass/cros-camera.eclass
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/arc-camera-service/arc-camera-service-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libcamera_common/cros-camera-libcamera_common-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-test/cros-camera-test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/media-libs/cros-camera-libjda_test/cros-camera-libjda_test-9999.ebuild
[modify] https://crrev.com/785cc4821df48b41be707da86bb820d2dcb77305/chromeos-base/cros-camera/cros-camera-9999.ebuild
Project Member

Comment 43 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/42744c62d07d1209595a153c4ec25af734a43ba5

commit 42744c62d07d1209595a153c4ec25af734a43ba5
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Jan 19 08:13:33 2019

camera: Update platform2 related paths.

This reverts commit 9fe2dec9926e921379764a798a1884e509df67c3.
and then add more fixes.

The repository platform/arc-camera is migrated into platform2/camera,
but some paths in the code was not updated and kept as they were relative
to old path.

Also, some of the paths contain "../../platform2/common-mk" to refer it
from "platform/arc-camera". It should work from the new location, but
"../platform2" is redundant now.
Specifically, it could cause build issue if out-of-tree build
does not work due to crbug.com/916471.
The actual problematic scenario we hit was written in  crbug.com/922274 #4.
Thus, the redundant "../platform2" is removed as the fix for it,
which is the diff from the reverted CL.

BUG= chromium:920521 , chromium:803783
TEST=Ran try.
CQ-DEPEND=CL:1414530, CL:1414511

Change-Id: I8d8a7d9398b8e3aacf997063030ed76d85327c38
Reviewed-on: https://chromium-review.googlesource.com/1414255
Commit-Ready: Hidehiko Abe <hidehiko@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcamera_ipc.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/hal/usb/libcamera_hal.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/PRESUBMIT.cfg
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/jpeg/libjda_test.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcab_test.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcbm.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/hal_adapter/cros_camera_service.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcab.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/hal/usb_v1/arc_camera_service.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/build/cros-camera-common.gypi
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/camera3_test/cros_camera_test.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/libcamera_common.gyp
[modify] https://crrev.com/42744c62d07d1209595a153c4ec25af734a43ba5/camera/common/jpeg/libjea_test.gyp
►

Sign in to add a comment