The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/958c5f4806424d2ddf869d8f4720a86040bc4cd7

commit 958c5f4806424d2ddf869d8f4720a86040bc4cd7
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Mon Mar 19 08:20:38 2018

Add signed exchange envelope mimetype to Accept HTTP header

Bug: 803774
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0d523903974747847bb2863e22d9bfa2e148a50a
Reviewed-on: https://chromium-review.googlesource.com/961821
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543988}
[modify] https://crrev.com/958c5f4806424d2ddf869d8f4720a86040bc4cd7/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/958c5f4806424d2ddf869d8f4720a86040bc4cd7/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/958c5f4806424d2ddf869d8f4720a86040bc4cd7/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/958c5f4806424d2ddf869d8f4720a86040bc4cd7/content/browser/web_package/web_package_request_handler_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7cc0a155a592ff4a280b6ff6399836ce3f29dfd

commit b7cc0a155a592ff4a280b6ff6399836ce3f29dfd
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Mar 19 11:46:22 2018

SignedExchangeHandler: Populate load timings

This patch makes SignedExchangeHandler populate the minimal set of
timing info for the HTTP exchange response, so that devtools' network
timeline will show reasonable values.

Bug: 803774
Change-Id: Ida0d34f7bab86f5ff674b776fe5fca511111c87c
Reviewed-on: https://chromium-review.googlesource.com/967632
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544010}
[modify] https://crrev.com/b7cc0a155a592ff4a280b6ff6399836ce3f29dfd/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/b7cc0a155a592ff4a280b6ff6399836ce3f29dfd/content/browser/web_package/signed_exchange_handler_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33b13b2f44690f0ec7b7c8da241d69efad9aa0e3

commit 33b13b2f44690f0ec7b7c8da241d69efad9aa0e3
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Mon Mar 19 23:24:35 2018

Do not show a bad flags warning for performance testing.

crrev.com/c/956654 introduced the bad flags warning of "stability and
security will suffer" for Android.
This change caused parformance regressions because a bad flag
"--ignore-certificate-errors-spki-list" is used for perfomance testing.
(crbug.com/822258#c13)

So this cl introduces the check of "--enable-automation" flag in ShowBadFlagsPrompt().
This check already exists in startup_browser_creator_impl.cc for Desktop not
to show the infobar during performance tests.

crrev.com/c/catapult/+/965712 will add the flag in the script of catapult.

Bug: 822258,803774
Change-Id: Icef23b907460f3a60284675f1dd2f55a73375b72
Reviewed-on: https://chromium-review.googlesource.com/965727
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544206}
[modify] https://crrev.com/33b13b2f44690f0ec7b7c8da241d69efad9aa0e3/chrome/browser/ui/startup/bad_flags_prompt.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c44168adc924fa58eb1f5f004491283999d6600

commit 7c44168adc924fa58eb1f5f004491283999d6600
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Mar 20 10:06:25 2018

Move signed exchange verification tests to content_unittests

Tests for signed exchange verification were written in
WebPackageRequestHandlerBrowserTest, since SignedExchangeHandler
was not unit-testable at the time.

Now SignedExchangeHandler has unit test, so this patch moves
these test cases to SignedExchangeHandlerTest.

Bug: 803774
Change-Id: Ie5333cbf5d1984de56a3a7f7d5a3f350fd92b283
Reviewed-on: https://chromium-review.googlesource.com/970186
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544321}
[modify] https://crrev.com/7c44168adc924fa58eb1f5f004491283999d6600/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/7c44168adc924fa58eb1f5f004491283999d6600/content/browser/web_package/web_package_request_handler_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dfcc6b2cceb29b2186bc9daf2e919cb72cd68ca

commit 1dfcc6b2cceb29b2186bc9daf2e919cb72cd68ca
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Mar 23 02:22:00 2018

SignedExchangeHeader: Only allow lower-cased {request,response} header keys

Bug: 803774, WICG/webpackage:161
Change-Id: Ibf3693682dd69df0f687d1e0fae3b0be5e126eff
Reviewed-on: https://chromium-review.googlesource.com/970221
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545344}
[modify] https://crrev.com/1dfcc6b2cceb29b2186bc9daf2e919cb72cd68ca/content/browser/web_package/signed_exchange_header.cc
[modify] https://crrev.com/1dfcc6b2cceb29b2186bc9daf2e919cb72cd68ca/content/browser/web_package/signed_exchange_header.h
[modify] https://crrev.com/1dfcc6b2cceb29b2186bc9daf2e919cb72cd68ca/content/browser/web_package/signed_exchange_header_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16738aae0cec8408cda317128afbb730a003f32d

commit 16738aae0cec8408cda317128afbb730a003f32d
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Mar 23 04:10:22 2018

Add fuzzer for SignedExchangeHeader

Bug: 803774
Change-Id: I2a5e3d4479238473a86bb5bd8dffe748fabc1940
Reviewed-on: https://chromium-review.googlesource.com/977183
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545363}
[modify] https://crrev.com/16738aae0cec8408cda317128afbb730a003f32d/content/test/fuzzer/BUILD.gn
[add] https://crrev.com/16738aae0cec8408cda317128afbb730a003f32d/content/test/fuzzer/signed_exchange_header_fuzzer.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6947792bbcad6d04e0475aaf05f32377a6abe2e0

commit 6947792bbcad6d04e0475aaf05f32377a6abe2e0
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Mar 23 04:56:11 2018

Update signed-exchange test files

This patch:
- Update the instructions for generating test files
- Update the htxg files by re-generating with latest gen-signedexchange
- Remove signed_exchange_header_test.htxg and use
  test.example.org_test.htxg instead

Bug: 803774
Change-Id: I34c026ee2d7c65946c7b07ed31abdfe2617bf216
Reviewed-on: https://chromium-review.googlesource.com/977341
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545369}
[modify] https://crrev.com/6947792bbcad6d04e0475aaf05f32377a6abe2e0/content/browser/web_package/signed_exchange_header_unittest.cc
[modify] https://crrev.com/6947792bbcad6d04e0475aaf05f32377a6abe2e0/content/browser/web_package/web_package_request_handler_browsertest.cc
[modify] https://crrev.com/6947792bbcad6d04e0475aaf05f32377a6abe2e0/content/test/data/htxg/README
[delete] https://crrev.com/77e7182ad8b3aef0f4c2c1e529c1188e32e8664a/content/test/data/htxg/signed_exchange_header_test.htxg
[modify] https://crrev.com/6947792bbcad6d04e0475aaf05f32377a6abe2e0/content/test/data/htxg/test.example.com_invalid_test.htxg
[modify] https://crrev.com/6947792bbcad6d04e0475aaf05f32377a6abe2e0/content/test/data/htxg/test.example.org_hello.txt.htxg
[modify] https://crrev.com/6947792bbcad6d04e0475aaf05f32377a6abe2e0/content/test/data/htxg/test.example.org_test.htxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d2c2e1cacb73924238b1aa42589a04993519d4

commit c1d2c2e1cacb73924238b1aa42589a04993519d4
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Fri Mar 23 05:53:29 2018

Revert "Do not show a bad flags warning for performance testing."

This reverts commit 33b13b2f44690f0ec7b7c8da241d69efad9aa0e3.

Reason for revert: See  crbug.com/825082 

Original change's description:
> Do not show a bad flags warning for performance testing.
> 
> crrev.com/c/956654 introduced the bad flags warning of "stability and
> security will suffer" for Android.
> This change caused parformance regressions because a bad flag
> "--ignore-certificate-errors-spki-list" is used for perfomance testing.
> (crbug.com/822258#c13)
> 
> So this cl introduces the check of "--enable-automation" flag in ShowBadFlagsPrompt().
> This check already exists in startup_browser_creator_impl.cc for Desktop not
> to show the infobar during performance tests.
> 
> crrev.com/c/catapult/+/965712 will add the flag in the script of catapult.
> 
> Bug: 822258,803774
> Change-Id: Icef23b907460f3a60284675f1dd2f55a73375b72
> Reviewed-on: https://chromium-review.googlesource.com/965727
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544206}

TBR=horo@chromium.org,bauerb@chromium.org,kouhei@chromium.org,tmartino@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822258, 803774
Change-Id: I2cf5a09ab6520938ffcd74c897c0b5dd17516f57
Reviewed-on: https://chromium-review.googlesource.com/977142
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545375}
[modify] https://crrev.com/c1d2c2e1cacb73924238b1aa42589a04993519d4/chrome/browser/ui/startup/bad_flags_prompt.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bdc1c009b1694c15f8ab2922437e43fcd15b97b

commit 0bdc1c009b1694c15f8ab2922437e43fcd15b97b
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Mar 23 06:01:00 2018

Update spec ref to implementation checkpoint

Bug: 803774
Change-Id: I6287bc1eb09c89efbc32ee97bcd2f69c6758c5a5
Reviewed-on: https://chromium-review.googlesource.com/977344
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545377}
[modify] https://crrev.com/0bdc1c009b1694c15f8ab2922437e43fcd15b97b/content/browser/web_package/signed_exchange_header.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96fed608f94226255900681f271a51c6570b69c6

commit 96fed608f94226255900681f271a51c6570b69c6
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Mar 27 07:12:15 2018

Update spec refs in SignedExchangeSignatureVerifier

- Update spec links to the implementation checkpoint
- Use #section-name instead of #rfc.section.numbers as numbers may change.

Bug: 803774
Change-Id: I6f8a72bd89b7deacb33f9da237caa640b86333bd
Reviewed-on: https://chromium-review.googlesource.com/981813
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546045}
[modify] https://crrev.com/96fed608f94226255900681f271a51c6570b69c6/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/96fed608f94226255900681f271a51c6570b69c6/content/browser/web_package/signed_exchange_signature_verifier.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c31794876264003571cd75a6a73fb529ba24852b

commit c31794876264003571cd75a6a73fb529ba24852b
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Mar 27 08:05:48 2018

Update remaining spec links for signed-exchanges

This is a follow-up to crrev.com/c/981813.
- Update spec links to the implementation checkpoint
- Use #section-name instead of #rfc.section.numbers as numbers may change
- Remove unused constants from signed_exchange_consts.h

Bug: 803774
Change-Id: I460d580f30275c6a586cee4b1c7540ff80a98791
Reviewed-on: https://chromium-review.googlesource.com/981874
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546056}
[modify] https://crrev.com/c31794876264003571cd75a6a73fb529ba24852b/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/c31794876264003571cd75a6a73fb529ba24852b/content/browser/web_package/signed_exchange_header.cc
[modify] https://crrev.com/c31794876264003571cd75a6a73fb529ba24852b/content/browser/web_package/signed_exchange_header.h
[modify] https://crrev.com/c31794876264003571cd75a6a73fb529ba24852b/content/browser/web_package/signed_exchange_header_parser.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28c34292f8e091eec325dc01fb3c0765308f32cb

commit 28c34292f8e091eec325dc01fb3c0765308f32cb
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Mar 29 05:16:38 2018

Make SignedExchangeHeader fuzzer use encoded header length

Before this patch, SignedExchangeHeader fuzzer passed the entire input
to the parser. But the seed corpus (htxg files) have 3-byte encoded
length prefix and exchange body.

After this patch, the fuzzer extracts the encoded header length, and
create parser input based on it. This will increase the chance the
CBOR parser gets valid input, so the fuzzer exercises more code.

Bug: 803774
Change-Id: I7334017c4c3e56a95f5699d6c3750eed7e62bc81
Reviewed-on: https://chromium-review.googlesource.com/985336
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546730}
[modify] https://crrev.com/28c34292f8e091eec325dc01fb3c0765308f32cb/content/test/fuzzer/signed_exchange_header_fuzzer.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5555f7d5e3b1efeffc735ac2dbbfe286faaf0b58

commit 5555f7d5e3b1efeffc735ac2dbbfe286faaf0b58
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Fri Mar 30 01:20:38 2018

Show a bad feature flag infobar only for flags in about:flags on Android

I introduced a bad feature flag infobar for SignedHTTPExchange.
[1] https://chromium.googlesource.com/chromium/src/+/a753229
This CL introduced the bad flag infobar to Android Chrome not only for
SignedHTTPExchange but also for all bad flags which are listed as kBadFlags in
bad_flags_prompt.cc.
Before this CL, Android Chrome didn't show any bad flag infobar.

This change caused parformance regressions because a bad flag
"--ignore-certificate-errors-spki-list" is used for perfomance testing.
(crbug.com/822258#c13)

So I added the check of "--enable-automation" flag in ShowBadFlagsPrompt().
[2] https://chromium.googlesource.com/chromium/src/+/33b13b2
And I added --enable-automation flag in GetFromBrowserOptions() in catapult.
[3] https://chromium.googlesource.com/catapult.git/+/df3154e
I thought that this check already existed in startup_browser_creator_impl.cc for
Desktop not to show the infobar during tests.
But on Desktop, a infobar for the automation is always shown when the flag is set.
https://chromium.googlesource.com/chromium/src/+/7a66b24

After the CL [3] pixel_tests are failing on Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/969827
And Catapult AutoRoll is being blocked by the failure.
 https://crbug.com/824779 
I think this is due to the shadow of the infobar.

What I wanted to do was to show the infobar for SignedHTTPExchange.
And I think we don't need to show the bad flag infobar on Android for the flags
which can't be added on non-rooted devices.

So this CL changes the behavior of Android Chrome to show the the infobar only
for flags which are available in about:flags.


Bug:  825082 ,803774,822258
Change-Id: Ieee2bee3f31219645c642d9238599ff82483feeb
Reviewed-on: https://chromium-review.googlesource.com/977252
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547056}
[modify] https://crrev.com/5555f7d5e3b1efeffc735ac2dbbfe286faaf0b58/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/5555f7d5e3b1efeffc735ac2dbbfe286faaf0b58/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/5555f7d5e3b1efeffc735ac2dbbfe286faaf0b58/chrome/browser/ui/startup/bad_flags_prompt.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db7f1b1cd18eacbf5eee2f8b464a49e73b9809f1

commit db7f1b1cd18eacbf5eee2f8b464a49e73b9809f1
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Mar 30 08:29:02 2018

Update content/test/data/htxg/README

Now the implementation fork can be fetched directly with "go get".

Bug: 803774
Change-Id: Ie99585e1e69db3ee5d139ec9ef4868ebe74502e2
Reviewed-on: https://chromium-review.googlesource.com/987653
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547130}
[modify] https://crrev.com/db7f1b1cd18eacbf5eee2f8b464a49e73b9809f1/content/test/data/htxg/README

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fb1aebca0d4909e3fc560f0d6295823d98ba50f

commit 4fb1aebca0d4909e3fc560f0d6295823d98ba50f
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Apr 20 16:12:00 2018

Revert CBORReader::ReadDataItemHeader

This CL removes an unused method.
We originally planned to use the method to parse SignedExchanges, but they no longer require this.

Bug: 803774,  811717 
Change-Id: I5bd3f89891f046e4b6b1f128a63584cd78918266
Reviewed-on: https://chromium-review.googlesource.com/1017420
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552350}
[modify] https://crrev.com/4fb1aebca0d4909e3fc560f0d6295823d98ba50f/components/cbor/cbor_reader.cc
[modify] https://crrev.com/4fb1aebca0d4909e3fc560f0d6295823d98ba50f/components/cbor/cbor_reader.h
[modify] https://crrev.com/4fb1aebca0d4909e3fc560f0d6295823d98ba50f/components/cbor/cbor_reader_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e157f01a717e1e0e37fbb4ca5ab1f355e92bfc

commit f4e157f01a717e1e0e37fbb4ca5ab1f355e92bfc
Author: Rob Buis <rbuis@igalia.com>
Date: Tue May 08 19:43:26 2018

Reuse Signed Exchange header constants better

Reuse Signed Exchange header constants better since naming
can change.

Bug: 803774
Change-Id: I7e203cf42bc53df6639db08e11bf64d59d137f42
Reviewed-on: https://chromium-review.googlesource.com/1049068
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#556931}
[modify] https://crrev.com/f4e157f01a717e1e0e37fbb4ca5ab1f355e92bfc/content/browser/web_package/signed_exchange_header_parser.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5

commit 8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed May 09 09:02:05 2018

Switch SignedExchangeCertificateChain's input to base::span

This is a preparation for the CBOR certificate chain support, in which
the CBOR parser requires input of type base::span<const uint8_t>.

Bug: 803774
Change-Id: I16f96544b3accbf365a826d5c767e479aa7ef11b
Reviewed-on: https://chromium-review.googlesource.com/1051187
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557126}
[modify] https://crrev.com/8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5/content/browser/web_package/signed_exchange_certificate_chain.cc
[modify] https://crrev.com/8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5/content/browser/web_package/signed_exchange_certificate_chain.h
[modify] https://crrev.com/8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc
[modify] https://crrev.com/8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
[modify] https://crrev.com/8e15d6ebfd6571e4256d9d2b34b9b6dfd4774ed5/content/browser/web_package/signed_exchange_handler_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03c28a41214b81d3f81ab1f449057bef6a5743ae

commit 03c28a41214b81d3f81ab1f449057bef6a5743ae
Author: David Benjamin <davidben@chromium.org>
Date: Fri May 11 23:12:07 2018

Check keyUsage bits in QUIC and Web Packaging..

This introduces a wrapper for SignatureVerifier when the public key
comes from a certificate.

Bug:  795086 , 803774
Change-Id: I177e4a2b3ea1b94afbac914c051be9f2b8b67985
Reviewed-on: https://chromium-review.googlesource.com/924349
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558053}
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/BUILD.gn
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/cert/x509_util.cc
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/cert/x509_util.h
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/cert/x509_util_unittest.cc
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/README
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_p256.key
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_p256_both.pem
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_p256_digitalsignature.pem
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_p256_keyagreement.pem
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_p256_no_extension.pem
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_rsa.key
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_rsa_both.pem
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_rsa_digitalsignature.pem
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_rsa_keyencipherment.pem
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/certificates/key_usage_rsa_no_extension.pem
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/scripts/ee.cnf
[add] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/data/ssl/scripts/generate-key-usage-certs.sh
[modify] https://crrev.com/03c28a41214b81d3f81ab1f449057bef6a5743ae/net/quic/chromium/crypto/proof_verifier_chromium.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fec1a0daaacc0e2a5542bdd47d471699f881ff6b

commit fec1a0daaacc0e2a5542bdd47d471699f881ff6b
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue May 15 04:03:36 2018

Multi versioning in SignedExchangeHandler

SignedExchangeHandler parses the content-type header to determine the
version of signed exchange (currently it accepts only version b0), and
passes the version enum to other classes that need versioned code.

Bug: 803774
Change-Id: I90fe2c94d4a5dec61000650338ff4cd0461d2c7d
Reviewed-on: https://chromium-review.googlesource.com/1056940
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558604}
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_cert_fetcher.h
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_cert_fetcher_factory.cc
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_cert_fetcher_factory.h
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_header_parser.cc
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_header_parser.h
[modify] https://crrev.com/fec1a0daaacc0e2a5542bdd47d471699f881ff6b/content/browser/web_package/signed_exchange_header_parser_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66d6309ce65ec31530dbea5a540451be4438a58f

commit 66d6309ce65ec31530dbea5a540451be4438a58f
Author: Rob Buis <rbuis@igalia.com>
Date: Wed May 16 08:13:01 2018

Add more Signed Exchange header constants

Add more Signed Exchange header constants, as identified in
r556931, for consistency.

Bug: 803774
Change-Id: Icbf559670bad539fa618b9a5e98eceb39095d2df
Reviewed-on: https://chromium-review.googlesource.com/1051238
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#559011}
[modify] https://crrev.com/66d6309ce65ec31530dbea5a540451be4438a58f/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/66d6309ce65ec31530dbea5a540451be4438a58f/content/browser/web_package/signed_exchange_header_parser.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c

commit f07721ddd952fba1dc4e7b234b7875d0b5c24a8c
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri May 18 07:55:56 2018

SignedExchangeVerifier: Support ecdsa_secp256r1_sha256 signature algorithm.

Before this CL, SignedExchangeSignatureVerifier only accepted rsa_pss_rsae_sha256 signatures.
This CL adds support for ecdsa_secp256r1_sha256 signature algorithm, used when P-256 keys are input.

Bug: 803774
Change-Id: I5352d6768525b24e07e3896c62cc4f2149364e6e
Reviewed-on: https://chromium-review.googlesource.com/979377
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559832}
[modify] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/test/data/htxg/README
[add] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/test/data/htxg/prime256v1-sha256.crt
[add] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/test/data/htxg/prime256v1-sha256.csr
[add] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/test/data/htxg/prime256v1.key
[add] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/test/data/htxg/secp384r1-sha256.crt
[add] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/test/data/htxg/secp384r1-sha256.csr
[add] https://crrev.com/f07721ddd952fba1dc4e7b234b7875d0b5c24a8c/content/test/data/htxg/secp384r1.key

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41e7a3ee3ee4a6503c95137bc7b0a8efde1a728a

commit 41e7a3ee3ee4a6503c95137bc7b0a8efde1a728a
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Mon May 21 07:15:36 2018

Rename ParseHeadersLength to ParseEncodedLength

In the upcoming version of the signed exchange format, the 3-byte big-endian
encoding would also be used to hold signature field length.
This CL renames the func so they are no longer "header" specific.

Bug: 803774
Change-Id: I15576ac789b9a95ae4e752cf305f1d73f05d72be
Reviewed-on: https://chromium-review.googlesource.com/1067277
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560239}
[modify] https://crrev.com/41e7a3ee3ee4a6503c95137bc7b0a8efde1a728a/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/41e7a3ee3ee4a6503c95137bc7b0a8efde1a728a/content/browser/web_package/signed_exchange_header.cc
[modify] https://crrev.com/41e7a3ee3ee4a6503c95137bc7b0a8efde1a728a/content/browser/web_package/signed_exchange_header.h
[modify] https://crrev.com/41e7a3ee3ee4a6503c95137bc7b0a8efde1a728a/content/browser/web_package/signed_exchange_header_unittest.cc
[modify] https://crrev.com/41e7a3ee3ee4a6503c95137bc7b0a8efde1a728a/content/test/fuzzer/signed_exchange_header_fuzzer.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b79bb6c88aab3db7776300221bbb3ce3b08b0472

commit b79bb6c88aab3db7776300221bbb3ce3b08b0472
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Tue May 29 03:09:31 2018

DCHECK SignedExchangeHandler::state_ transfer

This CL adds DCHECKs for the state_ transfer inside SignedExchangeHandler::DidReadHeader,
and adds comments where kouhei@ misunderstood the logic initially.

Bug: 803774
Change-Id: I9b65620a66e069a19424e030183826165e496ac7
Reviewed-on: https://chromium-review.googlesource.com/1074949
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562315}
[modify] https://crrev.com/b79bb6c88aab3db7776300221bbb3ce3b08b0472/content/browser/web_package/signed_exchange_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ff4d51f4ebab5da3e2a0e2368934d1681f2399f

commit 1ff4d51f4ebab5da3e2a0e2368934d1681f2399f
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue May 29 06:29:42 2018

Don't handle signed exchange transferred over plain HTTP

Bug: 803774
Change-Id: I3dd1d1bd6d8d4938b20c8ac695a1667fb3df80ad
Reviewed-on: https://chromium-review.googlesource.com/1074915
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562352}
[modify] https://crrev.com/1ff4d51f4ebab5da3e2a0e2368934d1681f2399f/content/browser/web_package/web_package_loader.cc
[modify] https://crrev.com/1ff4d51f4ebab5da3e2a0e2368934d1681f2399f/content/browser/web_package/web_package_loader.h
[modify] https://crrev.com/1ff4d51f4ebab5da3e2a0e2368934d1681f2399f/content/browser/web_package/web_package_prefetch_handler.cc
[modify] https://crrev.com/1ff4d51f4ebab5da3e2a0e2368934d1681f2399f/content/browser/web_package/web_package_request_handler.cc
[add] https://crrev.com/1ff4d51f4ebab5da3e2a0e2368934d1681f2399f/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-non-secure-origin.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3766242d03ed7cf6ac24a990399a166745975fd

commit d3766242d03ed7cf6ac24a990399a166745975fd
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed May 30 03:02:20 2018

Update signed exchange tests from b0 to b1

This is in preparation for dropping version b0 support. This converts
existing signed-exchange tests that uses the b0 cert-chain format to b1
(cbor cert chain format).

The .htxg files for layout tests are renamed to .sxg, so that they will
be served with application/signed-exchange;v=b1 content type. Note that
.sxg files are still created with forked gen-signedexchange tool, as
b0->b1 changes for .sxg files are not yet implemented in Chromium.

Bug: 803774
Change-Id: I21bd585085a62c25ffed22a2b36debc437953a6f
Reviewed-on: https://chromium-review.googlesource.com/1073175
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562711}
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/content/browser/web_package/web_package_request_handler_browsertest.cc
[rename] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/content/test/data/htxg/127.0.0.1.public.pem.cbor
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/content/test/data/htxg/README
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/content/test/data/htxg/test.example.com_invalid_test.htxg.mock-http-headers
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/content/test/data/htxg/test.example.org_test.htxg.mock-http-headers
[delete] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/content/test/data/htxg/wildcard_example.org.public.pem.msg
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found-expected.txt
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found.js
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired.js
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation.js
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired.js
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch.js
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-double-prefetch.html
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-expired.html
[delete] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-location-b1.html
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-location.html
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/127.0.0.1.pem.cbor
[delete] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/127.0.0.1.pem.msg
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/README.md
[delete] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.htxg
[add] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.sxg
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location-origin-trial.php
[delete] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.htxg
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.sxg
[delete] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/third_party/WebKit/LayoutTests/virtual/htxg-origin-trial-with-network-service/http/tests/loading/htxg/htxg-location-b1-expected.txt
[delete] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/third_party/WebKit/LayoutTests/virtual/htxg-origin-trial/http/tests/loading/htxg/htxg-location-b1-expected.txt
[modify] https://crrev.com/d3766242d03ed7cf6ac24a990399a166745975fd/third_party/blink/tools/apache_config/mime.types

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4db96308de4426e99975c138a9be96785259731

commit a4db96308de4426e99975c138a9be96785259731
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed May 30 04:37:59 2018

Signed exchange: Drop b0 support

This removes signed exchanve version b0 support.

After this patch, SignedExchangeHandler will reject
"application/signed-exchange;v=b0" content-type, and the Accept: header
will advertise "application/signed-exchange;v=b1".

Bug: 803774
Change-Id: I05c77e3456e45e1b6f4a92daf1abe71b1f211a10
Reviewed-on: https://chromium-review.googlesource.com/1074670
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562735}
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_certificate_chain.cc
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_certificate_chain.h
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
[modify] https://crrev.com/a4db96308de4426e99975c138a9be96785259731/content/browser/web_package/web_package_request_handler_browsertest.cc
[delete] https://crrev.com/ca906e6e038c75d834653b6f0bc13ae03524d2ab/content/test/data/fuzzer_corpus/signed_exchange_certificate_chain_data/1
[delete] https://crrev.com/ca906e6e038c75d834653b6f0bc13ae03524d2ab/content/test/data/fuzzer_corpus/signed_exchange_certificate_chain_data/2
[delete] https://crrev.com/ca906e6e038c75d834653b6f0bc13ae03524d2ab/content/test/data/fuzzer_corpus/signed_exchange_certificate_chain_data/3
[delete] https://crrev.com/ca906e6e038c75d834653b6f0bc13ae03524d2ab/content/test/data/fuzzer_corpus/signed_exchange_certificate_chain_data/4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f8bc1a90b966a0fb017a68ccc026cea7083520

commit 91f8bc1a90b966a0fb017a68ccc026cea7083520
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Thu May 31 10:43:30 2018

Introduce SignedExchangePrologue, the prologue parser for the b1 format

This CL introduces SignedExchangePrologue, which parses the first 11 bytes
of the application/signed-exchange;v=b1 format.

As of this CL, the SignedExchangePrologue::Parse is only used in
the unittest.

Bonus: SignedExchangeEnvelope::ParseEncodedLength is moved to
SignedExchangePrologue::ParseEncodedLength, since the encoded length
only appears in the prologue.

Bug: 803774
Change-Id: I6e3c848541c887c3ac2d491c774561c91d4ba928
Reviewed-on: https://chromium-review.googlesource.com/1075883
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563187}
[modify] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/BUILD.gn
[modify] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/web_package/signed_exchange_envelope.h
[modify] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/web_package/signed_exchange_handler.cc
[add] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/web_package/signed_exchange_prologue.cc
[add] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/web_package/signed_exchange_prologue.h
[add] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/browser/web_package/signed_exchange_prologue_unittest.cc
[modify] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/test/BUILD.gn
[modify] https://crrev.com/91f8bc1a90b966a0fb017a68ccc026cea7083520/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ecbd33685dacf1dc52be03f6b141eb854bfd48

commit 31ecbd33685dacf1dc52be03f6b141eb854bfd48
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 01 01:23:51 2018

Update Signed Exchange's Signature header format to b1

- Update StructuredHeaderParser to recognize
  draft-ietf-httpbis-header-structure-04.
- Make identifiers in Signature headers and corresponding CBOR key
  names lower-case.

Corresponding spec changes:
https://github.com/WICG/webpackage/pull/178
https://github.com/WICG/webpackage/commit/3fc67e27

Bug: 803774
Change-Id: I62ef9307b4d730b473c9c4dd4bf9f95e8c301dd7
Reviewed-on: https://chromium-review.googlesource.com/1077111
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563473}
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/test/data/fuzzer_corpus/signed_exchange_signature_header_field_data/1.txt
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/test/data/fuzzer_corpus/signed_exchange_signature_header_field_data/2.txt
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/test/data/fuzzer_corpus/signed_exchange_signature_header_field_data/3.txt
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/test/data/htxg/README
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/test/data/htxg/test.example.com_invalid_test.htxg
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/test/data/htxg/test.example.org_hello.txt.htxg
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/content/test/data/htxg/test.example.org_test.htxg
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/README.md
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.sxg
[modify] https://crrev.com/31ecbd33685dacf1dc52be03f6b141eb854bfd48/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.sxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648

commit e2e9d0b71ded5408aaa0b469791fc1df4fcf1648
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 01 10:04:33 2018

Signed Exchange: Switch to b1 envelope format

This patch makes SignedExchangeHandler accept signed exchanges of b1
format, in which signature header and cbor header are stored in separate
fields.

Also, this updates the signature context string to "HTTP Exchange 1 b1".

After this patch, Chromium can load signed exchanges generated with
gen-signedechange tool in WICG trunk.

Corresponding spec changes:
- https://github.com/WICG/webpackage/pull/148
- https://github.com/WICG/webpackage/pull/195

Bug: 803774
Change-Id: I81edc2a8b9b8e5db9109e07c1c708babdc41af22
Reviewed-on: https://chromium-review.googlesource.com/1081773
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563576}
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_envelope.h
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/test/data/htxg/README
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/test/data/htxg/test.example.com_invalid_test.htxg
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/test/data/htxg/test.example.org_hello.txt.htxg
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/test/data/htxg/test.example.org_test.htxg
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/README.md
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.sxg
[modify] https://crrev.com/e2e9d0b71ded5408aaa0b469791fc1df4fcf1648/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.sxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b35f32cecfa38a9eac8d03c1844102bdd96a41ed

commit b35f32cecfa38a9eac8d03c1844102bdd96a41ed
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 01 11:12:41 2018

Signed exchange: Check content-type of certificate chain

Bug: 803774
Change-Id: Id395556650ae0aad700a95f20d89c1386e36680e
Reviewed-on: https://chromium-review.googlesource.com/1082175
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563591}
[modify] https://crrev.com/b35f32cecfa38a9eac8d03c1844102bdd96a41ed/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/b35f32cecfa38a9eac8d03c1844102bdd96a41ed/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[add] https://crrev.com/b35f32cecfa38a9eac8d03c1844102bdd96a41ed/content/test/data/htxg/wildcard_example.org.public.pem.cbor.mock-http-headers
[add] https://crrev.com/b35f32cecfa38a9eac8d03c1844102bdd96a41ed/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/.htaccess

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f9c49f6c7ba7a03634086ebe5c239837fccb113

commit 2f9c49f6c7ba7a03634086ebe5c239837fccb113
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Tue Jun 12 01:49:17 2018

Update signed-exchange tests to use SHA256 certs

Bug: 803774
Change-Id: Ibe27d6af5a7f57c5b8869a2596933f3e2846c4ad
Reviewed-on: https://chromium-review.googlesource.com/1094823
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566249}
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-disable-cache-expected.txt
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-disable-cache.js
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[add] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/127.0.0.1.sxg.pem.cbor
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/README.md
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.sxg
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-invalid-validity-url.sxg
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.sxg
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/blink/tools/blinkpy/third_party/wpt/README.chromium
[add] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/blink/tools/blinkpy/third_party/wpt/certs/127.0.0.1.sxg.cnf
[add] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/blink/tools/blinkpy/third_party/wpt/certs/127.0.0.1.sxg.csr
[add] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/blink/tools/blinkpy/third_party/wpt/certs/127.0.0.1.sxg.ext
[add] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/blink/tools/blinkpy/third_party/wpt/certs/127.0.0.1.sxg.key
[add] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/blink/tools/blinkpy/third_party/wpt/certs/127.0.0.1.sxg.pem
[modify] https://crrev.com/2f9c49f6c7ba7a03634086ebe5c239837fccb113/third_party/blink/tools/blinkpy/web_tests/port/base.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bf11a1531ac208936ced0f71973fdfa23415617

commit 4bf11a1531ac208936ced0f71973fdfa23415617
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Tue Jun 12 04:23:14 2018

Update SignedExchange test cases to use prime256v1-sha256 cert signatures.

Before this CL, the signed exchange test cases had RSA signatures.
This CL migrates them to use prime256v1-sha256 signatures.
This is a preparation for the spec change [1].

[1] https://github.com/WICG/webpackage/commit/fa9ebf9e3ec7b900dad04966867769fabde24b90

Bug: 803774
Change-Id: Id253d49764deaef1defe2d156006d1f6c2fb9b84
Reviewed-on: https://chromium-review.googlesource.com/1092550
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566307}
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/browser/web_package/web_package_request_handler_browsertest.cc
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/README
[delete] https://crrev.com/f618560038120e725044255a9c9e4bf0c0117156/content/test/data/htxg/prime256v1-sha256.crt
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/prime256v1-sha256.csr
[add] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/prime256v1-sha256.public.pem
[rename] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/secp384r1-sha256.public.pem
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/test.example.com_invalid_test.htxg
[add] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/test.example.org.public.pem.cbor
[rename] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/test.example.org.public.pem.cbor.mock-http-headers
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/test.example.org_hello.txt.htxg
[modify] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/test.example.org_test.htxg
[delete] https://crrev.com/f618560038120e725044255a9c9e4bf0c0117156/content/test/data/htxg/wildcard_example.org.public.pem.cbor
[add] https://crrev.com/4bf11a1531ac208936ced0f71973fdfa23415617/content/test/data/htxg/x509.ext

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39f43944d5dbf35e9803bd1d6b983c7379891ae

commit c39f43944d5dbf35e9803bd1d6b983c7379891ae
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Tue Jun 12 05:21:49 2018

SignedExchange: Forbid RSA signatures.

Before this CL, SignedExchangeSignatureVerifier also accepted
RSA signatures.
This CL follows the spec change [1] to only accept prime256v1-sha256
signatures, and stop accepting RSA signatures.

[1] https://github.com/WICG/webpackage/commit/fa9ebf9e3ec7b900dad04966867769fabde24b90

Bug: 803774
Change-Id: I2f48118d895503b17b05534d72ace10547f1d6d9
Reviewed-on: https://chromium-review.googlesource.com/1096578
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566324}
[modify] https://crrev.com/c39f43944d5dbf35e9803bd1d6b983c7379891ae/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/c39f43944d5dbf35e9803bd1d6b983c7379891ae/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb748ecf13ba8a62a6fb6ae5115c849116536f63

commit eb748ecf13ba8a62a6fb6ae5115c849116536f63
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Jun 12 21:58:04 2018

Show detailed error for unsupported signed exchange certificate.

Bug: 803774
Change-Id: I5dea7d08ad0366eb0031a2e89b74f711e89a68c7
Reviewed-on: https://chromium-review.googlesource.com/1096729
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566592}
[modify] https://crrev.com/eb748ecf13ba8a62a6fb6ae5115c849116536f63/content/browser/web_package/signed_exchange_error.cc
[modify] https://crrev.com/eb748ecf13ba8a62a6fb6ae5115c849116536f63/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/eb748ecf13ba8a62a6fb6ae5115c849116536f63/content/browser/web_package/signed_exchange_signature_verifier.h
[modify] https://crrev.com/eb748ecf13ba8a62a6fb6ae5115c849116536f63/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa9bdfac16bb59d54d90e270891ce73abf69e844

commit fa9bdfac16bb59d54d90e270891ce73abf69e844
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 15 03:21:53 2018

Rename WebPackageLoader to SignedExchangeLoader

To clarify that it is for single Signed Exchange.

Bug: 803774
Change-Id: I9a7acc5b3c7b1074828c0560fba819ae351d6ff7
Reviewed-on: https://chromium-review.googlesource.com/1100658
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567535}
[modify] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/BUILD.gn
[modify] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/loader/prefetch_browsertest.cc
[rename] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/web_package/signed_exchange_loader.cc
[rename] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/web_package/signed_exchange_loader.h
[modify] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/web_package/web_package_prefetch_handler.cc
[modify] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/web_package/web_package_prefetch_handler.h
[modify] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/web_package/web_package_request_handler.cc
[modify] https://crrev.com/fa9bdfac16bb59d54d90e270891ce73abf69e844/content/browser/web_package/web_package_request_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6aa22ed29197cb23dca26cd09ccd01bf37418ec

commit e6aa22ed29197cb23dca26cd09ccd01bf37418ec
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 15 03:26:55 2018

Rename WebPackageRequestHandler to SignedExchangeRequestHandler

To clarify that it is for single Signed Exchange.

Bug: 803774
Change-Id: If8503589f33749862f82c07569046abe64ec1e37
Reviewed-on: https://chromium-review.googlesource.com/1100728
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567537}
[modify] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/BUILD.gn
[modify] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/web_package/signed_exchange_loader.h
[rename] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/web_package/signed_exchange_request_handler.cc
[rename] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/web_package/signed_exchange_request_handler.h
[rename] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/e6aa22ed29197cb23dca26cd09ccd01bf37418ec/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b91d46a423351e9c2130f921200bd553133c52

commit 66b91d46a423351e9c2130f921200bd553133c52
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 15 08:29:22 2018

Rename WebPackagePrefetchHandler to SignedExchangePrefetchHandler

To clarify that it is for single Signed Exchange.

Bug: 803774
Change-Id: I9890e8a2d717e539f9b03848d04df60e875a0b1a
Reviewed-on: https://chromium-review.googlesource.com/1101611
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567577}
[modify] https://crrev.com/66b91d46a423351e9c2130f921200bd553133c52/content/browser/BUILD.gn
[modify] https://crrev.com/66b91d46a423351e9c2130f921200bd553133c52/content/browser/loader/prefetch_url_loader.cc
[modify] https://crrev.com/66b91d46a423351e9c2130f921200bd553133c52/content/browser/loader/prefetch_url_loader.h
[rename] https://crrev.com/66b91d46a423351e9c2130f921200bd553133c52/content/browser/web_package/signed_exchange_prefetch_handler.cc
[rename] https://crrev.com/66b91d46a423351e9c2130f921200bd553133c52/content/browser/web_package/signed_exchange_prefetch_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3de461f423703ba344131498509f940fd031609e

commit 3de461f423703ba344131498509f940fd031609e
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Mon Jun 18 03:35:21 2018

Support data URL for certificate URL of signed exchange

Bug: 803774
Change-Id: Ibc55a90da18855ef34dae046823f83c6992ce41d
Reviewed-on: https://chromium-review.googlesource.com/1102281
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567927}
[modify] https://crrev.com/3de461f423703ba344131498509f940fd031609e/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/3de461f423703ba344131498509f940fd031609e/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c902c1774b0c5864c3920b5759cf0a3d12f37438

commit c902c1774b0c5864c3920b5759cf0a3d12f37438
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Wed Jun 27 04:42:47 2018

SignedExchange: Update LayoutTests to use https cert-url

This CL prepares for cert-url https restriction change CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1114403

Bug: 803774
Change-Id: Ifcf6b89344803188e06a0af7a83d2e16aec71d5c
Reviewed-on: https://chromium-review.googlesource.com/1114526
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570661}
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-cert-not-found-expected.txt
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-disable-cache-expected.txt
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-disable-cache.js
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expected.txt
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-navigation-expired-expected.txt
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expected.txt
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-prefetch-expired-expected.txt
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-location-origin-trial.html
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-location.html
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/README.md
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.sxg
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-invalid-validity-url.sxg
[modify] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.sxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee

commit 17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Jun 27 05:50:36 2018

Signed Exchange: Actually add subjectAltName to the test certificate

Bug: 803774
Change-Id: I8eaea16d8730dcc0fe8a3e5bbbe5321241c7e80e
Reviewed-on: https://chromium-review.googlesource.com/1116398
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570671}
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/README
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/prime256v1-sha256.csr
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/prime256v1-sha256.public.pem
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/test.example.com_invalid_test.htxg
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/test.example.org.public.pem.cbor
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/test.example.org_hello.txt.htxg
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/test.example.org_test.htxg
[modify] https://crrev.com/17f7cad1ee1452fdebb5c5b4b7b70364cc9c92ee/content/test/data/htxg/x509.ext

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09c2c541b5e48c41a51f16c3dcff424c55d3c641

commit 09c2c541b5e48c41a51f16c3dcff424c55d3c641
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Wed Jun 27 16:05:38 2018

SignedExchange: Apply scheme restriction to {cert,validity}-url

This CL follows signed exchange spec change:
https://github.com/WICG/webpackage/commit/3903da6e

Bug: 803774
Change-Id: I7f122272cf93f46a26757b08fe8a9d80f0404518
Reviewed-on: https://chromium-review.googlesource.com/1114403
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570790}
[modify] https://crrev.com/09c2c541b5e48c41a51f16c3dcff424c55d3c641/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/09c2c541b5e48c41a51f16c3dcff424c55d3c641/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22f3171b2bb00ca981c468708ebdf0f9e3d0e4c

commit a22f3171b2bb00ca981c468708ebdf0f9e3d0e4c
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Jun 29 05:59:25 2018

SignedExchange: restrict :url scheme to https

This CL follows signed exchange spec change:
https://github.com/WICG/webpackage/commit/3903da6e

Bug: 803774
Change-Id: If93b419488c166b1d8ec8a35b7a752a439d1cd7a
Reviewed-on: https://chromium-review.googlesource.com/1114407
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571401}
[modify] https://crrev.com/a22f3171b2bb00ca981c468708ebdf0f9e3d0e4c/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/a22f3171b2bb00ca981c468708ebdf0f9e3d0e4c/content/browser/web_package/signed_exchange_envelope_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c94a953ab583be32203f62ba3ff563f7b7358c2

commit 6c94a953ab583be32203f62ba3ff563f7b7358c2
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Jul 19 01:22:03 2018

Signed Exchange: Append "-draft2" to MI encoding identifiers

Bug: 803774
Change-Id: I91b9def8e3e4506c4d8913cb351129286f3686d1
Reviewed-on: https://chromium-review.googlesource.com/1141668
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576300}
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/browser/loader/merkle_integrity_source_stream.cc
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/browser/loader/merkle_integrity_source_stream_unittest.cc
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/test/data/sxg/test.example.com_invalid_test.sxg
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/test/data/sxg/test.example.org_hello.txt.sxg
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/test/data/sxg/test.example.org_noext_test.sxg
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/content/test/data/sxg/test.example.org_test.sxg
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-cert-not-found.sxg
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-invalid-validity-url.sxg
[modify] https://crrev.com/6c94a953ab583be32203f62ba3ff563f7b7358c2/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.sxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a282d85bdb8e00eff9d56647f9f82cb5794cb3d

commit 8a282d85bdb8e00eff9d56647f9f82cb5794cb3d
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Jul 19 04:43:59 2018

Signed exchange: Increase the header size limit to 512kB

Spec side change: https://github.com/WICG/webpackage/pull/261

Bug: 803774
Change-Id: I0d0aa289b6f991b3cb09b2f53f6b1fbf752d2bbd
Reviewed-on: https://chromium-review.googlesource.com/1142846
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576371}
[modify] https://crrev.com/8a282d85bdb8e00eff9d56647f9f82cb5794cb3d/content/browser/web_package/signed_exchange_prologue.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43dcce8bc1451019ca9e00f89d7098f6617f72cd

commit 43dcce8bc1451019ca9e00f89d7098f6617f72cd
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jul 20 01:43:26 2018

Signed Exchange: Add scripts to generate test data

Bug: 803774
Change-Id: I9c9f9ff1a070b0bcf86312f6a80c56146b9d475b
Reviewed-on: https://chromium-review.googlesource.com/1143095
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576751}
[modify] https://crrev.com/43dcce8bc1451019ca9e00f89d7098f6617f72cd/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[delete] https://crrev.com/4552e231b5d08f9c327e346c92681b9399530612/content/test/data/sxg/README
[add] https://crrev.com/43dcce8bc1451019ca9e00f89d7098f6617f72cd/content/test/data/sxg/README.md
[add] https://crrev.com/43dcce8bc1451019ca9e00f89d7098f6617f72cd/content/test/data/sxg/generate-test-certs.sh
[add] https://crrev.com/43dcce8bc1451019ca9e00f89d7098f6617f72cd/content/test/data/sxg/generate-test-sxgs.sh

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6a9d1411958312c7fc03a3f96f9e39438276ed

commit ec6a9d1411958312c7fc03a3f96f9e39438276ed
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Jul 24 05:22:35 2018

Signed Exchange: Add scripts to generate test data for Layout Tests

Bug: 803774
Change-Id: Ic0d8445643d3a0639ce9b4527675be50d1f4b1af
Reviewed-on: https://chromium-review.googlesource.com/1147886
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577432}
[modify] https://crrev.com/ec6a9d1411958312c7fc03a3f96f9e39438276ed/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/README.md
[add] https://crrev.com/ec6a9d1411958312c7fc03a3f96f9e39438276ed/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-certs.sh
[add] https://crrev.com/ec6a9d1411958312c7fc03a3f96f9e39438276ed/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019

commit f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Jul 30 09:01:04 2018

Signed Exchange: Update generate-test-sxgs.sh to use -sctDir

gen-certurl's -sct option is deprecated in
https://github.com/WICG/webpackage/pull/259.

Bug: 803774
Change-Id: I4fbc575366aba978b262418d2cf415121e840099
Reviewed-on: https://chromium-review.googlesource.com/1154745
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578999}
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/test/data/sxg/generate-test-sxgs.sh
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/test/data/sxg/test.example.com_invalid_test.sxg
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/test/data/sxg/test.example.org-noext.public.pem.cbor
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/test/data/sxg/test.example.org.public.pem.cbor
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/test/data/sxg/test.example.org_hello.txt.sxg
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/test/data/sxg/test.example.org_noext_test.sxg
[modify] https://crrev.com/f1e06b5ccd233fd6ece2ad5fcf4ddfc11af76019/content/test/data/sxg/test.example.org_test.sxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/304c2bc1d38d2332be13e488bda066c375b665ce

commit 304c2bc1d38d2332be13e488bda066c375b665ce
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Fri Aug 03 10:53:18 2018

Cleanup some stale comments in SignedExchangeRequestHandler

R=kouhei, ksakamoto

Bug: 803774
Change-Id: Ia0543486846c137fef02f230b804e3d613c29875
Reviewed-on: https://chromium-review.googlesource.com/1161851
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580501}
[modify] https://crrev.com/304c2bc1d38d2332be13e488bda066c375b665ce/content/browser/web_package/signed_exchange_request_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c05bf87eb2698baa4e5b8c25597b8b51226a89d8

commit c05bf87eb2698baa4e5b8c25597b8b51226a89d8
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Aug 07 08:35:27 2018

Update spec text in signed_exchange_certificate_chain.cc

Bug: 803774
Change-Id: Ieb39e079c26a508f11fe582b7419bf47b1be696a
Reviewed-on: https://chromium-review.googlesource.com/1164804
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581166}
[modify] https://crrev.com/c05bf87eb2698baa4e5b8c25597b8b51226a89d8/content/browser/web_package/signed_exchange_certificate_chain.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e992a784aeda624fa9fdae2d7c94608728b993b

commit 0e992a784aeda624fa9fdae2d7c94608728b993b
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Aug 24 08:10:03 2018

SignedExchange: Switch to b2 format parser.

Before this CL, Signed Exchange parser implementation in Chromium
expected the b1 format [spec-b1].

This CL switches the parser implementation to expect the updated
specification which we will snapshot as the b2 format in near future,
and deprecate support for parsing the b1 format.

Overview:
- The magic strings and version specifiers are changed from b1 -> b2.
- RequestUrl was a part of cbor_headers in b1, but is now located in the prologue section.
  - As a result, SignedExchangePrologue is now split into two: {BeforeFallbackUrl, FallbackUrlAndAfter}
- Signature message bytes are now encoded using custom binary format (was CBOR in b1)
  - cbor_headers no longer go through enc(dec(original_bytes)), fixes  crbug.com/863499 

Note: fallbackUrl redirect on parse fail ( crbug.com/874323  ) is to be addressed in separate CL.

[spec-b1] https://tools.ietf.org/html/draft-yasskin-httpbis-origin-signed-exchanges-impl-01

Bug: 803774,  863499 ,  876968 
Change-Id: Ib172411e075472dcaae21af9c7460af5b5cf4e52
Reviewed-on: https://chromium-review.googlesource.com/1183053
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585754}
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_certificate_chain.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_envelope.h
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_prologue.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_prologue.h
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_prologue_unittest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/data/sxg/generate-test-sxgs.sh
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/data/sxg/test.example.com_invalid_test.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/data/sxg/test.example.org_hello.txt.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/data/sxg/test.example.org_noext_test.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/data/sxg/test.example.org_test.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/data/sxg/test.example.org_test.sxg.mock-http-headers
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/fallback-to-another-sxg.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-cert-not-found.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-invalid-validity-url.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location-origin-trial.php
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.sxg
[modify] https://crrev.com/0e992a784aeda624fa9fdae2d7c94608728b993b/third_party/blink/tools/apache_config/mime.types

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07195ab95a503d33c32c64f7e0d7cb95c1e6c3f

commit e07195ab95a503d33c32c64f7e0d7cb95c1e6c3f
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Aug 24 09:43:51 2018

Document class SignedExchangeHandler

and remove obsolete comments.

Bug: 803774
Change-Id: Ifa7c7c287fa11f312d62a3f9b18e79be7f47c572
Reviewed-on: https://chromium-review.googlesource.com/1187858
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585777}
[modify] https://crrev.com/e07195ab95a503d33c32c64f7e0d7cb95c1e6c3f/content/browser/web_package/signed_exchange_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0

commit 9ee2a7148b6cdb379b1b927b8808aa8f62e438f0
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Aug 24 19:50:45 2018

Get web packaging working with network service.

Move the code to call certificate verification from content/browser to services/network.

Bug: 803774

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I7a7c6c986afa8340a6467d26024e6382b8b2f13b
Reviewed-on: https://chromium-review.googlesource.com/1182872
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585952}
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/loader/prefetch_browsertest.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_loader.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_loader.h
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_prefetch_handler.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_request_handler.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_request_handler.h
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/public/test/content_cert_verifier_browser_test.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/content/public/test/content_cert_verifier_browser_test.h
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/network_context.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/network_context.h
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/public/cpp/net_ipc_param_traits.cc
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/public/cpp/net_ipc_param_traits.h
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/public/cpp/network_param.typemap
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/public/mojom/network_param.mojom
[modify] https://crrev.com/9ee2a7148b6cdb379b1b927b8808aa8f62e438f0/services/network/test/test_network_context.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a939e1ce90846848efeb952bccb0bad6700827a

commit 2a939e1ce90846848efeb952bccb0bad6700827a
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Aug 27 09:32:16 2018

Re-enable 'with-network-service' configurations of Signed Exchange tests

Bug: 803774
Change-Id: If049ec90db90587d3e7ed0fb5060ef43888a1ee8
Reviewed-on: https://chromium-review.googlesource.com/1188733
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586217}
[modify] https://crrev.com/2a939e1ce90846848efeb952bccb0bad6700827a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2a939e1ce90846848efeb952bccb0bad6700827a/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-expected.txt
[modify] https://crrev.com/2a939e1ce90846848efeb952bccb0bad6700827a/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-expired-expected.txt
[add] https://crrev.com/2a939e1ce90846848efeb952bccb0bad6700827a/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/fallback-to-another-sxg-expected.txt
[add] https://crrev.com/2a939e1ce90846848efeb952bccb0bad6700827a/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/sxg-expired-expected.txt
[add] https://crrev.com/2a939e1ce90846848efeb952bccb0bad6700827a/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/sxg-fallback-with-fragment-expected.txt
[add] https://crrev.com/2a939e1ce90846848efeb952bccb0bad6700827a/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/sxg-location-fragment-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af

commit eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Tue Aug 28 02:50:11 2018

SignedExchange: Extract fallbackUrl and redirect for sxgs which magic string are invalid.

Before this CL, SignedExchangeHandler aborted parsing immediately when
the stream did not have correct magic string.

After this CL, SignedExchangeHandler will not stop parsing on invalid magic
string, and attempt to extract fallbackUrl. With this change, navigating to
a sxg with invalid magic string will redirect to its fallbackUrl as long as
it is valid.

Bug: 803774,  874323 ,  876968 
Change-Id: Ib903854f0a80437acd05e1fa6b9e71b759aa4c35
Reviewed-on: https://chromium-review.googlesource.com/1187855
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586555}
[modify] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/content/browser/web_package/signed_exchange_loader.cc
[modify] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/content/test/data/sxg/generate-test-sxgs.sh
[add] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/content/test/data/sxg/test.example.org_test_invalid_magic_string.sxg
[add] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/content/test/data/sxg/test.example.org_test_invalid_magic_string.sxg.mock-http-headers
[modify] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-invalid-validity-url.html
[add] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/sxg-invalid-validity-url-expected.txt
[add] https://crrev.com/eef241f6fdf6b7b93f4617cea1ea2f43abf0b3af/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/sxg-invalid-validity-url-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1a2f3221ffd3918681fe5f6f5ac8810a12ca0dc

commit b1a2f3221ffd3918681fe5f6f5ac8810a12ca0dc
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Aug 28 03:04:30 2018

Signed Exchange: Disallow redirect inner response

Bug: 803774
Change-Id: Id0d5575c162467ae1bd4c85b67ad7d54fb6c49e3
Reviewed-on: https://chromium-review.googlesource.com/1164816
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586564}
[modify] https://crrev.com/b1a2f3221ffd3918681fe5f6f5ac8810a12ca0dc/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/b1a2f3221ffd3918681fe5f6f5ac8810a12ca0dc/content/browser/web_package/signed_exchange_envelope_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44900507c9c66d312f17f0d908f51e32f0e4c186

commit 44900507c9c66d312f17f0d908f51e32f0e4c186
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Aug 28 06:15:15 2018

SignedExchange: Fallback redirect on unsupported versions of content-type

Before this CL, SignedExchangeHandler did not parse signed exchanges
when the v= parameter of content type was invalid.

After this CL, SignedExchangeHandler will parse the signed exchange
prologue even if content type indicates an unsupported version, and will
redirect to the sxg's fallbackUrl as long as it is valid.

Bug: 803774,  874323 ,  876968 
Change-Id: I7f890f439c25b8591f0d741fa6257282f791cdf1
Reviewed-on: https://chromium-review.googlesource.com/1192472
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586594}
[modify] https://crrev.com/44900507c9c66d312f17f0d908f51e32f0e4c186/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/44900507c9c66d312f17f0d908f51e32f0e4c186/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/44900507c9c66d312f17f0d908f51e32f0e4c186/content/test/data/sxg/generate-test-sxgs.sh
[modify] https://crrev.com/44900507c9c66d312f17f0d908f51e32f0e4c186/content/test/data/sxg/test.example.org_test_invalid_content_type.sxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f

commit b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Sep 04 04:09:02 2018

Signed Exchange: Make content-type parsing more conformant to the spec

Before this patch, StructuredHeaderParser was used to extract the v=
parameter of application/signed-exchange content type. However, the
content-type header field has slightly different syntax [1]. For
example, parameter names are not restricted to lower case but are
case-insensitive.

This patch replaces
SignedExchangeSignatureHeaderField::GetVersionParamFromContentType()
with signed_exchange_utils::GetSignedExchangeVersion() function, which
follows the "Identifying signed exchanges" algorithm [2] and uses
HttpUtil::NameValuePairsIterator to parse parameters.

[1] https://tools.ietf.org/html/rfc7231#section-3.1.1.1
[2] https://wicg.github.io/webpackage/loading.html#signed-exchange-version

Bug: 803774
Change-Id: Ibc00d20837ed2e1f503b3734cbf015468f4bf756
Reviewed-on: https://chromium-review.googlesource.com/1201635
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588449}
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field.h
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils.h
[add] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils_unittest.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146f251c3adb374f671bd034d4cf91832bcfd234

commit 146f251c3adb374f671bd034d4cf91832bcfd234
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Sep 04 08:52:56 2018

Signed Exchange: Disallow nested Signed Exchanges

This patch lets SignedExchangeEnvelope::Parse() fail if the inner
response has "application/signed-exchange;v=*" content type.

Bug: 803774
Change-Id: I61428dd09ef2dec98e07e3adf7ff6ae50a854493
Reviewed-on: https://chromium-review.googlesource.com/1203471
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588475}
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/content/browser/web_package/signed_exchange_envelope_unittest.cc
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/nested-sxg.html
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/nested-sxg.sxg
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/nested-sxg-expected.txt
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/nested-sxg-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7709215b21fecba8ed18b6497c0214b60c40563

commit f7709215b21fecba8ed18b6497c0214b60c40563
Author: Rob Buis <rbuis@igalia.com>
Date: Tue Sep 04 10:05:23 2018

Fix typos in web_package

Some typo and suggested corrections.

Bug: 803774

Change-Id: Ia695bb55f52b9c5777c6ace22db5fcf093c948f7
Reviewed-on: https://chromium-review.googlesource.com/1203371
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#588480}
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_certificate_chain.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_envelope.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_signature_header_field.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f

commit b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Sep 04 04:09:02 2018

Signed Exchange: Make content-type parsing more conformant to the spec

Before this patch, StructuredHeaderParser was used to extract the v=
parameter of application/signed-exchange content type. However, the
content-type header field has slightly different syntax [1]. For
example, parameter names are not restricted to lower case but are
case-insensitive.

This patch replaces
SignedExchangeSignatureHeaderField::GetVersionParamFromContentType()
with signed_exchange_utils::GetSignedExchangeVersion() function, which
follows the "Identifying signed exchanges" algorithm [2] and uses
HttpUtil::NameValuePairsIterator to parse parameters.

[1] https://tools.ietf.org/html/rfc7231#section-3.1.1.1
[2] https://wicg.github.io/webpackage/loading.html#signed-exchange-version

Bug: 803774
Change-Id: Ibc00d20837ed2e1f503b3734cbf015468f4bf756
Reviewed-on: https://chromium-review.googlesource.com/1201635
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588449}
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field.h
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils.h
[add] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils_unittest.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146f251c3adb374f671bd034d4cf91832bcfd234

commit 146f251c3adb374f671bd034d4cf91832bcfd234
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Sep 04 08:52:56 2018

Signed Exchange: Disallow nested Signed Exchanges

This patch lets SignedExchangeEnvelope::Parse() fail if the inner
response has "application/signed-exchange;v=*" content type.

Bug: 803774
Change-Id: I61428dd09ef2dec98e07e3adf7ff6ae50a854493
Reviewed-on: https://chromium-review.googlesource.com/1203471
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588475}
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/content/browser/web_package/signed_exchange_envelope_unittest.cc
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/nested-sxg.html
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/nested-sxg.sxg
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/nested-sxg-expected.txt
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/nested-sxg-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7709215b21fecba8ed18b6497c0214b60c40563

commit f7709215b21fecba8ed18b6497c0214b60c40563
Author: Rob Buis <rbuis@igalia.com>
Date: Tue Sep 04 10:05:23 2018

Fix typos in web_package

Some typo and suggested corrections.

Bug: 803774

Change-Id: Ia695bb55f52b9c5777c6ace22db5fcf093c948f7
Reviewed-on: https://chromium-review.googlesource.com/1203371
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#588480}
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_certificate_chain.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_envelope.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_signature_header_field.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f

commit b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Sep 04 04:09:02 2018

Signed Exchange: Make content-type parsing more conformant to the spec

Before this patch, StructuredHeaderParser was used to extract the v=
parameter of application/signed-exchange content type. However, the
content-type header field has slightly different syntax [1]. For
example, parameter names are not restricted to lower case but are
case-insensitive.

This patch replaces
SignedExchangeSignatureHeaderField::GetVersionParamFromContentType()
with signed_exchange_utils::GetSignedExchangeVersion() function, which
follows the "Identifying signed exchanges" algorithm [2] and uses
HttpUtil::NameValuePairsIterator to parse parameters.

[1] https://tools.ietf.org/html/rfc7231#section-3.1.1.1
[2] https://wicg.github.io/webpackage/loading.html#signed-exchange-version

Bug: 803774
Change-Id: Ibc00d20837ed2e1f503b3734cbf015468f4bf756
Reviewed-on: https://chromium-review.googlesource.com/1201635
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588449}
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_consts.h
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field.h
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils.h
[add] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/browser/web_package/signed_exchange_utils_unittest.cc
[modify] https://crrev.com/b5c94d905e1ecc124bdc760f417cfd5fbbff3b1f/content/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146f251c3adb374f671bd034d4cf91832bcfd234

commit 146f251c3adb374f671bd034d4cf91832bcfd234
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Sep 04 08:52:56 2018

Signed Exchange: Disallow nested Signed Exchanges

This patch lets SignedExchangeEnvelope::Parse() fail if the inner
response has "application/signed-exchange;v=*" content type.

Bug: 803774
Change-Id: I61428dd09ef2dec98e07e3adf7ff6ae50a854493
Reviewed-on: https://chromium-review.googlesource.com/1203471
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588475}
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/content/browser/web_package/signed_exchange_envelope_unittest.cc
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/nested-sxg.html
[modify] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/generate-test-sxgs.sh
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/nested-sxg.sxg
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/nested-sxg-expected.txt
[add] https://crrev.com/146f251c3adb374f671bd034d4cf91832bcfd234/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/nested-sxg-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7709215b21fecba8ed18b6497c0214b60c40563

commit f7709215b21fecba8ed18b6497c0214b60c40563
Author: Rob Buis <rbuis@igalia.com>
Date: Tue Sep 04 10:05:23 2018

Fix typos in web_package

Some typo and suggested corrections.

Bug: 803774

Change-Id: Ia695bb55f52b9c5777c6ace22db5fcf093c948f7
Reviewed-on: https://chromium-review.googlesource.com/1203371
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#588480}
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_certificate_chain.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_envelope.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_handler.h
[modify] https://crrev.com/f7709215b21fecba8ed18b6497c0214b60c40563/content/browser/web_package/signed_exchange_signature_header_field.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f0fd8fcc4a0cc89b295d4ff218d0e4d82bd431f

commit 9f0fd8fcc4a0cc89b295d4ff218d0e4d82bd431f
Author: Rob Buis <rbuis@igalia.com>
Date: Fri Sep 07 12:02:01 2018

Add negative tests to SignedExchangeUtils unit test

Add negative tests to SignedExchangeUtils unit test to test
how we deal with questionable/wrong content types.

Bug: 803774

Change-Id: If726951a4fb96506251ad7fd1ac26a6940174e6c
Reviewed-on: https://chromium-review.googlesource.com/1203995
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#589495}
[modify] https://crrev.com/9f0fd8fcc4a0cc89b295d4ff218d0e4d82bd431f/content/browser/web_package/signed_exchange_utils_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6015d0e95463bd1c73086f700dae442e4429a95c

commit 6015d0e95463bd1c73086f700dae442e4429a95c
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Sep 10 08:20:27 2018

generate-test-sxgs.sh: Switch to dump-signedexchange again

Now dump-signedexchange supports the b2 format, so let's use it.

Bug: 803774
Change-Id: Ie0f1040f2c6428a4ada41095f1226f8ed8e12c99
Reviewed-on: https://chromium-review.googlesource.com/1215522
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589856}
[modify] https://crrev.com/6015d0e95463bd1c73086f700dae442e4429a95c/content/test/data/sxg/README.md
[modify] https://crrev.com/6015d0e95463bd1c73086f700dae442e4429a95c/content/test/data/sxg/generate-test-sxgs.sh

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5c341a593985cab6e646bca1ae5511d93efd4e5

commit f5c341a593985cab6e646bca1ae5511d93efd4e5
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Sep 14 09:01:25 2018

SignedExchange: Fix "invalid cbor header" test data

In b2 format, CBOR header no longer appears at the first line of the
xxd output.

Bug: 803774
Change-Id: I57b8a3833cbc2ec7339346244fe23099680f6a86
Reviewed-on: https://chromium-review.googlesource.com/1226754
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591305}
[modify] https://crrev.com/f5c341a593985cab6e646bca1ae5511d93efd4e5/content/test/data/sxg/generate-test-sxgs.sh
[modify] https://crrev.com/f5c341a593985cab6e646bca1ae5511d93efd4e5/content/test/data/sxg/test.example.org_test_invalid_cbor_header.sxg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b803d209d38aa9438b00e1dbd0f03a0124ff29

commit 73b803d209d38aa9438b00e1dbd0f03a0124ff29
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Oct 05 09:09:52 2018

Signed Exchange: --ignore-certificate-errors-spki-list ignores signature timestamp error

This patch lets SignedExchangeSignatureVerifier ignore signature
timestamp errors if the Signed Exchange's main certificate is listed in
--ignore-certificate-errors-spki-list flag, and ContentBrowserClient::
CanIgnoreCertificateErrorIfNeeded() returns true.

This enables us to write layout tests and web-platform-tests for signed
exchange loading, without using UA-specific testing API that overrides
signature verification time.

This patch also removes setSignedExchangeVerificationTime() calls from
existing layout tests, because they already run with
--ignore-certificate-errors-spki-list flag. This means we lose layout
test coverage for expired SXG loading, so I added a test case in
signed_exchange_request_handler_browsertest.cc.

Bug: 803774
Change-Id: Ia2f9dc5f28036c30e76acc344137ab8873bfb7c6
Reviewed-on: https://chromium-review.googlesource.com/c/1253167
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597045}
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/browser/web_package/signed_exchange_signature_verifier.h
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/public/browser/content_browser_client.h
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/shell/browser/layout_test/layout_test_content_browser_client.h
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/content/test/data/sxg/generate-test-certs.sh
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-cert-not-found.js
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-disable-cache.js
[delete] https://crrev.com/64bc6eb992f63892a2a30b0a29285c5674af0fce/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation-expired-expected.txt
[delete] https://crrev.com/64bc6eb992f63892a2a30b0a29285c5674af0fce/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation-expired.js
[add] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation-fail-expected.txt
[add] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation-fail.js
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation.js
[delete] https://crrev.com/64bc6eb992f63892a2a30b0a29285c5674af0fce/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-expired-expected.txt
[add] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-fail-expected.txt
[rename] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-fail.js
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch.js
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/fallback-to-another-sxg.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/nested-sxg.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-util.js
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-double-prefetch.html
[delete] https://crrev.com/64bc6eb992f63892a2a30b0a29285c5674af0fce/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-expired.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-fallback-with-fragment.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-invalid-validity-url.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location-fragment.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location-origin-trial.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-non-secure-origin.html
[modify] https://crrev.com/73b803d209d38aa9438b00e1dbd0f03a0124ff29/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-usecounter.html
[delete] https://crrev.com/64bc6eb992f63892a2a30b0a29285c5674af0fce/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/sxg-expired-expected.txt
[delete] https://crrev.com/64bc6eb992f63892a2a30b0a29285c5674af0fce/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/sxg-expired-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a2d7e5a35a51cc45a76a070cc688401ae64f2ee

commit 4a2d7e5a35a51cc45a76a070cc688401ae64f2ee
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Wed Oct 10 03:56:11 2018

SignedExchangeRequestHandlerBrowserTest: Test prefetch cases

Bug: 803774
Change-Id: Id8ab5fcaaa0816a806c830bd2bb611e226e7bd12
Reviewed-on: https://chromium-review.googlesource.com/c/1264235
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598206}
[modify] https://crrev.com/4a2d7e5a35a51cc45a76a070cc688401ae64f2ee/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/4a2d7e5a35a51cc45a76a070cc688401ae64f2ee/content/test/data/sxg/prefetch.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b

commit 245821d0c52eb90549eff1e4e2ba4a4bfb619a1b
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Oct 12 01:06:19 2018

Remove Mojo API for SignedHTTPExchange LayoutTests

This removes internal testing API that overrides SignedExchange
signature verification time, which is no longer needed since
--ignore-certificate-errors-spki-list now ignores signature
timestamp errors.

This is mostly a revert of https://crrev.com/c/991833.

Bug: 803774
Change-Id: I5b2f77062d897f6c025566ea98fe740735ae8172
Reviewed-on: https://chromium-review.googlesource.com/c/1270457
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599051}
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/browser/BUILD.gn
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/browser/storage_partition_impl.h
[delete] https://crrev.com/fdaedf46b82802f3117e5a00ba39f4b67b9259ee/content/browser/web_package/web_package_context_impl.cc
[delete] https://crrev.com/fdaedf46b82802f3117e5a00ba39f4b67b9259ee/content/browser/web_package/web_package_context_impl.h
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/public/browser/BUILD.gn
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/public/browser/storage_partition.h
[delete] https://crrev.com/fdaedf46b82802f3117e5a00ba39f4b67b9259ee/content/public/browser/web_package_context.h
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/public/test/test_storage_partition.h
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/shell/browser/content_shell_browser_manifest_overlay.json
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/245821d0c52eb90549eff1e4e2ba4a4bfb619a1b/third_party/blink/public/mojom/BUILD.gn
[delete] https://crrev.com/fdaedf46b82802f3117e5a00ba39f4b67b9259ee/third_party/blink/public/mojom/web_package/OWNERS
[delete] https://crrev.com/fdaedf46b82802f3117e5a00ba39f4b67b9259ee/third_party/blink/public/mojom/web_package/README.md
[delete] https://crrev.com/fdaedf46b82802f3117e5a00ba39f4b67b9259ee/third_party/blink/public/mojom/web_package/web_package_internals.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb0dee4694e580a614f5d380e0c60526cdfd2b90

commit cb0dee4694e580a614f5d380e0c60526cdfd2b90
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Oct 12 05:49:49 2018

Signed Exchange: Populate completion time for inner response

This fixes a bug where Resource Timing for prefetched Signed Exchange
had negative duration value.

Bug: 803774
Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8
Reviewed-on: https://chromium-review.googlesource.com/c/1278546
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599106}
[modify] https://crrev.com/cb0dee4694e580a614f5d380e0c60526cdfd2b90/content/browser/web_package/signed_exchange_loader.cc
[add] https://crrev.com/cb0dee4694e580a614f5d380e0c60526cdfd2b90/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-prefetch-resource-timing.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abcdc459bc65764dcfefc3487cfaf3d5044e5e6c

commit abcdc459bc65764dcfefc3487cfaf3d5044e5e6c
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Nov 02 02:53:22 2018

SignedExchange: Clarify which HTTP methods are allowed

No behaviour change.
This CL clarifies which HTTP methods are actually in the allowed set.

Bug: 803774
Change-Id: Ie787a72c2600b96e97aa8540826b5adf63894715
Reviewed-on: https://chromium-review.googlesource.com/c/1313809
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604812}
[modify] https://crrev.com/abcdc459bc65764dcfefc3487cfaf3d5044e5e6c/content/browser/web_package/signed_exchange_envelope.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d75c9507c02cbe946fb64f84da831fb1b8c2eec6

commit d75c9507c02cbe946fb64f84da831fb1b8c2eec6
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Mon Nov 05 05:02:36 2018

SignedExchange: Check if response code is valid.

Bug: 803774
Change-Id: I4ec00babc22db0d0efb96f8481d724e78ee73cca
Reviewed-on: https://chromium-review.googlesource.com/c/1313712
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605251}
[modify] https://crrev.com/d75c9507c02cbe946fb64f84da831fb1b8c2eec6/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/d75c9507c02cbe946fb64f84da831fb1b8c2eec6/content/browser/web_package/signed_exchange_envelope_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c0ba8ce6b0a5606429616456a77ec8a98ee888b

commit 0c0ba8ce6b0a5606429616456a77ec8a98ee888b
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Mon Nov 05 06:54:15 2018

SignedExchangeEnvelope: Add missing spec ref

Bug: 803774
Change-Id: I259e29f1fc0423e87983d89ac50794cfb1fb3fca
Reviewed-on: https://chromium-review.googlesource.com/c/1317218
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605267}
[modify] https://crrev.com/0c0ba8ce6b0a5606429616456a77ec8a98ee888b/content/browser/web_package/signed_exchange_envelope.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ae7ad748baa983663cad238255142d23d999f9

commit d9ae7ad748baa983663cad238255142d23d999f9
Author: Rob Buis <rbuis@igalia.com>
Date: Mon Nov 12 07:50:03 2018

Add more tests to SignedExchangeUtilsTest

Add more tests to SignedExchangeUtilsTest regarding whitespace in quoted strings
and a string containing b2 but not equal to b2.

Bug: 803774

Change-Id: Idb4948283b9df3d85db60f6229e44be5054e0145
Reviewed-on: https://chromium-review.googlesource.com/c/1328961
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607164}
[modify] https://crrev.com/d9ae7ad748baa983663cad238255142d23d999f9/content/browser/web_package/signed_exchange_utils_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fc51219b532cffb72b2e2d0edcfd1addf0a904b

commit 3fc51219b532cffb72b2e2d0edcfd1addf0a904b
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Nov 26 05:24:14 2018

Signed Exchange: Disallow HEAD request method

As per the Loading Signed Exchanges spec [1], this patch makes
SignedExchangeEnvelope::Parse() fail if the exchange's request method is
not "GET".

[1] https://wicg.github.io/webpackage/loading.html#parse-cbor-headers

Bug: 803774
Change-Id: I4729403f3dae5038bae702b0359e1b98f9a11233
Reviewed-on: https://chromium-review.googlesource.com/c/1350017
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610767}
[modify] https://crrev.com/3fc51219b532cffb72b2e2d0edcfd1addf0a904b/content/browser/web_package/signed_exchange_envelope.cc
[modify] https://crrev.com/3fc51219b532cffb72b2e2d0edcfd1addf0a904b/third_party/blink/web_tests/external/wpt/signed-exchange/resources/generate-test-sxgs.sh
[add] https://crrev.com/3fc51219b532cffb72b2e2d0edcfd1addf0a904b/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg-head-request.sxg
[add] https://crrev.com/3fc51219b532cffb72b2e2d0edcfd1addf0a904b/third_party/blink/web_tests/external/wpt/signed-exchange/resources/sxg-head-request.sxg.headers
[add] https://crrev.com/3fc51219b532cffb72b2e2d0edcfd1addf0a904b/third_party/blink/web_tests/external/wpt/signed-exchange/sxg-head-request.tentative.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8303e6fcf61532ccb89ce4802a9b667f941d889c

commit 8303e6fcf61532ccb89ce4802a9b667f941d889c
Author: Rob Buis <rbuis@igalia.com>
Date: Tue Nov 27 09:13:37 2018

Signed Exchange: Fix error message

Fix error message by making it a proper sentence.

Bug: 803774
Change-Id: I30feb2f5b9aa92653793db92556aaf29371673ec
Reviewed-on: https://chromium-review.googlesource.com/c/1350962
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611049}
[modify] https://crrev.com/8303e6fcf61532ccb89ce4802a9b667f941d889c/content/browser/web_package/signed_exchange_envelope.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f66a7cf4827d1edf730c44ecf80141dd6eace977

commit f66a7cf4827d1edf730c44ecf80141dd6eace977
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Nov 28 02:40:56 2018

Remove VerifyRSA test case from SignedExchangeSignatureVerifierTest

The latest gen-signedexchange cannot generate test data for the case
because RSA keys support has been dropped.

We still have VerifyECDSAP384 test case, so we will not lose test
coverage for unsupported certificate types.

Bug: 803774
Change-Id: I2a1aa7d6cbb57f15f07729eacaa4854a7cbb5ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1351344
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611529}
[modify] https://crrev.com/f66a7cf4827d1edf730c44ecf80141dd6eace977/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[modify] https://crrev.com/f66a7cf4827d1edf730c44ecf80141dd6eace977/content/test/data/sxg/generate-test-certs.sh
[modify] https://crrev.com/f66a7cf4827d1edf730c44ecf80141dd6eace977/content/test/data/sxg/generate-test-sxgs.sh

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/393179e13cbd04c0f833b92a4290990f5d98a05f

commit 393179e13cbd04c0f833b92a4290990f5d98a05f
Author: Rob Buis <rbuis@igalia.com>
Date: Tue Dec 11 07:55:47 2018

Fix generate-test-certs.sh script

Openssl does not take --subj parameter, but -subj.

Bug: 803774
Change-Id: Ie5e1da18941468fc66ea567134a49178b4260aba
Reviewed-on: https://chromium-review.googlesource.com/c/1370177
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#615459}
[modify] https://crrev.com/393179e13cbd04c0f833b92a4290990f5d98a05f/third_party/blink/web_tests/external/wpt/signed-exchange/resources/generate-test-certs.sh