New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803768 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
please use my google.com address
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: readonly_shm_.IsValid() in shared_memory_posix.cc

Project Member Reported by ClusterFuzz, Jan 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5299390427430912

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  readonly_shm_.IsValid() in shared_memory_posix.cc
  base::SharedMemory::GetReadOnlyHandle
  device::GamepadProvider::GetSharedBufferHandle
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=530267:530269

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5299390427430912

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 19 2018

Labels: M-65 ReleaseBlock-Beta ClusterFuzz-Top-Crash
Testcase 5299390427430912 is a top crash on ClusterFuzz for linux platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 2 by ClusterFuzz, Jan 19 2018

Components: Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Jan 19 2018

Labels: Test-Predator-Auto-Owner
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/673ce95d481ea9368c4d4d43ac756ba1d6d9e608 (Correct mojo::WrapSharedMemoryHandle usage).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 4 by roc...@chromium.org, Jan 19 2018

Cc: roc...@chromium.org
 Issue 803785  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e56614acd875018ee48a28633f6d44f2712fb69

commit 5e56614acd875018ee48a28633f6d44f2712fb69
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jan 19 23:57:40 2018

Make gamepad shm sharable read-only

GamepadSharedBuffer was internally creating an anonymous shared memory
object, prohibiting the object from being sharable as anything other
than read-write on some platforms.

This CL corrects the situation.

Bug:  803768 
Change-Id: I122d71753be2dd02d12e5bb9f23c1bfc71623f34
Reviewed-on: https://chromium-review.googlesource.com/877042
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530670}
[modify] https://crrev.com/5e56614acd875018ee48a28633f6d44f2712fb69/device/gamepad/gamepad_provider.cc
[modify] https://crrev.com/5e56614acd875018ee48a28633f6d44f2712fb69/device/gamepad/gamepad_shared_buffer.cc

Project Member

Comment 6 by ClusterFuzz, Jan 20 2018

ClusterFuzz has detected this issue as fixed in range 530659:530671.

Detailed report: https://clusterfuzz.com/testcase?key=5299390427430912

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  readonly_shm_.IsValid() in shared_memory_posix.cc
  base::SharedMemory::GetReadOnlyHandle
  device::GamepadProvider::GetSharedBufferHandle
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=530267:530269
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=530659:530671

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5299390427430912

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jan 20 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5299390427430912 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 9 by roc...@chromium.org, Jan 20 2018

Labels: Merge-Request-65
Labels: -Merge-TBD
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 21 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 22 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03f2f3d5a2700a7a40f560a6cae92165520ef2a1

commit 03f2f3d5a2700a7a40f560a6cae92165520ef2a1
Author: Ken Rockot <rockot@chromium.org>
Date: Mon Jan 22 01:01:54 2018

Make gamepad shm sharable read-only

GamepadSharedBuffer was internally creating an anonymous shared memory
object, prohibiting the object from being sharable as anything other
than read-write on some platforms.

This CL corrects the situation.

TBR=rockot@chromium.org

(cherry picked from commit 5e56614acd875018ee48a28633f6d44f2712fb69)

Bug:  803768 
Change-Id: I122d71753be2dd02d12e5bb9f23c1bfc71623f34
Reviewed-on: https://chromium-review.googlesource.com/877042
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530670}
Reviewed-on: https://chromium-review.googlesource.com/878020
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#11}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/03f2f3d5a2700a7a40f560a6cae92165520ef2a1/device/gamepad/gamepad_provider.cc
[modify] https://crrev.com/03f2f3d5a2700a7a40f560a6cae92165520ef2a1/device/gamepad/gamepad_shared_buffer.cc

Sign in to add a comment