Issue metadata
Sign in to add a comment
|
First run screens button text size shrinks on long press |
||||||||||||||||||||||
Issue descriptionApp Version: 65.0.3319.0 Canary iOS Version: 10.3.3, 11.2 beta 5 Device: iPad only Steps to reproduce: 1. Fresh install chrome and launch chrome 2. Long press and slide to release ‘Accept & continue’ button 3. Tap on ‘Accept & continue’ button 4. Long press and slide to release ‘No, Thank you’ or ‘Continue’ button Observed results: Notice on long press the text of the buttons shrinks Expected results: The text of the button shouldn’t shrink Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M63 Bug reproducible on the current beta channel build (App Version, iOS Version): No on M64 Link to video/image: M65 behavior: https://drive.google.com/file/d/1UbcwF4RfE8xIFfjJ-yr5At5N_3VmY8Cu/view?usp=sharing M64 behavior: https://drive.google.com/file/d/1Y-wRtiAkNfR8CDRu4J_gynUAr_sSQ8M3/view?usp=sharing
,
Jan 19 2018
Definitely. These are MDCButton-s and I don't think we do something special to them (aside them being really big on iPad…). I don't think we changed anything, so I'd diff MDC between M64 and M65.
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b17acb28d6bb401d444032da809e154e75b3b1e0 commit b17acb28d6bb401d444032da809e154e75b3b1e0 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Jan 30 23:12:29 2018 [iOS][Signin] Fixing font issues on the MDCButton With a MDCButton, the font should not be set on the title label, but on the button itself, using: -[MDCButton setTitleFont:forState:] Bug: 803767 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4232f2d080daca4e8fc2e585d51c24c1b10ab1ac Reviewed-on: https://chromium-review.googlesource.com/891221 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533067} [modify] https://crrev.com/b17acb28d6bb401d444032da809e154e75b3b1e0/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm [modify] https://crrev.com/b17acb28d6bb401d444032da809e154e75b3b1e0/ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm
,
Jan 31 2018
,
Jan 31 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 6 2018
Verified in 66.0.3340.0 Canary, iPad Pro iOS11 Looks good.
,
Feb 6 2018
,
Feb 9 2018
Please request merge approval for M65
,
Feb 13 2018
,
Feb 13 2018
This bug requires manual review: Less than 17 days to go before AppStore submit on M65 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 14 2018
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe5a2a77091b1c4f9a60c3e975d0ab26766d78c5 commit fe5a2a77091b1c4f9a60c3e975d0ab26766d78c5 Author: Jérôme Lebel <jlebel@chromium.org> Date: Thu Feb 15 13:34:28 2018 [iOS][Signin] Fixing font issues on the MDCButton With a MDCButton, the font should not be set on the title label, but on the button itself, using: -[MDCButton setTitleFont:forState:] Bug: 803767 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4232f2d080daca4e8fc2e585d51c24c1b10ab1ac Reviewed-on: https://chromium-review.googlesource.com/891221 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533067}(cherry picked from commit b17acb28d6bb401d444032da809e154e75b3b1e0) Reviewed-on: https://chromium-review.googlesource.com/921541 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#475} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/fe5a2a77091b1c4f9a60c3e975d0ab26766d78c5/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm [modify] https://crrev.com/fe5a2a77091b1c4f9a60c3e975d0ab26766d78c5/ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm
,
Feb 21 2018
Verified on chrome beta version 65.0.3325.89 on iPad Air with iOS 11.2.5 and iPad pro with iOS 10.3.3, following steps mentioned comment #0. The text does not shrink. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by stkhapugin@chromium.org
, Jan 19 2018Labels: ReleaseBlock-Stable M-65
Owner: jlebel@chromium.org
Status: Assigned (was: Untriaged)