New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 773586



Sign in to add a comment

Add a paper plane icon as a send button in the inline reply

Project Member Reported by megumihattori@google.com, Jan 19 2018

Issue description

A paper plane icon should be added as a send button in the inline reply.

The mock is below.
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYhMpwexg3v6/files/MCFtDtB7WO4l5T_XIlIkONmqwMSJbxAVNpw
 
Components: -UI>Notifications UI>Shell>Notifications
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b966b1f293e93cee3a9bbfc33ec46ac1aa8fa1af

commit b966b1f293e93cee3a9bbfc33ec46ac1aa8fa1af
Author: Megumi Hattori <megumihattori@google.com>
Date: Thu Jan 25 07:13:00 2018

Add a paper plane icon as a reply button in the inline reply.

This CL adds the paper plane icon as the reply button.
The icon is placed to the right of the text field in the inline reply.

In this CL, the name of NotificationInputMD is changed to NotificationInputTextfieldMD,
and another container view, NotificationInputMD is added
on top of NotificationInputTextfieldMD and NotificationInputReplyButtonMD.

This CL does not include the following features.
- Change the icon color when the textfield is clicked
- Send message when the icon is clicked

Bug:  803759 
Change-Id: I20fe6455a8f3184d188d93892b1fc7c03764b1f4
Reviewed-on: https://chromium-review.googlesource.com/876182
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#531836}
[modify] https://crrev.com/b966b1f293e93cee3a9bbfc33ec46ac1aa8fa1af/ui/message_center/BUILD.gn
[add] https://crrev.com/b966b1f293e93cee3a9bbfc33ec46ac1aa8fa1af/ui/message_center/vector_icons/notification_inline_reply.icon
[modify] https://crrev.com/b966b1f293e93cee3a9bbfc33ec46ac1aa8fa1af/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/b966b1f293e93cee3a9bbfc33ec46ac1aa8fa1af/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/b966b1f293e93cee3a9bbfc33ec46ac1aa8fa1af/ui/message_center/views/notification_view_md_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fd1483ebab80ea3b03821f101851253bc966720

commit 1fd1483ebab80ea3b03821f101851253bc966720
Author: Megumi Hattori <megumihattori@google.com>
Date: Mon Jan 29 03:11:37 2018

Change reply icon color when the textfield is empty in the inline reply.

Before this CL, the reply icon color was opaque white regardless of whether the textfield is empty or not.
This CL Changes the icon color to transparent white (opacity: 38%) when textfield is empty.

BUG= 803759 

Change-Id: Id7824e62fd44b0700ea5608b222cdda4de03048c
Reviewed-on: https://chromium-review.googlesource.com/886204
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#532312}
[modify] https://crrev.com/1fd1483ebab80ea3b03821f101851253bc966720/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/1fd1483ebab80ea3b03821f101851253bc966720/ui/message_center/views/notification_view_md.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8acebcb19bc7f98f6bcf53ff4bd34d31734347aa

commit 8acebcb19bc7f98f6bcf53ff4bd34d31734347aa
Author: Megumi Hattori <megumihattori@google.com>
Date: Mon Jan 29 07:34:11 2018

Enable reply button on the right of the textfield in the inline reply.

This CL enable the reply button on the right of the textfield in the inline reply.
So, the message in the textfield can be submitted not only by pressing enter key but also clicking the reply button.

TEST=message_center_unittests
Bug= 803759 

Change-Id: I6e7518d0fabd329d52d589b2024357869aca2fa2
Reviewed-on: https://chromium-review.googlesource.com/885693
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532345}
[modify] https://crrev.com/8acebcb19bc7f98f6bcf53ff4bd34d31734347aa/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/8acebcb19bc7f98f6bcf53ff4bd34d31734347aa/ui/message_center/views/notification_view_md.h
[modify] https://crrev.com/8acebcb19bc7f98f6bcf53ff4bd34d31734347aa/ui/message_center/views/notification_view_md_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce1a4831bbc35e13acfb03b7c090afac40ad556

commit 1ce1a4831bbc35e13acfb03b7c090afac40ad556
Author: Megumi Hattori <megumihattori@google.com>
Date: Wed Jan 31 03:35:33 2018

Always change reply button color when textfield become empty or not.

The reply button should be white when the textfield is not empty, and should be transparent white when the textfield is empty.
However, when text is cut or pasted using mouse or finger and the textfield become empty or not, the reply button color does not change.
This CL resolved this bug.

Bug= 803759 

Change-Id: Ie307a924b41bddc88f60d9dc1b7ab230e639e0c7
Reviewed-on: https://chromium-review.googlesource.com/890843
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533187}
[modify] https://crrev.com/1ce1a4831bbc35e13acfb03b7c090afac40ad556/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/1ce1a4831bbc35e13acfb03b7c090afac40ad556/ui/message_center/views/notification_view_md.h

Status: Fixed (was: Started)

Sign in to add a comment