chrome://settings doesn't tell you which extension is enforcing a setting when a setting is enforced by an extension
Reported by
93m4qau...@gmail.com,
Jan 19 2018
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 Steps to reproduce the problem: 1. Install uBlock Origin from the Chrome Web Store. 2. Restart Chrome (chrome://restart). 3. Open chrome://settings. 4. Scroll to the bottom and click Advanced. 5. Under the "Privacy and security" section, hover over the extension icon next to the forced disabled "Use a prediction service to load pages more quickly". What is the expected behavior? Chrome tells you that the setting is being enforced by an extension, and that uBlock Origin is the extension enforcing the setting. What went wrong? Chrome only tells you that the setting is being enforced by an extension, and leaves you in the dark about which extension is enforcing the setting. Did this work before? Yes I vaguely remember it working fine before the chrome://settings Material Design update, but there is no flag to go back to the old chrome://settings and I have no clue what the version the change was implemented in Chrome version: 63.0.3239.132 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: This should be an issue with any extension, not just uBlock Origin.
,
Jan 19 2018
Able to reproduce the issue on reported chrome version 63.0.3239.132 and on the latest canary 65.0.3324.0 using Mac 10.12.6, Windows 10 and Ubuntu 14.04. As the issue is seen from M59 from the introduction of Material Design in chrome://settings, hence considering it as Non-regression and marking it as Untriaged. Thanks!
,
Jan 19 2018
,
Jan 19 2018
I am also able to reproduce. It seems that something is wrong with the logic at [1]. Since this function is called with type "extension" name "uBlock Origin" but the code ignores |name| for the case where |type| is "extension. [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js?sq=package:chromium&dr&l=123
,
Feb 26 2018
,
Feb 27 2018
,
Feb 27 2018
,
Feb 27 2018
+namratakannan I don't think this would be desired. Users have been trained through various UI surfaces to treat the indicator next to a control as an enum (with possible values controlled by policy icon, controlled by extension icon), see attachment for the policy case. The desired UI probably needs to be fleshed out with UX here, and we should also ensure that it is a11y friendly. Is there any good reason why this UI is different than the NTP controlled by extension indicator? Could we use a similar UI in all cases, which also allows a user to disable the extension?
,
Feb 27 2018
Another possibility would be to have the extension jigsaw puzzle, and then a tooltip "This setting is being enforced by [extension name]" upon hovering over it.
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88b907593672e1530c42200484e4c604d75dbcdf commit 88b907593672e1530c42200484e4c604d75dbcdf Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Mar 01 03:09:42 2018 MD Extensions: adding extension name to tooltip for preferences enforced by extensions Bug: 803736 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I029e6586db207fb64b3b9ec104fa8275b7129335 Reviewed-on: https://chromium-review.googlesource.com/938314 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540015} [modify] https://crrev.com/88b907593672e1530c42200484e4c604d75dbcdf/chrome/app/generated_resources.grd [modify] https://crrev.com/88b907593672e1530c42200484e4c604d75dbcdf/chrome/test/data/webui/cr_elements/cr_policy_indicator_behavior_tests.js [modify] https://crrev.com/88b907593672e1530c42200484e4c604d75dbcdf/chrome/test/data/webui/cr_elements/cr_policy_strings.js [modify] https://crrev.com/88b907593672e1530c42200484e4c604d75dbcdf/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
,
Mar 1 2018
,
Mar 1 2018
Verified on Chromium 66.0.3359.0 (build 540200). You may change the status to Verified.
,
Mar 1 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by krajshree@chromium.org
, Jan 19 2018