New issue
Advanced search Search tips

Issue 803732 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in CCodec_ProgressiveDecoder::JpegDetectImageType

Project Member Reported by ClusterFuzz, Jan 19 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4851127307993088

Fuzzer: libFuzzer_pdf_codec_jpeg_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  CCodec_ProgressiveDecoder::JpegDetectImageType
  CCodec_ProgressiveDecoder::LoadImageInfo
  XFACodecFuzzer::Fuzz
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=529963:530273

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4851127307993088

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 19 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 19 2018

Labels: Test-Predator-Auto-Owner
Owner: rharrison@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/1602344571ce77e2b2f21376a2294907e24671bf (Move format specific elements out of DetectImageType).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Jan 19 2018

Labels: OS-Mac
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/5ca283f376816522065c0ea35644fcb684f9572f

commit 5ca283f376816522065c0ea35644fcb684f9572f
Author: Ryan Harrison <rharrison@chromium.org>
Date: Fri Jan 19 20:04:38 2018

Remove code added in by a bad rebase or merge

The guard being removed was moved lower down in the code, but it
appears the original creeped back in while I was rebasing at some
point. This is causing clusterfuzz failures.

BUG= chromium:803732 , chromium:803735 

Change-Id: I5bcc6046e64d6060a674f390e243dd8eda9d1d17
Reviewed-on: https://pdfium-review.googlesource.com/23250
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/5ca283f376816522065c0ea35644fcb684f9572f/core/fxcodec/codec/fx_codec_progress.cpp

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a8bd42e10bb6d55f1c0bb37891eed55577a0a8

commit c1a8bd42e10bb6d55f1c0bb37891eed55577a0a8
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Sat Jan 20 00:06:09 2018

Roll src/third_party/pdfium/ f668ed47a..5ca283f37 (2 commits)

https://pdfium.googlesource.com/pdfium.git/+log/f668ed47ae54..5ca283f37681

$ git log f668ed47a..5ca283f37 --date=short --no-merges --format='%ad %ae %s'
2018-01-19 rharrison Remove code added in by a bad rebase or merge
2018-01-19 hnakashima Fix CFX_Matrix.RotateAt()

Created with:
  roll-dep src/third_party/pdfium
BUG= 803732 , 803735 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib98604211a47521d853516da68adcdf091973e43
Reviewed-on: https://chromium-review.googlesource.com/876882
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530677}
[modify] https://crrev.com/c1a8bd42e10bb6d55f1c0bb37891eed55577a0a8/DEPS

Project Member

Comment 8 by ClusterFuzz, Jan 20 2018

ClusterFuzz has detected this issue as fixed in range 530647:530678.

Detailed report: https://clusterfuzz.com/testcase?key=4851127307993088

Fuzzer: libFuzzer_pdf_codec_jpeg_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  CCodec_ProgressiveDecoder::JpegDetectImageType
  CCodec_ProgressiveDecoder::LoadImageInfo
  XFACodecFuzzer::Fuzz
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=529963:530273
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=530647:530678

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4851127307993088

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jan 20 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4851127307993088 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment