Launch tryjobs right after screening a CL for pre-cq |
|||
Issue description| 21249936 | 2218445 | 871253 | 1 | external | validation_pending_pre_cq | chromite-pre-cq | 2018-01-17 20:16:00 | NULL | | 21249937 | 2218445 | 871253 | 1 | external | screened_for_pre_cq | NULL | 2018-01-17 20:16:00 | NULL | | 21253550 | 2218445 | 871253 | 1 | external | trybot_launching | daisy_spring-no-vmtest-pre-cq | 2018-01-17 20:29:51 | 8957120778912985792 | | 21253551 | 2218445 | 871253 | 1 | external | trybot_launching | betty-pre-cq | 2018-01-17 20:29:51 | 8957120778398321152 | After the Pre-CQ-Launcher marks a CL as "screened_for_pre_cq", it doesn't launch tryjobs for this CL immediately. Instead, it scans all the CL candidates again in the next scanning loop and launches the tryjobs for the CL as it has been marked as "screened_for_pre_cq", the latency can go from 8 mins to 20 mins, which can be avoided by screening and launching tryjobs in the same scanning loop.
,
Jan 19 2018
,
Jan 23 2018
another example, there is 50 mins delay | 21235073 | 2218258 | 870874 | 1 | external | screened_for_pre_cq | NULL | 2018-01-17 17:37:26 | NULL | | 21235484 | 2218445 | 870874 | 1 | external | trybot_launching | daisy_spring-no-vmtest-pre-cq | 2018-01-17 18:26:15 | 8957128553778995328 |
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/af686f8293db298f99ef0f5974f5625c673b6060 commit af686f8293db298f99ef0f5974f5625c673b6060 Author: Ningning Xia <nxia@chromium.org> Date: Thu Jan 25 04:24:29 2018 Screen and launch Pre-CQs for ready changes in one cycle. Previously, Pre-CQ-Launcher marks a ready change as "screened_for_pre_cq" in one cycle, then launch Pre-CQs in another cycle. This is wasting time and the two actions can be executed in one cycle. BUG= chromium:803715 TEST=unit_tests Change-Id: I04b723f77eb411dab7e8452d6c71f97c2e5b7f80 Reviewed-on: https://chromium-review.googlesource.com/882162 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/af686f8293db298f99ef0f5974f5625c673b6060/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/af686f8293db298f99ef0f5974f5625c673b6060/cbuildbot/stages/sync_stages.py
,
Jan 30 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nxia@chromium.org
, Jan 19 2018