New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803712 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Background blur sometimes remains in effect on one monitor when device is unlocked

Project Member Reported by w...@chromium.org, Jan 19 2018

Issue description

Chrome Version: 65.0.3319.0
OS: ChromeOS

What steps will reproduce the problem?
(May be specific to dual-monitor displays?)
(1) Set a desktop wallpaper.
(2) Use the device; let it fall idle so it "locks".
(3) Unlock it.

What is the expected result?

Usually the device unlocks and shows the wallpaper image normally.

What happens instead?

Sometimes when unlocking, one or other monitor continues to display the blurred-out background image.

Attached are screenshots of what my two monitors are showing right now, to illustrate.
 
Screenshot 2018-01-18 at 17.21.42 - Display 2.png
3.9 MB View Download
Screenshot 2018-01-18 at 17.21.42 - Display 1.png
1.4 MB View Download

Comment 1 by piman@chromium.org, Jan 19 2018

Components: -Internals>Compositing
Components: UI>Shell>LockScreen
Labels: -Pri-2 Pri-1
Components: -UI>Shell

Comment 4 by w...@chromium.org, Jan 19 2018

Cc: agawronska@chromium.org
Owner: jamescook@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by wzang@chromium.org, Jan 19 2018

Owner: wzang@chromium.org

Comment 6 by wutao@chromium.org, Jan 23 2018

Cc: omrilio@chromium.org wutao@chromium.org

Comment 7 by wutao@chromium.org, Jan 23 2018

Cc: reve...@chromium.org

Comment 8 by wutao@chromium.org, Jan 23 2018

 Issue 804964  has been merged into this issue.

Comment 9 by wzang@chromium.org, Jan 23 2018

I believe this is already fixed by Aga's CL https://chromium-review.googlesource.com/c/chromium/src/+/872128
I will check if my cl addresses that.
Sounds like we have it covered.

Here's a Listnr report with logs from M64 Beta (64.0.3282.79) if you need it: https://listnr.corp.google.com/report/84920210129
Status: Fixed (was: Assigned)
I think it is fixed, please re-open if still happen after cl https://chromium-review.googlesource.com/c/chromium/src/+/872128
Labels: M-64
We may need to evaluate merging fix to M64

Aga,would this be a clean/safe merge to M64?
If so, please tag this as merge-request 

Comment 14 by wzang@chromium.org, Jan 25 2018

Labels: Merge-Request-64
The CL mentioned in comment #12 fixed the issue. I believe this regression was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/827547
(During animation there are two WallpaperWidgetController instances, and the CL only removes blur on the old one, so the new one is still blurred which remains in the active session.)

Comment 15 by wzang@chromium.org, Jan 25 2018

Cc: r...@chromium.org
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 25 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by w...@chromium.org, Jan 26 2018

Labels: Merge-Request-65
Just observed this after unlocking ChromeOS 65.0.3325.9 (Official Build) dev (64-bit).  Looking at the git log it looks like the fix didn't land until branch 3326, which was the first M66.
Project Member

Comment 18 by sheriffbot@chromium.org, Jan 27 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Fairly late for a M64 merge.  Confirmed as a M64 regression, and/or impact in not making the merge?
I manually tested change on M64 cyan 64.0.3282.133 10176.61.0.
I didn't notcie any problems. I aslso successfully run unit tests locally.

Comment 21 by wzang@chromium.org, Jan 29 2018

The patch will make the 'blur removal' code go back to the original state (launched in M61 and has been under test since then).

It simply reverts the 'late blur removal' code which was merged to M64 (crbug.com/789320).

Impact of not making the merge: the bug can't always be reproduced, but when it shows up it's pretty bad. So we believe a merge is necessary.
Labels: -Merge-Review-64 Merge-Approved-64
Approving the merge if this is a M64 revert only.
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 30 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0394210794512fef580b28375535f4056d9444f0

commit 0394210794512fef580b28375535f4056d9444f0
Author: Aga Wronska <agawronska@chromium.org>
Date: Tue Jan 30 20:14:42 2018

Do not delay removing of the blur when unlocking.

TBR=agawronska@chromium.org

(cherry picked from commit f341c59bc188013f67ccd7498806293d5e5802e2)

Bug:  801632 ,  803712 
Change-Id: I559c747a7bd92df052258ef2e18b469e9fe09ef1
Reviewed-on: https://chromium-review.googlesource.com/872128
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530594}
Reviewed-on: https://chromium-review.googlesource.com/891695
Cr-Commit-Position: refs/branch-heads/3282@{#621}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/0394210794512fef580b28375535f4056d9444f0/ash/session/session_controller.cc
[modify] https://crrev.com/0394210794512fef580b28375535f4056d9444f0/ash/session/session_controller.h
[modify] https://crrev.com/0394210794512fef580b28375535f4056d9444f0/ash/wallpaper/wallpaper_controller.cc

Project Member

Comment 24 by sheriffbot@chromium.org, Feb 12 2018

Cc: kbleicher@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-65 merge-merged-3325

Sign in to add a comment