New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 803707 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Add use counters for the image decode API and <img> decoding attribute.

Project Member Reported by chrishtr@chromium.org, Jan 19 2018

Issue description

See summary.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad6465a706b36938273c715c402575ee0e3052c4

commit ad6465a706b36938273c715c402575ee0e3052c4
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Fri Jan 19 20:57:49 2018

[IMG] Add use counters for decode API and decoding attribute.

This patch adds two use counters:
1. ImageDecodeAPI measuring the usage of the image decode api
2. ImageDecodingAttribute measuring the usage of the <img> decoding
   attribute.

R=chrishtr@chromium.org

Bug:  803707 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I398131cb29409d5f6aa1c5f8e0f613d545c288a8
Reviewed-on: https://chromium-review.googlesource.com/876517
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530606}
[modify] https://crrev.com/ad6465a706b36938273c715c402575ee0e3052c4/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/ad6465a706b36938273c715c402575ee0e3052c4/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/ad6465a706b36938273c715c402575ee0e3052c4/third_party/WebKit/Source/core/svg/SVGImageElement.cpp
[modify] https://crrev.com/ad6465a706b36938273c715c402575ee0e3052c4/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/ad6465a706b36938273c715c402575ee0e3052c4/tools/metrics/histograms/enums.xml

Comment 2 by vmp...@chromium.org, Jan 19 2018

Status: Fixed (was: Assigned)

Comment 3 by vmp...@chromium.org, Jan 26 2018

Cc: chrishtr@chromium.org
Labels: M-65 Merge-Request-65
This is a metrics only change that would be really nice to merge to start gathering use-counter data on M65. We'd like to merge this to 65, since it just missed the branch.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 27 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Jan 28 2018

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 29 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c509e74bb3c2a999912e9a5c9c8446b355d38c3

commit 3c509e74bb3c2a999912e9a5c9c8446b355d38c3
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Mon Jan 29 18:51:04 2018

[IMG] Add use counters for decode API and decoding attribute.

This patch adds two use counters:
1. ImageDecodeAPI measuring the usage of the image decode api
2. ImageDecodingAttribute measuring the usage of the <img> decoding
   attribute.

R=chrishtr@chromium.org
TBR=vmpstr@chromium.org

(cherry picked from commit ad6465a706b36938273c715c402575ee0e3052c4)

Bug:  803707 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I398131cb29409d5f6aa1c5f8e0f613d545c288a8
Reviewed-on: https://chromium-review.googlesource.com/876517
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530606}
Reviewed-on: https://chromium-review.googlesource.com/891679
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#146}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/3c509e74bb3c2a999912e9a5c9c8446b355d38c3/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/3c509e74bb3c2a999912e9a5c9c8446b355d38c3/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/3c509e74bb3c2a999912e9a5c9c8446b355d38c3/third_party/WebKit/Source/core/svg/SVGImageElement.cpp
[modify] https://crrev.com/3c509e74bb3c2a999912e9a5c9c8446b355d38c3/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/3c509e74bb3c2a999912e9a5c9c8446b355d38c3/tools/metrics/histograms/enums.xml

Sign in to add a comment