New issue
Advanced search Search tips

Issue 803700 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

PIN drops digits when typing fast

Project Member Reported by omrilio@chromium.org, Jan 19 2018

Issue description

Chrome Version: 65.0.3299.0

What steps will reproduce the problem?
(1) Enable pin unlock
(2) Set a simple password (e.g. 1,2,3,2,1,2,3)
(3) Try to tap keys quickly

What is the expected result?
PIN gets filled in

What happens instead?
Some digits gets skipped

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

Project Member

Comment 3 by sheriffbot@chromium.org, Feb 1 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6949a9e9c116bdf936eaf5d348b9c07b9d49f211

commit 6949a9e9c116bdf936eaf5d348b9c07b9d49f211
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Feb 02 23:26:00 2018

cros: Increase touch target size of pin buttons on lock.

TBR=jdufault@google.com

(cherry picked from commit 91ac7466a8e24b1837a180949ddfd9a631a09a62)

Bug:  803700 
Change-Id: Ie88645a2ec0244b6f5870fdb3187087e918e8855
Reviewed-on: https://chromium-review.googlesource.com/884561
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533134}
Reviewed-on: https://chromium-review.googlesource.com/899504
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#274}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/6949a9e9c116bdf936eaf5d348b9c07b9d49f211/ash/login/ui/login_button.h
[modify] https://crrev.com/6949a9e9c116bdf936eaf5d348b9c07b9d49f211/ash/login/ui/login_pin_view.cc
[modify] https://crrev.com/6949a9e9c116bdf936eaf5d348b9c07b9d49f211/ash/login/ui/login_pin_view.h
[modify] https://crrev.com/6949a9e9c116bdf936eaf5d348b9c07b9d49f211/ash/login/ui/login_pin_view_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69bc247b9008e783ea9527c82ea5544f2d70390e

commit 69bc247b9008e783ea9527c82ea5544f2d70390e
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Feb 02 23:27:24 2018

cros: Do not use views::Button for PIN keyboard.

TBR=jdufault@google.com

(cherry picked from commit f2f63601fbd44cea4b3823c4896d78cf26fa04d1)

Change-Id: Idaa6a2eefc94166e95d75ff726a704c5e071b16d
Reviewed-on: https://chromium-review.googlesource.com/889716
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533389}
Bug:  803700 
Reviewed-on: https://chromium-review.googlesource.com/899505
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#275}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/69bc247b9008e783ea9527c82ea5544f2d70390e/ash/login/ui/hover_notifier.cc
[modify] https://crrev.com/69bc247b9008e783ea9527c82ea5544f2d70390e/ash/login/ui/hover_notifier.h
[modify] https://crrev.com/69bc247b9008e783ea9527c82ea5544f2d70390e/ash/login/ui/login_pin_view.cc
[modify] https://crrev.com/69bc247b9008e783ea9527c82ea5544f2d70390e/ash/login/ui/login_pin_view.h

Status: Fixed (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b8e53bdd4a3d37095bad99f2d388c4eb525daec

commit 9b8e53bdd4a3d37095bad99f2d388c4eb525daec
Author: Pavol Marko <pmarko@chromium.org>
Date: Mon Feb 05 16:57:42 2018

Fix compile on M-65 branch (ax enums)

The refactor of ax_enums.idl (CL:877417) was not merged to M-65, but
CL:899505 had a dependency on that.

Change the enum to the old version so M-65 compiles without CL:877417.

BUG= 803700 

Change-Id: I0f79b25697f2354f764c13e9e7b406840133a5e4
Reviewed-on: https://chromium-review.googlesource.com/901283
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#300}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9b8e53bdd4a3d37095bad99f2d388c4eb525daec/ash/login/ui/login_pin_view.cc

Sign in to add a comment